You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2026/10/17 13:18:19 UTC

(spark) branch master updated: [MINOR][SQL] Fix the @since version of ORC Types Framework ops that ship in Spark 4.3.0

This is an automated email from the ASF dual-hosted git repository.

cloud-fan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new fc6371de0084 [MINOR][SQL] Fix the @since version of ORC Types Framework ops that ship in Spark 4.3.0
fc6371de0084 is described below

commit fc6371de008490d22ad635ab7b388eb48b9107db
Author: Wenchen Fan <we...@databricks.com>
AuthorDate: Sat Oct 17 13:18:04 2026 +0000

    [MINOR][SQL] Fix the @since version of ORC Types Framework ops that ship in Spark 4.3.0
    
    ### What changes were proposed in this pull request?
    
    Change `since 5.0.0` to `since 4.3.0` in the scaladoc of four ORC Types Framework ops classes under `sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/`:
    
    - `OrcTypeOps` (added in SPARK-58466)
    - `TimeTypeOrcOps` (added in SPARK-58466)
    - `TimestampLTZNanosOrcOps` and `TimestampNTZNanosOrcOps` (added in SPARK-58466 / SPARK-57823)
    
    ### Why are the changes needed?
    
    These classes are already on `branch-4.3` (they are part of `v4.3.0-rc2`), so they first ship in Spark 4.3.0, not 5.0.0. The other Types Framework ops classes already say `since 4.3.0`; these four are the only remaining `since 5.0.0` tags on `branch-4.3` and `branch-4.x`. This is a follow-up to #59490, which fixed the same mismatch for two SQL configs.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No. Scaladoc-only change on internal (`private[orc]` / `execution`-package) classes.
    
    ### How was this patch tested?
    
    Comment-only change; no new tests. Verified with `git grep -E 'since 5\.0\.0|version\("5\.0\.0"\)|Since\("5\.0\.0"\)|version(added|changed):: 5\.0\.0'` that these were the only such occurrences on `branch-4.3` and `branch-4.x`.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Opus 5.5)
    
    This pull request and its description were written by Isaac.
    
    Closes #59536 from cloud-fan/wenchen/orc-type-ops-since-4.3.0.
    
    Authored-by: Wenchen Fan <we...@databricks.com>
    Signed-off-by: Wenchen Fan <we...@databricks.com>
---
 .../spark/sql/execution/datasources/orc/types/ops/OrcTypeOps.scala    | 2 +-
 .../sql/execution/datasources/orc/types/ops/TimeTypeOrcOps.scala      | 2 +-
 .../execution/datasources/orc/types/ops/TimestampNanosOrcOps.scala    | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/OrcTypeOps.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/OrcTypeOps.scala
index b5a2a6010368..c0bcb1ddeabb 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/OrcTypeOps.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/OrcTypeOps.scala
@@ -84,7 +84,7 @@ import org.apache.spark.sql.types.{DataType, TimestampLTZNanosType, TimestampNTZ
  *
  * @see TimeTypeOrcOps for a reference implementation (primitive Long-backed type)
  * @see TimestampLTZNanosOrcOps / TimestampNTZNanosOrcOps for OrcTimestamp-backed types
- * @since 5.0.0
+ * @since 4.3.0
  */
 private[orc] trait OrcTypeOps extends Serializable {
 
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimeTypeOrcOps.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimeTypeOrcOps.scala
index 1896a2712eec..c54cef5c3fd2 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimeTypeOrcOps.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimeTypeOrcOps.scala
@@ -38,7 +38,7 @@ import org.apache.spark.sql.types.{LongType, TimeType}
  *
  * @param t the TimeType (precision is unused on the ORC path; kept for symmetry with the other
  *          storage ops and possible future precision-aware behavior).
- * @since 5.0.0
+ * @since 4.3.0
  */
 case class TimeTypeOrcOps(t: TimeType) extends OrcTypeOps {
 
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimestampNanosOrcOps.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimestampNanosOrcOps.scala
index 5d5923b5b571..7ea09e284822 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimestampNanosOrcOps.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/types/ops/TimestampNanosOrcOps.scala
@@ -48,7 +48,7 @@ import org.apache.spark.unsafe.types.TimestampNanosVal
  * UTC wall clock, via Timestamp.valueOf(LocalDateTime.ofInstant(instant, UTC)). This keeps the
  * pushed predicate consistent with the ORC min/max statistics regardless of the JVM time zone.
  *
- * @since 5.0.0
+ * @since 4.3.0
  */
 case class TimestampLTZNanosOrcOps(t: TimestampLTZNanosType) extends OrcTypeOps {
 
@@ -111,7 +111,7 @@ case class TimestampLTZNanosOrcOps(t: TimestampLTZNanosType) extends OrcTypeOps
  * super-value, so the two are value-equal and the pushed predicate is consistent with the ORC
  * min/max statistics.
  *
- * @since 5.0.0
+ * @since 4.3.0
  */
 case class TimestampNTZNanosOrcOps(t: TimestampNTZNanosType) extends OrcTypeOps {
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org