You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/02/16 23:04:12 UTC
[kudu-CR] [tserver] avoid copying Schema in SplitKeyRange()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18238
Change subject: [tserver] avoid copying Schema in SplitKeyRange()
......................................................................
[tserver] avoid copying Schema in SplitKeyRange()
This patch cleans up the code in src/kudu/tserver/tablet_service.cc
a bit to stop copying Schema in TabletServiceImpl::SplitKeyRange();
other minor clean up.
This is a follow-up to d4ded71bc0edadcbe2564d5677d319f35e48dad8.
Change-Id: I07642a438a4eeee6812828ddd871534bdf985155
---
M src/kudu/common/key_range.h
M src/kudu/tserver/tablet_service.cc
2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/18238/1
--
To view, visit http://gerrit.cloudera.org:8080/18238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07642a438a4eeee6812828ddd871534bdf985155
Gerrit-Change-Number: 18238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tserver] avoid copying Schema in SplitKeyRange()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18238 )
Change subject: [tserver] avoid copying Schema in SplitKeyRange()
......................................................................
[tserver] avoid copying Schema in SplitKeyRange()
This patch cleans up the code in src/kudu/tserver/tablet_service.cc
a bit to stop copying Schema in TabletServiceImpl::SplitKeyRange();
other minor clean up.
This is a follow-up to d4ded71bc0edadcbe2564d5677d319f35e48dad8.
Change-Id: I07642a438a4eeee6812828ddd871534bdf985155
Reviewed-on: http://gerrit.cloudera.org:8080/18238
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/common/key_range.h
M src/kudu/tserver/tablet_service.cc
2 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07642a438a4eeee6812828ddd871534bdf985155
Gerrit-Change-Number: 18238
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tserver] avoid copying Schema in SplitKeyRange()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18238 )
Change subject: [tserver] avoid copying Schema in SplitKeyRange()
......................................................................
Patch Set 1:
> The test failures seem unrelated, though perhaps this one's related
> to the recent Thread change?
>
> threadpool.cc:306] Check failed: 1 == tokens_.size() (1 vs. 3)
> Threadpool raft destroyed with 3 allocated tokens
> @ 0x477930 __tsan::CallUserSignalHandler() at
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1916
> @ 0x479e47 rtl_sigaction() at /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:2006
> @ 0x7f81497f3fb7 gsignal at ??:0
> @ 0x7f81497f5921 abort at ??:0
> @ 0x480f66 abort at /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:261
> @ 0x7f814c979e47 kudu::ThreadPool::~ThreadPool() at ??:0
> @ 0x7f8153c3854f std::__1::default_delete<>::operator()() at
> ??:0
> @ 0x7f8153c384be std::__1::unique_ptr<>::reset() at ??:0
> @ 0x7f8153bf7cfc std::__1::unique_ptr<>::~unique_ptr() at ??:0
> @ 0x7f8153c98b54 kudu::kserver::KuduServer::~KuduServer() at
> ??:0
> @ 0x7f8153c916eb kudu::master::Master::~Master() at ??:0
> @ 0x7f8153c9199a kudu::master::Master::~Master() at ??:0
> @ 0x7f8153cc8c78 std::__1::default_delete<>::operator()() at
> ??:0
> @ 0x7f8153cc1f9e std::__1::unique_ptr<>::reset() at ??:0
> @ 0x7f8153cd8393 kudu::master::MiniMaster::Shutdown() at ??:0
> @ 0x4ff669 kudu::tools::RemoteKsckTest_TestClusterWithLocation_Test::TestBody()
> at /home/jenkins-slave/workspace/kudu-master/2/src/kudu/tools/ksck_remote-test.cc:606
> @ 0x7f8154951e1c RUN_ALL_TESTS() at ??:0
> @ 0x7f8154950c6a main at ??:0
> @ 0x7f81497d6bf7 __libc_start_main at ??:0
> @ 0x4433aa _start at ??:?
>
> https://gerrit.cloudera.org/c/18229/
>
> Looking through a bit, I don't think so though. Will dig a bit
> more.
Thank you for the review!
I don't think that the issue with SIGABRT on shutdown is a direct consequence of the very recent change on thread.{cc,h}, but I might be mistaken.
From what I could see from the logs, it seems the issue is that the system tablet wasn't shutdown (?) when master's Shutdown() methods completed (see thread 11915 in the logs):
I0216 23:21:53.056661 11915 raft_consensus.cc:2227] T 00000000000000000000000000000000 P 8ffb1b8a80764dcab6d0fd9860c9ef7a [term 1 FOLLOWER]: Raft consensus shutting down.
I0216 23:21:53.057236 11915 raft_consensus.cc:2256] T 00000000000000000000000000000000 P 8ffb1b8a80764dcab6d0fd9860c9ef7a [term 1 FOLLOWER]: Raft consensus is shut down!
I0216 23:21:53.057643 11915 tablet_replica.cc:323] T 00000000000000000000000000000000 P 8ffb1b8a80764dcab6d0fd9860c9ef7a: stopping tablet replica
--
To view, visit http://gerrit.cloudera.org:8080/18238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07642a438a4eeee6812828ddd871534bdf985155
Gerrit-Change-Number: 18238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Feb 2022 02:13:43 +0000
Gerrit-HasComments: No
[kudu-CR] [tserver] avoid copying Schema in SplitKeyRange()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18238 )
Change subject: [tserver] avoid copying Schema in SplitKeyRange()
......................................................................
Patch Set 1: Verified+1 Code-Review+2
The test failures seem unrelated, though perhaps this one's related to the recent Thread change?
threadpool.cc:306] Check failed: 1 == tokens_.size() (1 vs. 3) Threadpool raft destroyed with 3 allocated tokens
@ 0x477930 __tsan::CallUserSignalHandler() at /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1916
@ 0x479e47 rtl_sigaction() at /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:2006
@ 0x7f81497f3fb7 gsignal at ??:0
@ 0x7f81497f5921 abort at ??:0
@ 0x480f66 abort at /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:261
@ 0x7f814c979e47 kudu::ThreadPool::~ThreadPool() at ??:0
@ 0x7f8153c3854f std::__1::default_delete<>::operator()() at ??:0
@ 0x7f8153c384be std::__1::unique_ptr<>::reset() at ??:0
@ 0x7f8153bf7cfc std::__1::unique_ptr<>::~unique_ptr() at ??:0
@ 0x7f8153c98b54 kudu::kserver::KuduServer::~KuduServer() at ??:0
@ 0x7f8153c916eb kudu::master::Master::~Master() at ??:0
@ 0x7f8153c9199a kudu::master::Master::~Master() at ??:0
@ 0x7f8153cc8c78 std::__1::default_delete<>::operator()() at ??:0
@ 0x7f8153cc1f9e std::__1::unique_ptr<>::reset() at ??:0
@ 0x7f8153cd8393 kudu::master::MiniMaster::Shutdown() at ??:0
@ 0x4ff669 kudu::tools::RemoteKsckTest_TestClusterWithLocation_Test::TestBody() at /home/jenkins-slave/workspace/kudu-master/2/src/kudu/tools/ksck_remote-test.cc:606
@ 0x7f8154951e1c RUN_ALL_TESTS() at ??:0
@ 0x7f8154950c6a main at ??:0
@ 0x7f81497d6bf7 __libc_start_main at ??:0
@ 0x4433aa _start at ??:?
https://gerrit.cloudera.org/c/18229/
Looking through a bit, I don't think so though. Will dig a bit more.
--
To view, visit http://gerrit.cloudera.org:8080/18238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07642a438a4eeee6812828ddd871534bdf985155
Gerrit-Change-Number: 18238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Feb 2022 01:10:48 +0000
Gerrit-HasComments: No
[kudu-CR] [tserver] avoid copying Schema in SplitKeyRange()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [tserver] avoid copying Schema in SplitKeyRange()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I07642a438a4eeee6812828ddd871534bdf985155
Gerrit-Change-Number: 18238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)