You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2017/12/12 15:18:20 UTC
[02/18] hbase-site git commit: Published site at .
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html b/testdevapidocs/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html
index 2ef9e16..70f9e92 100644
--- a/testdevapidocs/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html
+++ b/testdevapidocs/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html
@@ -18,8 +18,8 @@
catch(err) {
}
//-->
-var methods = {"i0":10,"i1":10,"i2":10};
-var tabs = {65535:["t0","All Methods"],2:["t2","Instance Methods"],8:["t4","Concrete Methods"]};
+var methods = {"i0":10,"i1":9,"i2":10,"i3":10,"i4":10,"i5":10,"i6":9,"i7":10};
+var tabs = {65535:["t0","All Methods"],1:["t1","Static Methods"],2:["t2","Instance Methods"],8:["t4","Concrete Methods"]};
var altColor = "altColor";
var rowColor = "rowColor";
var tableTab = "tableTab";
@@ -109,15 +109,17 @@ var activeTableTab = "activeTableTab";
<li class="blockList">
<hr>
<br>
-<pre>public class <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.58">TestWALMonotonicallyIncreasingSeqId</a>
+<pre>public class <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.78">TestWALMonotonicallyIncreasingSeqId</a>
extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?is-external=true" title="class or interface in java.lang">Object</a></pre>
-<div class="block">Test for HBASE-17471
- MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete
- path. Other write paths like increment/append still assign mvcc in ringbuffer's consumer
- thread. If put and increment are used parallel. Then seqid in WAL may not increase monotonically
- Disorder in wals will lead to data loss.
- This case use two thread to put and increment at the same time in a single region.
- Then check the seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail</div>
+<div class="block">Test for HBASE-17471.
+ <p>
+ MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete path. Other
+ write paths like increment/append still assign mvcc in ringbuffer's consumer thread. If put and
+ increment are used parallel. Then seqid in WAL may not increase monotonically Disorder in wals
+ will lead to data loss.
+ <p>
+ This case use two thread to put and increment at the same time in a single region. Then check the
+ seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail</div>
</li>
</ul>
</div>
@@ -164,29 +166,21 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#fileSystem">fileSystem</a></span></code> </td>
</tr>
<tr class="rowColor">
-<td class="colFirst"><code>static <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/String.html?is-external=true" title="class or interface in java.lang">String</a></code></td>
-<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#KEY_SEED">KEY_SEED</a></span></code> </td>
-</tr>
-<tr class="altColor">
-<td class="colFirst"><code>private static char[]</code></td>
-<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#KEY_SEED_CHARS">KEY_SEED_CHARS</a></span></code> </td>
-</tr>
-<tr class="rowColor">
-<td class="colFirst"><code>private static int</code></td>
-<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#KEY_SEED_LEN">KEY_SEED_LEN</a></span></code> </td>
-</tr>
-<tr class="altColor">
<td class="colFirst"><code>(package private) <a href="http://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html?is-external=true" title="class or interface in java.util.concurrent">CountDownLatch</a></code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#latch">latch</a></span></code> </td>
</tr>
-<tr class="rowColor">
-<td class="colFirst"><code>(package private) org.apache.commons.logging.Log</code></td>
+<tr class="altColor">
+<td class="colFirst"><code>private org.apache.commons.logging.Log</code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#LOG">LOG</a></span></code> </td>
</tr>
-<tr class="altColor">
+<tr class="rowColor">
<td class="colFirst"><code>org.junit.rules.TestName</code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#name">name</a></span></code> </td>
</tr>
+<tr class="altColor">
+<td class="colFirst"><code>private org.apache.hadoop.hbase.regionserver.HRegion</code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#region">region</a></span></code> </td>
+</tr>
<tr class="rowColor">
<td class="colFirst"><code>private static <a href="../../../../../org/apache/hadoop/hbase/HBaseTestingUtility.html" title="class in org.apache.hadoop.hbase">HBaseTestingUtility</a></code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#TEST_UTIL">TEST_UTIL</a></span></code> </td>
@@ -200,6 +194,10 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#walConf">walConf</a></span></code> </td>
</tr>
<tr class="altColor">
+<td class="colFirst"><code><a href="http://docs.oracle.com/javase/8/docs/api/java/lang/String.html?is-external=true" title="class or interface in java.lang">String</a></code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#walProvider">walProvider</a></span></code> </td>
+</tr>
+<tr class="rowColor">
<td class="colFirst"><code>private org.apache.hadoop.hbase.wal.WALFactory</code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#wals">wals</a></span></code> </td>
</tr>
@@ -230,26 +228,47 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
</a>
<h3>Method Summary</h3>
<table class="memberSummary" border="0" cellpadding="3" cellspacing="0" summary="Method Summary table, listing methods, and an explanation">
-<caption><span id="t0" class="activeTableTab"><span>All Methods</span><span class="tabEnd"> </span></span><span id="t2" class="tableTab"><span><a href="javascript:show(2);">Instance Methods</a></span><span class="tabEnd"> </span></span><span id="t4" class="tableTab"><span><a href="javascript:show(8);">Concrete Methods</a></span><span class="tabEnd"> </span></span></caption>
+<caption><span id="t0" class="activeTableTab"><span>All Methods</span><span class="tabEnd"> </span></span><span id="t1" class="tableTab"><span><a href="javascript:show(1);">Static Methods</a></span><span class="tabEnd"> </span></span><span id="t2" class="tableTab"><span><a href="javascript:show(2);">Instance Methods</a></span><span class="tabEnd"> </span></span><span id="t4" class="tableTab"><span><a href="javascript:show(8);">Concrete Methods</a></span><span class="tabEnd"> </span></span></caption>
<tr>
<th class="colFirst" scope="col">Modifier and Type</th>
<th class="colLast" scope="col">Method and Description</th>
</tr>
<tr id="i0" class="altColor">
-<td class="colFirst"><code>private org.apache.hadoop.hbase.HTableDescriptor</code></td>
+<td class="colFirst"><code>private org.apache.hadoop.hbase.wal.WAL.Reader</code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#createReader-org.apache.hadoop.fs.Path-org.apache.hadoop.fs.Path-">createReader</a></span>(org.apache.hadoop.fs.Path logPath,
+ org.apache.hadoop.fs.Path oldWalsDir)</code> </td>
+</tr>
+<tr id="i1" class="rowColor">
+<td class="colFirst"><code>static <a href="http://docs.oracle.com/javase/8/docs/api/java/util/List.html?is-external=true" title="class or interface in java.util">List</a><<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?is-external=true" title="class or interface in java.lang">Object</a>[]></code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#data--">data</a></span>()</code> </td>
+</tr>
+<tr id="i2" class="altColor">
+<td class="colFirst"><code>private org.apache.hadoop.hbase.client.TableDescriptor</code></td>
<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#getTableDesc-org.apache.hadoop.hbase.TableName-byte:A...-">getTableDesc</a></span>(org.apache.hadoop.hbase.TableName tableName,
byte[]... families)</code> </td>
</tr>
-<tr id="i1" class="rowColor">
-<td class="colFirst"><code>private org.apache.hadoop.hbase.regionserver.Region</code></td>
-<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#initHRegion-org.apache.hadoop.hbase.HTableDescriptor-byte:A-byte:A-int-">initHRegion</a></span>(org.apache.hadoop.hbase.HTableDescriptor htd,
+<tr id="i3" class="rowColor">
+<td class="colFirst"><code>private org.apache.hadoop.hbase.regionserver.HRegion</code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#initHRegion-org.apache.hadoop.hbase.client.TableDescriptor-byte:A-byte:A-int-">initHRegion</a></span>(org.apache.hadoop.hbase.client.TableDescriptor htd,
byte[] startKey,
byte[] stopKey,
int replicaId)</code> </td>
</tr>
-<tr id="i2" class="altColor">
+<tr id="i4" class="altColor">
<td class="colFirst"><code>void</code></td>
-<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#TestWALMonotonicallyIncreasingSeqId--">TestWALMonotonicallyIncreasingSeqId</a></span>()</code> </td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#setUp--">setUp</a></span>()</code> </td>
+</tr>
+<tr id="i5" class="rowColor">
+<td class="colFirst"><code>void</code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#tearDown--">tearDown</a></span>()</code> </td>
+</tr>
+<tr id="i6" class="altColor">
+<td class="colFirst"><code>static void</code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#tearDownAfterClass--">tearDownAfterClass</a></span>()</code> </td>
+</tr>
+<tr id="i7" class="rowColor">
+<td class="colFirst"><code>void</code></td>
+<td class="colLast"><code><span class="memberNameLink"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#testWALMonotonicallyIncreasingSeqId--">testWALMonotonicallyIncreasingSeqId</a></span>()</code> </td>
</tr>
</table>
<ul class="blockList">
@@ -279,7 +298,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockList">
<li class="blockList">
<h4>LOG</h4>
-<pre>final org.apache.commons.logging.Log <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.59">LOG</a></pre>
+<pre>private final org.apache.commons.logging.Log <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.79">LOG</a></pre>
</li>
</ul>
<a name="TEST_UTIL">
@@ -288,7 +307,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockList">
<li class="blockList">
<h4>TEST_UTIL</h4>
-<pre>private static final <a href="../../../../../org/apache/hadoop/hbase/HBaseTestingUtility.html" title="class in org.apache.hadoop.hbase">HBaseTestingUtility</a> <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.60">TEST_UTIL</a></pre>
+<pre>private static final <a href="../../../../../org/apache/hadoop/hbase/HBaseTestingUtility.html" title="class in org.apache.hadoop.hbase">HBaseTestingUtility</a> <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.80">TEST_UTIL</a></pre>
</li>
</ul>
<a name="testDir">
@@ -297,7 +316,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockList">
<li class="blockList">
<h4>testDir</h4>
-<pre>private static org.apache.hadoop.fs.Path <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.61">testDir</a></pre>
+<pre>private static org.apache.hadoop.fs.Path <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.81">testDir</a></pre>
</li>
</ul>
<a name="wals">
@@ -306,7 +325,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockList">
<li class="blockList">
<h4>wals</h4>
-<pre>private org.apache.hadoop.hbase.wal.WALFactory <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.62">wals</a></pre>
+<pre>private org.apache.hadoop.hbase.wal.WALFactory <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.82">wals</a></pre>
</li>
</ul>
<a name="fileSystem">
@@ -315,7 +334,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockList">
<li class="blockList">
<h4>fileSystem</h4>
-<pre>private org.apache.hadoop.fs.FileSystem <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.63">fileSystem</a></pre>
+<pre>private org.apache.hadoop.fs.FileSystem <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.83">fileSystem</a></pre>
</li>
</ul>
<a name="walConf">
@@ -324,38 +343,25 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockList">
<li class="blockList">
<h4>walConf</h4>
-<pre>private org.apache.hadoop.conf.Configuration <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.64">walConf</a></pre>
-</li>
-</ul>
-<a name="KEY_SEED">
-<!-- -->
-</a>
-<ul class="blockList">
-<li class="blockList">
-<h4>KEY_SEED</h4>
-<pre>public static final <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/String.html?is-external=true" title="class or interface in java.lang">String</a> <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.66">KEY_SEED</a></pre>
-<dl>
-<dt><span class="seeLabel">See Also:</span></dt>
-<dd><a href="../../../../../constant-values.html#org.apache.hadoop.hbase.regionserver.TestWALMonotonicallyIncreasingSeqId.KEY_SEED">Constant Field Values</a></dd>
-</dl>
+<pre>private org.apache.hadoop.conf.Configuration <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.84">walConf</a></pre>
</li>
</ul>
-<a name="KEY_SEED_LEN">
+<a name="region">
<!-- -->
</a>
<ul class="blockList">
<li class="blockList">
-<h4>KEY_SEED_LEN</h4>
-<pre>private static final int <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.68">KEY_SEED_LEN</a></pre>
+<h4>region</h4>
+<pre>private org.apache.hadoop.hbase.regionserver.HRegion <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.85">region</a></pre>
</li>
</ul>
-<a name="KEY_SEED_CHARS">
+<a name="walProvider">
<!-- -->
</a>
<ul class="blockList">
<li class="blockList">
-<h4>KEY_SEED_CHARS</h4>
-<pre>private static final char[] <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.70">KEY_SEED_CHARS</a></pre>
+<h4>walProvider</h4>
+<pre>public <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/String.html?is-external=true" title="class or interface in java.lang">String</a> <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.88">walProvider</a></pre>
</li>
</ul>
<a name="name">
@@ -364,7 +370,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockList">
<li class="blockList">
<h4>name</h4>
-<pre>public org.junit.rules.TestName <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.73">name</a></pre>
+<pre>public org.junit.rules.TestName <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.91">name</a></pre>
</li>
</ul>
<a name="latch">
@@ -373,7 +379,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockListLast">
<li class="blockList">
<h4>latch</h4>
-<pre><a href="http://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html?is-external=true" title="class or interface in java.util.concurrent">CountDownLatch</a> <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.105">latch</a></pre>
+<pre><a href="http://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html?is-external=true" title="class or interface in java.util.concurrent">CountDownLatch</a> <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.126">latch</a></pre>
</li>
</ul>
</li>
@@ -390,7 +396,7 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<ul class="blockListLast">
<li class="blockList">
<h4>TestWALMonotonicallyIncreasingSeqId</h4>
-<pre>public <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.58">TestWALMonotonicallyIncreasingSeqId</a>()</pre>
+<pre>public <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.78">TestWALMonotonicallyIncreasingSeqId</a>()</pre>
</li>
</ul>
</li>
@@ -401,40 +407,106 @@ extends <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?
<!-- -->
</a>
<h3>Method Detail</h3>
+<a name="data--">
+<!-- -->
+</a>
+<ul class="blockList">
+<li class="blockList">
+<h4>data</h4>
+<pre>public static <a href="http://docs.oracle.com/javase/8/docs/api/java/util/List.html?is-external=true" title="class or interface in java.util">List</a><<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html?is-external=true" title="class or interface in java.lang">Object</a>[]> <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.94">data</a>()</pre>
+</li>
+</ul>
<a name="getTableDesc-org.apache.hadoop.hbase.TableName-byte:A...-">
<!-- -->
</a>
<ul class="blockList">
<li class="blockList">
<h4>getTableDesc</h4>
-<pre>private org.apache.hadoop.hbase.HTableDescriptor <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.75">getTableDesc</a>(org.apache.hadoop.hbase.TableName tableName,
- byte[]... families)</pre>
+<pre>private org.apache.hadoop.hbase.client.TableDescriptor <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.98">getTableDesc</a>(org.apache.hadoop.hbase.TableName tableName,
+ byte[]... families)</pre>
</li>
</ul>
-<a name="initHRegion-org.apache.hadoop.hbase.HTableDescriptor-byte:A-byte:A-int-">
+<a name="initHRegion-org.apache.hadoop.hbase.client.TableDescriptor-byte:A-byte:A-int-">
<!-- -->
</a>
<ul class="blockList">
<li class="blockList">
<h4>initHRegion</h4>
-<pre>private org.apache.hadoop.hbase.regionserver.Region <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.86">initHRegion</a>(org.apache.hadoop.hbase.HTableDescriptor htd,
- byte[] startKey,
- byte[] stopKey,
- int replicaId)
- throws <a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></pre>
+<pre>private org.apache.hadoop.hbase.regionserver.HRegion <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.106">initHRegion</a>(org.apache.hadoop.hbase.client.TableDescriptor htd,
+ byte[] startKey,
+ byte[] stopKey,
+ int replicaId)
+ throws <a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></pre>
<dl>
<dt><span class="throwsLabel">Throws:</span></dt>
<dd><code><a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></code></dd>
</dl>
</li>
</ul>
-<a name="TestWALMonotonicallyIncreasingSeqId--">
+<a name="setUp--">
+<!-- -->
+</a>
+<ul class="blockList">
+<li class="blockList">
+<h4>setUp</h4>
+<pre>public void <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.180">setUp</a>()
+ throws <a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></pre>
+<dl>
+<dt><span class="throwsLabel">Throws:</span></dt>
+<dd><code><a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></code></dd>
+</dl>
+</li>
+</ul>
+<a name="tearDown--">
+<!-- -->
+</a>
+<ul class="blockList">
+<li class="blockList">
+<h4>tearDown</h4>
+<pre>public void <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.188">tearDown</a>()
+ throws <a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></pre>
+<dl>
+<dt><span class="throwsLabel">Throws:</span></dt>
+<dd><code><a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></code></dd>
+</dl>
+</li>
+</ul>
+<a name="tearDownAfterClass--">
+<!-- -->
+</a>
+<ul class="blockList">
+<li class="blockList">
+<h4>tearDownAfterClass</h4>
+<pre>public static void <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.195">tearDownAfterClass</a>()
+ throws <a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></pre>
+<dl>
+<dt><span class="throwsLabel">Throws:</span></dt>
+<dd><code><a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></code></dd>
+</dl>
+</li>
+</ul>
+<a name="createReader-org.apache.hadoop.fs.Path-org.apache.hadoop.fs.Path-">
+<!-- -->
+</a>
+<ul class="blockList">
+<li class="blockList">
+<h4>createReader</h4>
+<pre>private org.apache.hadoop.hbase.wal.WAL.Reader <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.199">createReader</a>(org.apache.hadoop.fs.Path logPath,
+ org.apache.hadoop.fs.Path oldWalsDir)
+ throws <a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></pre>
+<dl>
+<dt><span class="throwsLabel">Throws:</span></dt>
+<dd><code><a href="http://docs.oracle.com/javase/8/docs/api/java/io/IOException.html?is-external=true" title="class or interface in java.io">IOException</a></code></dd>
+</dl>
+</li>
+</ul>
+<a name="testWALMonotonicallyIncreasingSeqId--">
<!-- -->
</a>
<ul class="blockListLast">
<li class="blockList">
-<h4>TestWALMonotonicallyIncreasingSeqId</h4>
-<pre>public void <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.160">TestWALMonotonicallyIncreasingSeqId</a>()
+<h4>testWALMonotonicallyIncreasingSeqId</h4>
+<pre>public void <a href="../../../../../src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html#line.208">testWALMonotonicallyIncreasingSeqId</a>()
throws <a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Exception.html?is-external=true" title="class or interface in java.lang">Exception</a></pre>
<dl>
<dt><span class="throwsLabel">Throws:</span></dt>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-summary.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-summary.html b/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-summary.html
index 85deb89..7933909 100644
--- a/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-summary.html
+++ b/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-summary.html
@@ -1325,9 +1325,7 @@
<tr class="altColor">
<td class="colFirst"><a href="../../../../../org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html" title="class in org.apache.hadoop.hbase.regionserver">TestWALMonotonicallyIncreasingSeqId</a></td>
<td class="colLast">
-<div class="block">Test for HBASE-17471
- MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete
- path.</div>
+<div class="block">Test for HBASE-17471.</div>
</td>
</tr>
<tr class="rowColor">
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-tree.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-tree.html b/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-tree.html
index 892325d..2e07600 100644
--- a/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-tree.html
+++ b/testdevapidocs/org/apache/hadoop/hbase/regionserver/package-tree.html
@@ -628,10 +628,10 @@
<li type="circle">java.lang.<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Enum.html?is-external=true" title="class or interface in java.lang"><span class="typeNameLink">Enum</span></a><E> (implements java.lang.<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html?is-external=true" title="class or interface in java.lang">Comparable</a><T>, java.io.<a href="http://docs.oracle.com/javase/8/docs/api/java/io/Serializable.html?is-external=true" title="class or interface in java.io">Serializable</a>)
<ul>
<li type="circle">org.apache.hadoop.hbase.regionserver.<a href="../../../../../org/apache/hadoop/hbase/regionserver/TestMultiLogThreshold.ActionType.html" title="enum in org.apache.hadoop.hbase.regionserver"><span class="typeNameLink">TestMultiLogThreshold.ActionType</span></a></li>
-<li type="circle">org.apache.hadoop.hbase.regionserver.<a href="../../../../../org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.CacheOnWriteType.html" title="enum in org.apache.hadoop.hbase.regionserver"><span class="typeNameLink">TestCacheOnWriteInSchema.CacheOnWriteType</span></a></li>
<li type="circle">org.apache.hadoop.hbase.regionserver.<a href="../../../../../org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.Metric.html" title="enum in org.apache.hadoop.hbase.regionserver"><span class="typeNameLink">TestRegionServerReadRequestMetrics.Metric</span></a></li>
-<li type="circle">org.apache.hadoop.hbase.regionserver.<a href="../../../../../org/apache/hadoop/hbase/regionserver/TestAtomicOperation.TestStep.html" title="enum in org.apache.hadoop.hbase.regionserver"><span class="typeNameLink">TestAtomicOperation.TestStep</span></a></li>
<li type="circle">org.apache.hadoop.hbase.regionserver.<a href="../../../../../org/apache/hadoop/hbase/regionserver/DataBlockEncodingTool.Manipulation.html" title="enum in org.apache.hadoop.hbase.regionserver"><span class="typeNameLink">DataBlockEncodingTool.Manipulation</span></a></li>
+<li type="circle">org.apache.hadoop.hbase.regionserver.<a href="../../../../../org/apache/hadoop/hbase/regionserver/TestAtomicOperation.TestStep.html" title="enum in org.apache.hadoop.hbase.regionserver"><span class="typeNameLink">TestAtomicOperation.TestStep</span></a></li>
+<li type="circle">org.apache.hadoop.hbase.regionserver.<a href="../../../../../org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.CacheOnWriteType.html" title="enum in org.apache.hadoop.hbase.regionserver"><span class="typeNameLink">TestCacheOnWriteInSchema.CacheOnWriteType</span></a></li>
</ul>
</li>
</ul>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/org/apache/hadoop/hbase/test/package-tree.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/org/apache/hadoop/hbase/test/package-tree.html b/testdevapidocs/org/apache/hadoop/hbase/test/package-tree.html
index da70492..5103624 100644
--- a/testdevapidocs/org/apache/hadoop/hbase/test/package-tree.html
+++ b/testdevapidocs/org/apache/hadoop/hbase/test/package-tree.html
@@ -253,9 +253,9 @@
<ul>
<li type="circle">java.lang.<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Enum.html?is-external=true" title="class or interface in java.lang"><span class="typeNameLink">Enum</span></a><E> (implements java.lang.<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html?is-external=true" title="class or interface in java.lang">Comparable</a><T>, java.io.<a href="http://docs.oracle.com/javase/8/docs/api/java/io/Serializable.html?is-external=true" title="class or interface in java.io">Serializable</a>)
<ul>
-<li type="circle">org.apache.hadoop.hbase.test.<a href="../../../../../org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.Verify.Counts.html" title="enum in org.apache.hadoop.hbase.test"><span class="typeNameLink">IntegrationTestBigLinkedList.Verify.Counts</span></a></li>
-<li type="circle">org.apache.hadoop.hbase.test.<a href="../../../../../org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.Counters.html" title="enum in org.apache.hadoop.hbase.test"><span class="typeNameLink">IntegrationTestLoadAndVerify.Counters</span></a></li>
<li type="circle">org.apache.hadoop.hbase.test.<a href="../../../../../org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.Generator.Counts.html" title="enum in org.apache.hadoop.hbase.test"><span class="typeNameLink">IntegrationTestBigLinkedList.Generator.Counts</span></a></li>
+<li type="circle">org.apache.hadoop.hbase.test.<a href="../../../../../org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.Counters.html" title="enum in org.apache.hadoop.hbase.test"><span class="typeNameLink">IntegrationTestLoadAndVerify.Counters</span></a></li>
+<li type="circle">org.apache.hadoop.hbase.test.<a href="../../../../../org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.Verify.Counts.html" title="enum in org.apache.hadoop.hbase.test"><span class="typeNameLink">IntegrationTestBigLinkedList.Verify.Counts</span></a></li>
<li type="circle">org.apache.hadoop.hbase.test.<a href="../../../../../org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.Counters.html" title="enum in org.apache.hadoop.hbase.test"><span class="typeNameLink">IntegrationTestWithCellVisibilityLoadAndVerify.Counters</span></a></li>
</ul>
</li>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/org/apache/hadoop/hbase/wal/package-tree.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/org/apache/hadoop/hbase/wal/package-tree.html b/testdevapidocs/org/apache/hadoop/hbase/wal/package-tree.html
index f65a9c9..644d9f7 100644
--- a/testdevapidocs/org/apache/hadoop/hbase/wal/package-tree.html
+++ b/testdevapidocs/org/apache/hadoop/hbase/wal/package-tree.html
@@ -136,9 +136,9 @@
<ul>
<li type="circle">java.lang.<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Enum.html?is-external=true" title="class or interface in java.lang"><span class="typeNameLink">Enum</span></a><E> (implements java.lang.<a href="http://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html?is-external=true" title="class or interface in java.lang">Comparable</a><T>, java.io.<a href="http://docs.oracle.com/javase/8/docs/api/java/io/Serializable.html?is-external=true" title="class or interface in java.io">Serializable</a>)
<ul>
-<li type="circle">org.apache.hadoop.hbase.wal.<a href="../../../../../org/apache/hadoop/hbase/wal/TestWALSplit.Corruptions.html" title="enum in org.apache.hadoop.hbase.wal"><span class="typeNameLink">TestWALSplit.Corruptions</span></a></li>
<li type="circle">org.apache.hadoop.hbase.wal.<a href="../../../../../org/apache/hadoop/hbase/wal/FaultyFSLog.FailureType.html" title="enum in org.apache.hadoop.hbase.wal"><span class="typeNameLink">FaultyFSLog.FailureType</span></a></li>
<li type="circle">org.apache.hadoop.hbase.wal.<a href="../../../../../org/apache/hadoop/hbase/wal/IOTestProvider.AllowedOperations.html" title="enum in org.apache.hadoop.hbase.wal"><span class="typeNameLink">IOTestProvider.AllowedOperations</span></a></li>
+<li type="circle">org.apache.hadoop.hbase.wal.<a href="../../../../../org/apache/hadoop/hbase/wal/TestWALSplit.Corruptions.html" title="enum in org.apache.hadoop.hbase.wal"><span class="typeNameLink">TestWALSplit.Corruptions</span></a></li>
</ul>
</li>
</ul>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.IncThread.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.IncThread.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.IncThread.html
index 06992c4..f5e1b5f 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.IncThread.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.IncThread.html
@@ -26,199 +26,226 @@
<span class="sourceLineNo">018</span> */<a name="line.18"></a>
<span class="sourceLineNo">019</span>package org.apache.hadoop.hbase.regionserver;<a name="line.19"></a>
<span class="sourceLineNo">020</span><a name="line.20"></a>
-<span class="sourceLineNo">021</span>import org.apache.commons.logging.Log;<a name="line.21"></a>
-<span class="sourceLineNo">022</span>import org.apache.commons.logging.LogFactory;<a name="line.22"></a>
-<span class="sourceLineNo">023</span>import org.apache.hadoop.conf.Configuration;<a name="line.23"></a>
-<span class="sourceLineNo">024</span>import org.apache.hadoop.fs.FileSystem;<a name="line.24"></a>
-<span class="sourceLineNo">025</span>import org.apache.hadoop.fs.Path;<a name="line.25"></a>
-<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.*;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.client.*;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.regionserver.wal.FSHLog;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.wal.WALFactory;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.junit.Assert;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.junit.Rule;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.junit.Test;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.junit.experimental.categories.Category;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.junit.rules.TestName;<a name="line.40"></a>
-<span class="sourceLineNo">041</span><a name="line.41"></a>
-<span class="sourceLineNo">042</span>import java.io.IOException;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import java.util.ArrayList;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import java.util.List;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import java.util.concurrent.CountDownLatch;<a name="line.45"></a>
-<span class="sourceLineNo">046</span><a name="line.46"></a>
-<span class="sourceLineNo">047</span>/**<a name="line.47"></a>
-<span class="sourceLineNo">048</span> * Test for HBASE-17471<a name="line.48"></a>
-<span class="sourceLineNo">049</span> * MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete<a name="line.49"></a>
-<span class="sourceLineNo">050</span> * path. Other write paths like increment/append still assign mvcc in ringbuffer's consumer<a name="line.50"></a>
-<span class="sourceLineNo">051</span> * thread. If put and increment are used parallel. Then seqid in WAL may not increase monotonically<a name="line.51"></a>
-<span class="sourceLineNo">052</span> * Disorder in wals will lead to data loss.<a name="line.52"></a>
-<span class="sourceLineNo">053</span> * This case use two thread to put and increment at the same time in a single region.<a name="line.53"></a>
-<span class="sourceLineNo">054</span> * Then check the seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail<a name="line.54"></a>
-<span class="sourceLineNo">055</span> *<a name="line.55"></a>
-<span class="sourceLineNo">056</span> */<a name="line.56"></a>
-<span class="sourceLineNo">057</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.57"></a>
-<span class="sourceLineNo">058</span>public class TestWALMonotonicallyIncreasingSeqId {<a name="line.58"></a>
-<span class="sourceLineNo">059</span> final Log LOG = LogFactory.getLog(getClass());<a name="line.59"></a>
-<span class="sourceLineNo">060</span> private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.60"></a>
-<span class="sourceLineNo">061</span> private static Path testDir = TEST_UTIL.getDataTestDir("TestWALMonotonicallyIncreasingSeqId");<a name="line.61"></a>
-<span class="sourceLineNo">062</span> private WALFactory wals;<a name="line.62"></a>
-<span class="sourceLineNo">063</span> private FileSystem fileSystem;<a name="line.63"></a>
-<span class="sourceLineNo">064</span> private Configuration walConf;<a name="line.64"></a>
-<span class="sourceLineNo">065</span><a name="line.65"></a>
-<span class="sourceLineNo">066</span> public static final String KEY_SEED = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";<a name="line.66"></a>
-<span class="sourceLineNo">067</span><a name="line.67"></a>
-<span class="sourceLineNo">068</span> private static final int KEY_SEED_LEN = KEY_SEED.length();<a name="line.68"></a>
-<span class="sourceLineNo">069</span><a name="line.69"></a>
-<span class="sourceLineNo">070</span> private static final char[] KEY_SEED_CHARS = KEY_SEED.toCharArray();<a name="line.70"></a>
-<span class="sourceLineNo">071</span><a name="line.71"></a>
-<span class="sourceLineNo">072</span> @Rule<a name="line.72"></a>
-<span class="sourceLineNo">073</span> public TestName name = new TestName();<a name="line.73"></a>
-<span class="sourceLineNo">074</span><a name="line.74"></a>
-<span class="sourceLineNo">075</span> private HTableDescriptor getTableDesc(TableName tableName, byte[]... families) {<a name="line.75"></a>
-<span class="sourceLineNo">076</span> HTableDescriptor htd = new HTableDescriptor(tableName);<a name="line.76"></a>
-<span class="sourceLineNo">077</span> for (byte[] family : families) {<a name="line.77"></a>
-<span class="sourceLineNo">078</span> HColumnDescriptor hcd = new HColumnDescriptor(family);<a name="line.78"></a>
-<span class="sourceLineNo">079</span> // Set default to be three versions.<a name="line.79"></a>
-<span class="sourceLineNo">080</span> hcd.setMaxVersions(Integer.MAX_VALUE);<a name="line.80"></a>
-<span class="sourceLineNo">081</span> htd.addFamily(hcd);<a name="line.81"></a>
-<span class="sourceLineNo">082</span> }<a name="line.82"></a>
-<span class="sourceLineNo">083</span> return htd;<a name="line.83"></a>
-<span class="sourceLineNo">084</span> }<a name="line.84"></a>
-<span class="sourceLineNo">085</span><a name="line.85"></a>
-<span class="sourceLineNo">086</span> private Region initHRegion(HTableDescriptor htd, byte[] startKey, byte[] stopKey, int replicaId)<a name="line.86"></a>
-<span class="sourceLineNo">087</span> throws IOException {<a name="line.87"></a>
-<span class="sourceLineNo">088</span> Configuration conf = TEST_UTIL.getConfiguration();<a name="line.88"></a>
-<span class="sourceLineNo">089</span> conf.setBoolean("hbase.hregion.mvcc.preassign", false);<a name="line.89"></a>
-<span class="sourceLineNo">090</span> Path tableDir = FSUtils.getTableDir(testDir, htd.getTableName());<a name="line.90"></a>
-<span class="sourceLineNo">091</span><a name="line.91"></a>
-<span class="sourceLineNo">092</span> HRegionInfo info = new HRegionInfo(htd.getTableName(), startKey, stopKey, false, 0, replicaId);<a name="line.92"></a>
-<span class="sourceLineNo">093</span> fileSystem = tableDir.getFileSystem(conf);<a name="line.93"></a>
-<span class="sourceLineNo">094</span> HRegionFileSystem fs = new HRegionFileSystem(conf, fileSystem, tableDir, info);<a name="line.94"></a>
-<span class="sourceLineNo">095</span> final Configuration walConf = new Configuration(conf);<a name="line.95"></a>
-<span class="sourceLineNo">096</span> FSUtils.setRootDir(walConf, tableDir);<a name="line.96"></a>
-<span class="sourceLineNo">097</span> this.walConf = walConf;<a name="line.97"></a>
-<span class="sourceLineNo">098</span> wals = new WALFactory(walConf, null, "log_" + replicaId);<a name="line.98"></a>
-<span class="sourceLineNo">099</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.99"></a>
-<span class="sourceLineNo">100</span> HRegion region = HRegion.createHRegion(info, TEST_UTIL.getDefaultRootDirPath(), conf, htd,<a name="line.100"></a>
-<span class="sourceLineNo">101</span> wals.getWAL(info.getEncodedNameAsBytes(), info.getTable().getNamespace()));<a name="line.101"></a>
-<span class="sourceLineNo">102</span> return region;<a name="line.102"></a>
-<span class="sourceLineNo">103</span> }<a name="line.103"></a>
-<span class="sourceLineNo">104</span><a name="line.104"></a>
-<span class="sourceLineNo">105</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.105"></a>
-<span class="sourceLineNo">106</span> public class PutThread extends Thread {<a name="line.106"></a>
-<span class="sourceLineNo">107</span> HRegion region;<a name="line.107"></a>
-<span class="sourceLineNo">108</span> public PutThread(HRegion region) {<a name="line.108"></a>
-<span class="sourceLineNo">109</span> this.region = region;<a name="line.109"></a>
-<span class="sourceLineNo">110</span> }<a name="line.110"></a>
-<span class="sourceLineNo">111</span><a name="line.111"></a>
-<span class="sourceLineNo">112</span> @Override<a name="line.112"></a>
-<span class="sourceLineNo">113</span> public void run() {<a name="line.113"></a>
-<span class="sourceLineNo">114</span> try {<a name="line.114"></a>
-<span class="sourceLineNo">115</span> for(int i = 0; i < 100; i++) {<a name="line.115"></a>
-<span class="sourceLineNo">116</span> byte[] row = Bytes.toBytes("putRow" + i);<a name="line.116"></a>
-<span class="sourceLineNo">117</span> Put put = new Put(row);<a name="line.117"></a>
-<span class="sourceLineNo">118</span> put.addColumn("cf".getBytes(), Bytes.toBytes(0), Bytes.toBytes(""));<a name="line.118"></a>
-<span class="sourceLineNo">119</span> //put.setDurability(Durability.ASYNC_WAL);<a name="line.119"></a>
-<span class="sourceLineNo">120</span> latch.await();<a name="line.120"></a>
-<span class="sourceLineNo">121</span> region.batchMutate(new Mutation[]{put});<a name="line.121"></a>
-<span class="sourceLineNo">122</span> Thread.sleep(10);<a name="line.122"></a>
-<span class="sourceLineNo">123</span> }<a name="line.123"></a>
-<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">021</span>import static org.junit.Assert.fail;<a name="line.21"></a>
+<span class="sourceLineNo">022</span><a name="line.22"></a>
+<span class="sourceLineNo">023</span>import java.io.IOException;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import java.util.ArrayList;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import java.util.Arrays;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import java.util.List;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import java.util.concurrent.CountDownLatch;<a name="line.27"></a>
+<span class="sourceLineNo">028</span><a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.commons.logging.Log;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.commons.logging.LogFactory;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.conf.Configuration;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.FileSystem;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.fs.Path;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.HConstants;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.TableName;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.client.Increment;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.client.Mutation;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.client.Put;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.client.RegionInfoBuilder;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.client.TableDescriptorBuilder;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.wal.WALFactory;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.junit.After;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.junit.AfterClass;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.junit.Before;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.junit.Rule;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.junit.Test;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.junit.experimental.categories.Category;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.junit.rules.TestName;<a name="line.59"></a>
+<span class="sourceLineNo">060</span>import org.junit.runner.RunWith;<a name="line.60"></a>
+<span class="sourceLineNo">061</span>import org.junit.runners.Parameterized;<a name="line.61"></a>
+<span class="sourceLineNo">062</span>import org.junit.runners.Parameterized.Parameter;<a name="line.62"></a>
+<span class="sourceLineNo">063</span>import org.junit.runners.Parameterized.Parameters;<a name="line.63"></a>
+<span class="sourceLineNo">064</span><a name="line.64"></a>
+<span class="sourceLineNo">065</span>/**<a name="line.65"></a>
+<span class="sourceLineNo">066</span> * Test for HBASE-17471.<a name="line.66"></a>
+<span class="sourceLineNo">067</span> * <p><a name="line.67"></a>
+<span class="sourceLineNo">068</span> * MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete path. Other<a name="line.68"></a>
+<span class="sourceLineNo">069</span> * write paths like increment/append still assign mvcc in ringbuffer's consumer thread. If put and<a name="line.69"></a>
+<span class="sourceLineNo">070</span> * increment are used parallel. Then seqid in WAL may not increase monotonically Disorder in wals<a name="line.70"></a>
+<span class="sourceLineNo">071</span> * will lead to data loss.<a name="line.71"></a>
+<span class="sourceLineNo">072</span> * <p><a name="line.72"></a>
+<span class="sourceLineNo">073</span> * This case use two thread to put and increment at the same time in a single region. Then check the<a name="line.73"></a>
+<span class="sourceLineNo">074</span> * seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail<a name="line.74"></a>
+<span class="sourceLineNo">075</span> */<a name="line.75"></a>
+<span class="sourceLineNo">076</span>@RunWith(Parameterized.class)<a name="line.76"></a>
+<span class="sourceLineNo">077</span>@Category({ RegionServerTests.class, SmallTests.class })<a name="line.77"></a>
+<span class="sourceLineNo">078</span>public class TestWALMonotonicallyIncreasingSeqId {<a name="line.78"></a>
+<span class="sourceLineNo">079</span> private final Log LOG = LogFactory.getLog(getClass());<a name="line.79"></a>
+<span class="sourceLineNo">080</span> private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.80"></a>
+<span class="sourceLineNo">081</span> private static Path testDir = TEST_UTIL.getDataTestDir("TestWALMonotonicallyIncreasingSeqId");<a name="line.81"></a>
+<span class="sourceLineNo">082</span> private WALFactory wals;<a name="line.82"></a>
+<span class="sourceLineNo">083</span> private FileSystem fileSystem;<a name="line.83"></a>
+<span class="sourceLineNo">084</span> private Configuration walConf;<a name="line.84"></a>
+<span class="sourceLineNo">085</span> private HRegion region;<a name="line.85"></a>
+<span class="sourceLineNo">086</span><a name="line.86"></a>
+<span class="sourceLineNo">087</span> @Parameter<a name="line.87"></a>
+<span class="sourceLineNo">088</span> public String walProvider;<a name="line.88"></a>
+<span class="sourceLineNo">089</span><a name="line.89"></a>
+<span class="sourceLineNo">090</span> @Rule<a name="line.90"></a>
+<span class="sourceLineNo">091</span> public TestName name = new TestName();<a name="line.91"></a>
+<span class="sourceLineNo">092</span><a name="line.92"></a>
+<span class="sourceLineNo">093</span> @Parameters(name = "{index}: wal={0}")<a name="line.93"></a>
+<span class="sourceLineNo">094</span> public static List<Object[]> data() {<a name="line.94"></a>
+<span class="sourceLineNo">095</span> return Arrays.asList(new Object[] { "asyncfs" }, new Object[] { "filesystem" });<a name="line.95"></a>
+<span class="sourceLineNo">096</span> }<a name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span> private TableDescriptor getTableDesc(TableName tableName, byte[]... families) {<a name="line.98"></a>
+<span class="sourceLineNo">099</span> TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(tableName);<a name="line.99"></a>
+<span class="sourceLineNo">100</span> Arrays.stream(families).map(<a name="line.100"></a>
+<span class="sourceLineNo">101</span> f -> ColumnFamilyDescriptorBuilder.newBuilder(f).setMaxVersions(Integer.MAX_VALUE).build())<a name="line.101"></a>
+<span class="sourceLineNo">102</span> .forEachOrdered(builder::addColumnFamily);<a name="line.102"></a>
+<span class="sourceLineNo">103</span> return builder.build();<a name="line.103"></a>
+<span class="sourceLineNo">104</span> }<a name="line.104"></a>
+<span class="sourceLineNo">105</span><a name="line.105"></a>
+<span class="sourceLineNo">106</span> private HRegion initHRegion(TableDescriptor htd, byte[] startKey, byte[] stopKey, int replicaId)<a name="line.106"></a>
+<span class="sourceLineNo">107</span> throws IOException {<a name="line.107"></a>
+<span class="sourceLineNo">108</span> Configuration conf = TEST_UTIL.getConfiguration();<a name="line.108"></a>
+<span class="sourceLineNo">109</span> conf.set("hbase.wal.provider", walProvider);<a name="line.109"></a>
+<span class="sourceLineNo">110</span> conf.setBoolean("hbase.hregion.mvcc.preassign", false);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> Path tableDir = FSUtils.getTableDir(testDir, htd.getTableName());<a name="line.111"></a>
+<span class="sourceLineNo">112</span><a name="line.112"></a>
+<span class="sourceLineNo">113</span> RegionInfo info = RegionInfoBuilder.newBuilder(htd.getTableName()).setStartKey(startKey)<a name="line.113"></a>
+<span class="sourceLineNo">114</span> .setEndKey(stopKey).setReplicaId(replicaId).setRegionId(0).build();<a name="line.114"></a>
+<span class="sourceLineNo">115</span> fileSystem = tableDir.getFileSystem(conf);<a name="line.115"></a>
+<span class="sourceLineNo">116</span> final Configuration walConf = new Configuration(conf);<a name="line.116"></a>
+<span class="sourceLineNo">117</span> FSUtils.setRootDir(walConf, tableDir);<a name="line.117"></a>
+<span class="sourceLineNo">118</span> this.walConf = walConf;<a name="line.118"></a>
+<span class="sourceLineNo">119</span> wals = new WALFactory(walConf, null, "log_" + replicaId);<a name="line.119"></a>
+<span class="sourceLineNo">120</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.120"></a>
+<span class="sourceLineNo">121</span> HRegion region = HRegion.createHRegion(info, TEST_UTIL.getDefaultRootDirPath(), conf, htd,<a name="line.121"></a>
+<span class="sourceLineNo">122</span> wals.getWAL(info.getEncodedNameAsBytes(), info.getTable().getNamespace()));<a name="line.122"></a>
+<span class="sourceLineNo">123</span> return region;<a name="line.123"></a>
+<span class="sourceLineNo">124</span> }<a name="line.124"></a>
<span class="sourceLineNo">125</span><a name="line.125"></a>
-<span class="sourceLineNo">126</span> } catch (Throwable t) {<a name="line.126"></a>
-<span class="sourceLineNo">127</span> LOG.warn("Error happend when Increment: ", t);<a name="line.127"></a>
-<span class="sourceLineNo">128</span> }<a name="line.128"></a>
-<span class="sourceLineNo">129</span><a name="line.129"></a>
-<span class="sourceLineNo">130</span> }<a name="line.130"></a>
-<span class="sourceLineNo">131</span> }<a name="line.131"></a>
-<span class="sourceLineNo">132</span><a name="line.132"></a>
-<span class="sourceLineNo">133</span> public class IncThread extends Thread {<a name="line.133"></a>
-<span class="sourceLineNo">134</span> HRegion region;<a name="line.134"></a>
-<span class="sourceLineNo">135</span> public IncThread(HRegion region) {<a name="line.135"></a>
-<span class="sourceLineNo">136</span> this.region = region;<a name="line.136"></a>
-<span class="sourceLineNo">137</span> }<a name="line.137"></a>
-<span class="sourceLineNo">138</span> @Override<a name="line.138"></a>
-<span class="sourceLineNo">139</span> public void run() {<a name="line.139"></a>
-<span class="sourceLineNo">140</span> try {<a name="line.140"></a>
-<span class="sourceLineNo">141</span> for(int i = 0; i < 100; i++) {<a name="line.141"></a>
-<span class="sourceLineNo">142</span> byte[] row = Bytes.toBytes("incrementRow" + i);<a name="line.142"></a>
-<span class="sourceLineNo">143</span> Increment inc = new Increment(row);<a name="line.143"></a>
-<span class="sourceLineNo">144</span> inc.addColumn("cf".getBytes(), Bytes.toBytes(0), 1);<a name="line.144"></a>
-<span class="sourceLineNo">145</span> //inc.setDurability(Durability.ASYNC_WAL);<a name="line.145"></a>
-<span class="sourceLineNo">146</span> region.increment(inc);<a name="line.146"></a>
-<span class="sourceLineNo">147</span> latch.countDown();<a name="line.147"></a>
-<span class="sourceLineNo">148</span> Thread.sleep(10);<a name="line.148"></a>
-<span class="sourceLineNo">149</span> }<a name="line.149"></a>
-<span class="sourceLineNo">150</span><a name="line.150"></a>
-<span class="sourceLineNo">151</span><a name="line.151"></a>
-<span class="sourceLineNo">152</span> } catch (Throwable t) {<a name="line.152"></a>
-<span class="sourceLineNo">153</span> LOG.warn("Error happend when Put: ", t);<a name="line.153"></a>
-<span class="sourceLineNo">154</span> }<a name="line.154"></a>
+<span class="sourceLineNo">126</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.126"></a>
+<span class="sourceLineNo">127</span><a name="line.127"></a>
+<span class="sourceLineNo">128</span> public class PutThread extends Thread {<a name="line.128"></a>
+<span class="sourceLineNo">129</span> HRegion region;<a name="line.129"></a>
+<span class="sourceLineNo">130</span><a name="line.130"></a>
+<span class="sourceLineNo">131</span> public PutThread(HRegion region) {<a name="line.131"></a>
+<span class="sourceLineNo">132</span> this.region = region;<a name="line.132"></a>
+<span class="sourceLineNo">133</span> }<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span> @Override<a name="line.135"></a>
+<span class="sourceLineNo">136</span> public void run() {<a name="line.136"></a>
+<span class="sourceLineNo">137</span> try {<a name="line.137"></a>
+<span class="sourceLineNo">138</span> for (int i = 0; i < 100; i++) {<a name="line.138"></a>
+<span class="sourceLineNo">139</span> byte[] row = Bytes.toBytes("putRow" + i);<a name="line.139"></a>
+<span class="sourceLineNo">140</span> Put put = new Put(row);<a name="line.140"></a>
+<span class="sourceLineNo">141</span> put.addColumn("cf".getBytes(), Bytes.toBytes(0), Bytes.toBytes(""));<a name="line.141"></a>
+<span class="sourceLineNo">142</span> latch.await();<a name="line.142"></a>
+<span class="sourceLineNo">143</span> region.batchMutate(new Mutation[] { put });<a name="line.143"></a>
+<span class="sourceLineNo">144</span> Thread.sleep(10);<a name="line.144"></a>
+<span class="sourceLineNo">145</span> }<a name="line.145"></a>
+<span class="sourceLineNo">146</span><a name="line.146"></a>
+<span class="sourceLineNo">147</span> } catch (Throwable t) {<a name="line.147"></a>
+<span class="sourceLineNo">148</span> LOG.warn("Error happend when Increment: ", t);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> }<a name="line.149"></a>
+<span class="sourceLineNo">150</span> }<a name="line.150"></a>
+<span class="sourceLineNo">151</span> }<a name="line.151"></a>
+<span class="sourceLineNo">152</span><a name="line.152"></a>
+<span class="sourceLineNo">153</span> public class IncThread extends Thread {<a name="line.153"></a>
+<span class="sourceLineNo">154</span> HRegion region;<a name="line.154"></a>
<span class="sourceLineNo">155</span><a name="line.155"></a>
-<span class="sourceLineNo">156</span> }<a name="line.156"></a>
-<span class="sourceLineNo">157</span> }<a name="line.157"></a>
-<span class="sourceLineNo">158</span><a name="line.158"></a>
-<span class="sourceLineNo">159</span> @Test<a name="line.159"></a>
-<span class="sourceLineNo">160</span> public void TestWALMonotonicallyIncreasingSeqId() throws Exception {<a name="line.160"></a>
-<span class="sourceLineNo">161</span> byte[][] families = new byte[][] {Bytes.toBytes("cf")};<a name="line.161"></a>
-<span class="sourceLineNo">162</span> byte[] qf = Bytes.toBytes("cq");<a name="line.162"></a>
-<span class="sourceLineNo">163</span> HTableDescriptor htd = getTableDesc(TableName.valueOf(name.getMethodName()), families);<a name="line.163"></a>
-<span class="sourceLineNo">164</span> HRegion region = (HRegion)initHRegion(htd, HConstants.EMPTY_START_ROW, HConstants.EMPTY_END_ROW, 0);<a name="line.164"></a>
-<span class="sourceLineNo">165</span> List<Thread> putThreads = new ArrayList<>();<a name="line.165"></a>
-<span class="sourceLineNo">166</span> for(int i = 0; i < 1; i++) {<a name="line.166"></a>
-<span class="sourceLineNo">167</span> putThreads.add(new PutThread(region));<a name="line.167"></a>
-<span class="sourceLineNo">168</span> }<a name="line.168"></a>
-<span class="sourceLineNo">169</span> IncThread incThread = new IncThread(region);<a name="line.169"></a>
-<span class="sourceLineNo">170</span> for(int i = 0; i < 1; i++) {<a name="line.170"></a>
-<span class="sourceLineNo">171</span> putThreads.get(i).start();<a name="line.171"></a>
-<span class="sourceLineNo">172</span> }<a name="line.172"></a>
-<span class="sourceLineNo">173</span> incThread.start();<a name="line.173"></a>
-<span class="sourceLineNo">174</span> incThread.join();<a name="line.174"></a>
-<span class="sourceLineNo">175</span><a name="line.175"></a>
-<span class="sourceLineNo">176</span> Path logPath = ((FSHLog) region.getWAL()).getCurrentFileName();<a name="line.176"></a>
-<span class="sourceLineNo">177</span> region.getWAL().rollWriter();<a name="line.177"></a>
-<span class="sourceLineNo">178</span> Thread.sleep(10);<a name="line.178"></a>
-<span class="sourceLineNo">179</span> Path hbaseDir = new Path(walConf.get(HConstants.HBASE_DIR));<a name="line.179"></a>
-<span class="sourceLineNo">180</span> Path oldWalsDir = new Path(hbaseDir, HConstants.HREGION_OLDLOGDIR_NAME);<a name="line.180"></a>
-<span class="sourceLineNo">181</span> WAL.Reader reader = null;<a name="line.181"></a>
-<span class="sourceLineNo">182</span> try {<a name="line.182"></a>
-<span class="sourceLineNo">183</span> reader = wals.createReader(fileSystem, logPath);<a name="line.183"></a>
-<span class="sourceLineNo">184</span> } catch (Throwable t) {<a name="line.184"></a>
-<span class="sourceLineNo">185</span> reader = wals.createReader(fileSystem, new Path(oldWalsDir, logPath.getName()));<a name="line.185"></a>
+<span class="sourceLineNo">156</span> public IncThread(HRegion region) {<a name="line.156"></a>
+<span class="sourceLineNo">157</span> this.region = region;<a name="line.157"></a>
+<span class="sourceLineNo">158</span> }<a name="line.158"></a>
+<span class="sourceLineNo">159</span><a name="line.159"></a>
+<span class="sourceLineNo">160</span> @Override<a name="line.160"></a>
+<span class="sourceLineNo">161</span> public void run() {<a name="line.161"></a>
+<span class="sourceLineNo">162</span> try {<a name="line.162"></a>
+<span class="sourceLineNo">163</span> for (int i = 0; i < 100; i++) {<a name="line.163"></a>
+<span class="sourceLineNo">164</span> byte[] row = Bytes.toBytes("incrementRow" + i);<a name="line.164"></a>
+<span class="sourceLineNo">165</span> Increment inc = new Increment(row);<a name="line.165"></a>
+<span class="sourceLineNo">166</span> inc.addColumn("cf".getBytes(), Bytes.toBytes(0), 1);<a name="line.166"></a>
+<span class="sourceLineNo">167</span> // inc.setDurability(Durability.ASYNC_WAL);<a name="line.167"></a>
+<span class="sourceLineNo">168</span> region.increment(inc);<a name="line.168"></a>
+<span class="sourceLineNo">169</span> latch.countDown();<a name="line.169"></a>
+<span class="sourceLineNo">170</span> Thread.sleep(10);<a name="line.170"></a>
+<span class="sourceLineNo">171</span> }<a name="line.171"></a>
+<span class="sourceLineNo">172</span><a name="line.172"></a>
+<span class="sourceLineNo">173</span> } catch (Throwable t) {<a name="line.173"></a>
+<span class="sourceLineNo">174</span> LOG.warn("Error happend when Put: ", t);<a name="line.174"></a>
+<span class="sourceLineNo">175</span> }<a name="line.175"></a>
+<span class="sourceLineNo">176</span> }<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span><a name="line.178"></a>
+<span class="sourceLineNo">179</span> @Before<a name="line.179"></a>
+<span class="sourceLineNo">180</span> public void setUp() throws IOException {<a name="line.180"></a>
+<span class="sourceLineNo">181</span> byte[][] families = new byte[][] { Bytes.toBytes("cf") };<a name="line.181"></a>
+<span class="sourceLineNo">182</span> TableDescriptor htd = getTableDesc(<a name="line.182"></a>
+<span class="sourceLineNo">183</span> TableName.valueOf(name.getMethodName().replaceAll("[^0-9A-Za-z_]", "_")), families);<a name="line.183"></a>
+<span class="sourceLineNo">184</span> region = initHRegion(htd, HConstants.EMPTY_START_ROW, HConstants.EMPTY_END_ROW, 0);<a name="line.184"></a>
+<span class="sourceLineNo">185</span> }<a name="line.185"></a>
<span class="sourceLineNo">186</span><a name="line.186"></a>
-<span class="sourceLineNo">187</span> }<a name="line.187"></a>
-<span class="sourceLineNo">188</span> WAL.Entry e;<a name="line.188"></a>
-<span class="sourceLineNo">189</span> try {<a name="line.189"></a>
-<span class="sourceLineNo">190</span> long currentMaxSeqid = 0;<a name="line.190"></a>
-<span class="sourceLineNo">191</span> while ((e = reader.next()) != null) {<a name="line.191"></a>
-<span class="sourceLineNo">192</span> if (!WALEdit.isMetaEditFamily(e.getEdit().getCells().get(0))) {<a name="line.192"></a>
-<span class="sourceLineNo">193</span> long currentSeqid = e.getKey().getSequenceId();<a name="line.193"></a>
-<span class="sourceLineNo">194</span> if(currentSeqid > currentMaxSeqid) {<a name="line.194"></a>
-<span class="sourceLineNo">195</span> currentMaxSeqid = currentSeqid;<a name="line.195"></a>
-<span class="sourceLineNo">196</span> } else {<a name="line.196"></a>
-<span class="sourceLineNo">197</span> Assert.fail("Current max Seqid is " + currentMaxSeqid<a name="line.197"></a>
-<span class="sourceLineNo">198</span> + ", but the next seqid in wal is smaller:" + currentSeqid);<a name="line.198"></a>
-<span class="sourceLineNo">199</span> }<a name="line.199"></a>
-<span class="sourceLineNo">200</span> }<a name="line.200"></a>
-<span class="sourceLineNo">201</span> }<a name="line.201"></a>
-<span class="sourceLineNo">202</span> } finally {<a name="line.202"></a>
-<span class="sourceLineNo">203</span> if(reader != null) {<a name="line.203"></a>
-<span class="sourceLineNo">204</span> reader.close();<a name="line.204"></a>
-<span class="sourceLineNo">205</span> }<a name="line.205"></a>
-<span class="sourceLineNo">206</span> if(region != null) {<a name="line.206"></a>
-<span class="sourceLineNo">207</span> region.close();<a name="line.207"></a>
-<span class="sourceLineNo">208</span> }<a name="line.208"></a>
-<span class="sourceLineNo">209</span> }<a name="line.209"></a>
-<span class="sourceLineNo">210</span> }<a name="line.210"></a>
-<span class="sourceLineNo">211</span><a name="line.211"></a>
-<span class="sourceLineNo">212</span><a name="line.212"></a>
-<span class="sourceLineNo">213</span>}<a name="line.213"></a>
+<span class="sourceLineNo">187</span> @After<a name="line.187"></a>
+<span class="sourceLineNo">188</span> public void tearDown() throws IOException {<a name="line.188"></a>
+<span class="sourceLineNo">189</span> if (region != null) {<a name="line.189"></a>
+<span class="sourceLineNo">190</span> region.close();<a name="line.190"></a>
+<span class="sourceLineNo">191</span> }<a name="line.191"></a>
+<span class="sourceLineNo">192</span> }<a name="line.192"></a>
+<span class="sourceLineNo">193</span><a name="line.193"></a>
+<span class="sourceLineNo">194</span> @AfterClass<a name="line.194"></a>
+<span class="sourceLineNo">195</span> public static void tearDownAfterClass() throws IOException {<a name="line.195"></a>
+<span class="sourceLineNo">196</span> TEST_UTIL.cleanupTestDir();<a name="line.196"></a>
+<span class="sourceLineNo">197</span> }<a name="line.197"></a>
+<span class="sourceLineNo">198</span><a name="line.198"></a>
+<span class="sourceLineNo">199</span> private WAL.Reader createReader(Path logPath, Path oldWalsDir) throws IOException {<a name="line.199"></a>
+<span class="sourceLineNo">200</span> try {<a name="line.200"></a>
+<span class="sourceLineNo">201</span> return wals.createReader(fileSystem, logPath);<a name="line.201"></a>
+<span class="sourceLineNo">202</span> } catch (IOException e) {<a name="line.202"></a>
+<span class="sourceLineNo">203</span> return wals.createReader(fileSystem, new Path(oldWalsDir, logPath.getName()));<a name="line.203"></a>
+<span class="sourceLineNo">204</span> }<a name="line.204"></a>
+<span class="sourceLineNo">205</span> }<a name="line.205"></a>
+<span class="sourceLineNo">206</span><a name="line.206"></a>
+<span class="sourceLineNo">207</span> @Test<a name="line.207"></a>
+<span class="sourceLineNo">208</span> public void testWALMonotonicallyIncreasingSeqId() throws Exception {<a name="line.208"></a>
+<span class="sourceLineNo">209</span> List<Thread> putThreads = new ArrayList<>();<a name="line.209"></a>
+<span class="sourceLineNo">210</span> for (int i = 0; i < 1; i++) {<a name="line.210"></a>
+<span class="sourceLineNo">211</span> putThreads.add(new PutThread(region));<a name="line.211"></a>
+<span class="sourceLineNo">212</span> }<a name="line.212"></a>
+<span class="sourceLineNo">213</span> IncThread incThread = new IncThread(region);<a name="line.213"></a>
+<span class="sourceLineNo">214</span> for (int i = 0; i < 1; i++) {<a name="line.214"></a>
+<span class="sourceLineNo">215</span> putThreads.get(i).start();<a name="line.215"></a>
+<span class="sourceLineNo">216</span> }<a name="line.216"></a>
+<span class="sourceLineNo">217</span> incThread.start();<a name="line.217"></a>
+<span class="sourceLineNo">218</span> incThread.join();<a name="line.218"></a>
+<span class="sourceLineNo">219</span><a name="line.219"></a>
+<span class="sourceLineNo">220</span> Path logPath = ((AbstractFSWAL<?>) region.getWAL()).getCurrentFileName();<a name="line.220"></a>
+<span class="sourceLineNo">221</span> region.getWAL().rollWriter();<a name="line.221"></a>
+<span class="sourceLineNo">222</span> Thread.sleep(10);<a name="line.222"></a>
+<span class="sourceLineNo">223</span> Path hbaseDir = new Path(walConf.get(HConstants.HBASE_DIR));<a name="line.223"></a>
+<span class="sourceLineNo">224</span> Path oldWalsDir = new Path(hbaseDir, HConstants.HREGION_OLDLOGDIR_NAME);<a name="line.224"></a>
+<span class="sourceLineNo">225</span> try (WAL.Reader reader = createReader(logPath, oldWalsDir)) {<a name="line.225"></a>
+<span class="sourceLineNo">226</span> long currentMaxSeqid = 0;<a name="line.226"></a>
+<span class="sourceLineNo">227</span> for (WAL.Entry e; (e = reader.next()) != null;) {<a name="line.227"></a>
+<span class="sourceLineNo">228</span> if (!WALEdit.isMetaEditFamily(e.getEdit().getCells().get(0))) {<a name="line.228"></a>
+<span class="sourceLineNo">229</span> long currentSeqid = e.getKey().getSequenceId();<a name="line.229"></a>
+<span class="sourceLineNo">230</span> if (currentSeqid > currentMaxSeqid) {<a name="line.230"></a>
+<span class="sourceLineNo">231</span> currentMaxSeqid = currentSeqid;<a name="line.231"></a>
+<span class="sourceLineNo">232</span> } else {<a name="line.232"></a>
+<span class="sourceLineNo">233</span> fail("Current max Seqid is " + currentMaxSeqid +<a name="line.233"></a>
+<span class="sourceLineNo">234</span> ", but the next seqid in wal is smaller:" + currentSeqid);<a name="line.234"></a>
+<span class="sourceLineNo">235</span> }<a name="line.235"></a>
+<span class="sourceLineNo">236</span> }<a name="line.236"></a>
+<span class="sourceLineNo">237</span> }<a name="line.237"></a>
+<span class="sourceLineNo">238</span> }<a name="line.238"></a>
+<span class="sourceLineNo">239</span> }<a name="line.239"></a>
+<span class="sourceLineNo">240</span>}<a name="line.240"></a>