You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/05/15 18:51:30 UTC
Review Request 34279: ConfigureTask For Upgrades Must Support Type
Coercion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34279/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-11177
https://issues.apache.org/jira/browse/AMBARI-11177
Repository: ambari
Description
-------
The ConfigureTask must be able to support type coercion when copying values between stacks. This will enable data transformation during an upgrade. In particular, this solves the issue of a configuration type being changed between stack versions.
<transfer operation="copy" from-key="nimbus.host" to-key="nimbus.seeds" coerce-to="yaml-array" />
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 645c4bb
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 2b68a28
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferCoercionType.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferOperation.java 1ee2a35
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml eb89dbd
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 99882fd
Diff: https://reviews.apache.org/r/34279/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 34279: ConfigureTask For Upgrades Must Support Type
Coercion
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34279/#review83948
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On May 15, 2015, 4:51 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34279/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 4:51 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11177
> https://issues.apache.org/jira/browse/AMBARI-11177
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ConfigureTask must be able to support type coercion when copying values between stacks. This will enable data transformation during an upgrade. In particular, this solves the issue of a configuration type being changed between stack versions.
>
> <transfer operation="copy" from-key="nimbus.host" to-key="nimbus.seeds" coerce-to="yaml-array" />
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 645c4bb
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 2b68a28
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferCoercionType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferOperation.java 1ee2a35
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml eb89dbd
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 99882fd
>
> Diff: https://reviews.apache.org/r/34279/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 34279: ConfigureTask For Upgrades Must Support Type
Coercion
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34279/#review83960
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On May 15, 2015, 12:51 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34279/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 12:51 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11177
> https://issues.apache.org/jira/browse/AMBARI-11177
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ConfigureTask must be able to support type coercion when copying values between stacks. This will enable data transformation during an upgrade. In particular, this solves the issue of a configuration type being changed between stack versions.
>
> <transfer operation="copy" from-key="nimbus.host" to-key="nimbus.seeds" coerce-to="yaml-array" />
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 645c4bb
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 2b68a28
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferCoercionType.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferOperation.java 1ee2a35
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml eb89dbd
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 99882fd
>
> Diff: https://reviews.apache.org/r/34279/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>