You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:52:17 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #2430: fix: plugin hot reload should work on node

spacewander commented on a change in pull request #2430:
URL: https://github.com/apache/apisix/pull/2430#discussion_r515791347



##########
File path: apisix/plugins/prometheus.lua
##########
@@ -29,7 +29,6 @@ local _M = {
     version = 0.2,
     priority = 500,
     name = plugin_name,
-    init = exporter.init,

Review comment:
       @membphis 
   Because we don't call the prometheus init function when the plugin reload anymore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org