You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/09/10 13:16:34 UTC
[jira] Created: (LUCENE-2639) remove random juggling in tests, add
-Dtests.seed
remove random juggling in tests, add -Dtests.seed
-------------------------------------------------
Key: LUCENE-2639
URL: https://issues.apache.org/jira/browse/LUCENE-2639
Project: Lucene - Java
Issue Type: Test
Components: Tests
Reporter: Robert Muir
Assignee: Robert Muir
Fix For: 3.1, 4.0
Since we added newIndexWriterConfig/newDirectory, etc, a lot of tests are juggling randoms around.
Instead this patch:
* changes it so LuceneTestCase[J4] manage the random.
* allow you to set -Dtests.seed=23432432432 to reproduce a test, rather than editing the code
* removes random arguments from newIndexWriterConfig, newDirectory.
I want to do this before looking at doing things like newField so we can vary term vectors, etc.
I also fixed the solr contrib builds so they arent hiding the exceptions i noted in SOLR-2002.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2639) remove random juggling in tests, add
-Dtests.seed
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2639:
--------------------------------
Attachment: LUCENE-2639.patch
> remove random juggling in tests, add -Dtests.seed
> -------------------------------------------------
>
> Key: LUCENE-2639
> URL: https://issues.apache.org/jira/browse/LUCENE-2639
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2639.patch
>
>
> Since we added newIndexWriterConfig/newDirectory, etc, a lot of tests are juggling randoms around.
> Instead this patch:
> * changes it so LuceneTestCase[J4] manage the random.
> * allow you to set -Dtests.seed=23432432432 to reproduce a test, rather than editing the code
> * removes random arguments from newIndexWriterConfig, newDirectory.
> I want to do this before looking at doing things like newField so we can vary term vectors, etc.
> I also fixed the solr contrib builds so they arent hiding the exceptions i noted in SOLR-2002.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2639) remove random juggling in tests, add
-Dtests.seed
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2639.
---------------------------------
Resolution: Fixed
forgot to mark this one resolved:
Committed revisions 995772, 995863 (3x)
> remove random juggling in tests, add -Dtests.seed
> -------------------------------------------------
>
> Key: LUCENE-2639
> URL: https://issues.apache.org/jira/browse/LUCENE-2639
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2639.patch
>
>
> Since we added newIndexWriterConfig/newDirectory, etc, a lot of tests are juggling randoms around.
> Instead this patch:
> * changes it so LuceneTestCase[J4] manage the random.
> * allow you to set -Dtests.seed=23432432432 to reproduce a test, rather than editing the code
> * removes random arguments from newIndexWriterConfig, newDirectory.
> I want to do this before looking at doing things like newField so we can vary term vectors, etc.
> I also fixed the solr contrib builds so they arent hiding the exceptions i noted in SOLR-2002.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2639) remove random juggling in tests,
add -Dtests.seed
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908011#action_12908011 ]
Simon Willnauer commented on LUCENE-2639:
-----------------------------------------
Nice work robert! passes for me too.
simon
> remove random juggling in tests, add -Dtests.seed
> -------------------------------------------------
>
> Key: LUCENE-2639
> URL: https://issues.apache.org/jira/browse/LUCENE-2639
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2639.patch
>
>
> Since we added newIndexWriterConfig/newDirectory, etc, a lot of tests are juggling randoms around.
> Instead this patch:
> * changes it so LuceneTestCase[J4] manage the random.
> * allow you to set -Dtests.seed=23432432432 to reproduce a test, rather than editing the code
> * removes random arguments from newIndexWriterConfig, newDirectory.
> I want to do this before looking at doing things like newField so we can vary term vectors, etc.
> I also fixed the solr contrib builds so they arent hiding the exceptions i noted in SOLR-2002.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2639) remove random juggling in tests,
add -Dtests.seed
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907995#action_12907995 ]
Michael McCandless commented on LUCENE-2639:
--------------------------------------------
Awesome! Patch looks good -- all tests pass for me on beast (linux).
It's nice not having to pass random to newXXX.
> remove random juggling in tests, add -Dtests.seed
> -------------------------------------------------
>
> Key: LUCENE-2639
> URL: https://issues.apache.org/jira/browse/LUCENE-2639
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2639.patch
>
>
> Since we added newIndexWriterConfig/newDirectory, etc, a lot of tests are juggling randoms around.
> Instead this patch:
> * changes it so LuceneTestCase[J4] manage the random.
> * allow you to set -Dtests.seed=23432432432 to reproduce a test, rather than editing the code
> * removes random arguments from newIndexWriterConfig, newDirectory.
> I want to do this before looking at doing things like newField so we can vary term vectors, etc.
> I also fixed the solr contrib builds so they arent hiding the exceptions i noted in SOLR-2002.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org