You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/07 12:38:39 UTC

[GitHub] [ozone] GlenGeng opened a new pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

GlenGeng opened a new pull request #1903:
URL: https://github.com/apache/ozone/pull/1903


   ## What changes were proposed in this pull request?
   
   TestContainerEndpoint is broken after merging master to HDDS-2823 at Feb.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4800
   ## How was this patch tested?
   
   CI
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] bshashikant commented on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774936428


   The unit test failures is due to TestReconContainerManager. I am committing this one to unblock other PRs as the failures reported with this are unrelated to the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] bshashikant commented on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774859166


   @GlenGeng , can you please add some detail about what was causing the test failure?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] bshashikant merged pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1903:
URL: https://github.com/apache/ozone/pull/1903


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] GlenGeng edited a comment on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774894654


   After diff `hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerEndpoint.java` between HDDS-2823 and master, the reason for failure is:
   
   During the merge and conflict fix, 
   ```
     void putContainerInfos(int num) throws IOException {
       for (int i = 1; i <= num; i++) {
         final ContainerInfo info = newContainerInfo(i);
         reconContainerManager.getContainerStore().put(new ContainerID(i), info);
         reconContainerManager.getContainerStateManager().addContainerInfo(
             i, info, null, null);
       }
     }
   ```
   is manually replaced by 
   ```
   for (int i = 1; i <= num; i++) {
     final ContainerInfo info = newContainerInfo(i);
     reconContainerManager.addNewContainer(I,
         new ContainerWithPipeline(info, pipeline));
   }
   ```
   
   It requires `pipeline` to exist in `ReconPipelineManager`, otherwise `addNewContainer` will fail, due to pipeline not found exception. The  thus the solution is quite straight forward, add the random generated pipeline into `ReconPipelineManager`.
   
   BTW
   ```
   // Mock ReconStorageContainerManagerFacade and other SCM related methods
   ```
   it is already removed from master, and during the merge, we just remove it too.
   
   The fix of `TestReconContainerManager` is due to the same reason.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] GlenGeng edited a comment on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774822251


   After last two merge of master, we have four failures:
   The first merge cause the failure unit test(TestContainerEndpoint, TestReconContainerManager) and misc docker test.
   The second merge cause the failure of find bugs.
   
   The fix is aims to the TestContainerEndpoint.
   
   @nandakumar131 @bshashikant @amaliujia Please take a look!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] bshashikant commented on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774936672


   Thanks @GlenGeng for the contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] GlenGeng commented on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774822251


   After last two merge of master, we have four failures, one is findBugs, due to the second merge, 
   The first merge cause the failure unit test(TestContainerEndpoint, TestReconContainerManager) and misc docker.
   The second merge cause the failure of find bugs.
   
   The fix is aims to the TestContainerEndpoint.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] GlenGeng edited a comment on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774822251


   After last two merge of master, we have four failures:
   The first merge cause the failure unit test(TestContainerEndpoint, TestReconContainerManager) and misc docker test.
   The second merge cause the failure of find bugs.
   
   The fix is aims to the TestContainerEndpoint.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] GlenGeng commented on pull request #1903: HDDS-4800. Fix TestContainerEndpoint after merging master to HDDS-2823.

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1903:
URL: https://github.com/apache/ozone/pull/1903#issuecomment-774894654


   After diff `hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerEndpoint.java` between HDDS-2823 and master, the reason for failure is:
   
   ```
     void putContainerInfos(int num) throws IOException {
       for (int i = 1; i <= num; i++) {
         final ContainerInfo info = newContainerInfo(i);
         reconContainerManager.getContainerStore().put(new ContainerID(i), info);
         reconContainerManager.getContainerStateManager().addContainerInfo(
             i, info, null, null);
       }
     }
   ```
   is replaced by 
   ```
   for (int i = 1; i <= num; i++) {
     final ContainerInfo info = newContainerInfo(i);
     reconContainerManager.addNewContainer(I,
         new ContainerWithPipeline(info, pipeline));
   }
   ```
   
   It requires `pipeline` to exist in `ReconPipelineManager`, otherwise `addNewContainer` will fail, due to pipeline not found exception. The  thus the solution is quite straight forward, add the random generated pipeline into `ReconPipelineManager`.
   
   BTW
   ```
   // Mock ReconStorageContainerManagerFacade and other SCM related methods
   ```
   it is already removed from master, and during the merge, we just remove it too.
   
   The fix of `TestReconContainerManager` is due to the same reason.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org