You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/10 05:17:25 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #11351:
[FLINK-16404][runtime] Avoid caching buffers for blocked input channels
before barrier alignment
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r406606270
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -114,7 +114,7 @@ private boolean add(BufferConsumer bufferConsumer, boolean finish) {
buffers.add(bufferConsumer);
updateStatistics(bufferConsumer);
increaseBuffersInBacklog(bufferConsumer);
- notifyDataAvailable = shouldNotifyDataAvailable() || finish;
+ notifyDataAvailable = shouldNotifyDataAvailable();
Review comment:
If this condition is actually redundant irrelevant with this PR, then we can create a separate ticket for removing it.
I am not sure whether there were any considerations for adding this tag before and might impact behaviors, then it is better for a separate ticket for checking instead of a hotfix commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services