You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vishal Suvagia <vi...@yahoo.com> on 2016/12/13 15:20:51 UTC
Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support
for Hive2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54706/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 3:20 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, and Swapan Shridhar.
Bugs: AMBARI-19188
https://issues.apache.org/jira/browse/AMBARI-19188
Repository: ambari
Description
-------
Need to provide Atlas hook configuration support for HiveServer-Interactive.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 7fbd6bd
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py af2a05d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 33f1056
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json dde3e00
Diff: https://reviews.apache.org/r/54706/diff/
Testing
-------
Tested Hive and Hive2 with Atlas installation on cent-os 6.
test_make_valid_json_6 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_make_valid_json_7 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_make_valid_json_8 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_make_valid_json_9 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_default_with_llap_multi_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_default_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_hsi_ha_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_with_ha_and_llap_running (test_hive_server_int.TestHiveServerInteractive) ... ok
Thanks,
Vishal Suvagia
Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support
for Hive2
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54706/#review159145
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Dec. 14, 2016, 1:26 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54706/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 1:26 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, and Swapan Shridhar.
>
>
> Bugs: AMBARI-19188
> https://issues.apache.org/jira/browse/AMBARI-19188
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to provide Atlas hook configuration support for HiveServer-Interactive.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 7fbd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py af2a05d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 33f1056
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json dde3e00
>
> Diff: https://reviews.apache.org/r/54706/diff/
>
>
> Testing
> -------
>
> Tested Hive and Hive2 with Atlas installation on cent-os 6.
>
>
> test_make_valid_json_6 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_7 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_8 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_9 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_default_with_llap_multi_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_default_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_hsi_ha_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_with_ha_and_llap_running (test_hive_server_int.TestHiveServerInteractive) ... ok
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support
for Hive2
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54706/#review161448
-----------------------------------------------------------
Pushed to trunk, commit cc302f7d3c79d12fef8873acd76e962218aaac65
branch-2.5, commit 06e88d39d718ce02bd8559a1c52a7b62e9726275
- Alejandro Fernandez
On Dec. 14, 2016, 1:26 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54706/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 1:26 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, and Swapan Shridhar.
>
>
> Bugs: AMBARI-19188
> https://issues.apache.org/jira/browse/AMBARI-19188
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to provide Atlas hook configuration support for HiveServer-Interactive.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 7fbd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py af2a05d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 33f1056
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json dde3e00
>
> Diff: https://reviews.apache.org/r/54706/diff/
>
>
> Testing
> -------
>
> Tested Hive and Hive2 with Atlas installation on cent-os 6.
>
>
> test_make_valid_json_6 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_7 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_8 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_9 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_default_with_llap_multi_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_default_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_hsi_ha_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_with_ha_and_llap_running (test_hive_server_int.TestHiveServerInteractive) ... ok
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support
for Hive2
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54706/#review159192
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 14, 2016, 1:26 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54706/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 1:26 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, and Swapan Shridhar.
>
>
> Bugs: AMBARI-19188
> https://issues.apache.org/jira/browse/AMBARI-19188
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to provide Atlas hook configuration support for HiveServer-Interactive.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 7fbd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py af2a05d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 33f1056
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json dde3e00
>
> Diff: https://reviews.apache.org/r/54706/diff/
>
>
> Testing
> -------
>
> Tested Hive and Hive2 with Atlas installation on cent-os 6.
>
>
> test_make_valid_json_6 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_7 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_8 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_make_valid_json_9 (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_default_with_llap_multi_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_default_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_hsi_ha_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
> test_start_with_ha_and_llap_running (test_hive_server_int.TestHiveServerInteractive) ... ok
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support
for Hive2
Posted by Vishal Suvagia <vi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54706/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 1:26 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, and Swapan Shridhar.
Changes
-------
removing creation of hive-env from patch as it is not required
Bugs: AMBARI-19188
https://issues.apache.org/jira/browse/AMBARI-19188
Repository: ambari
Description
-------
Need to provide Atlas hook configuration support for HiveServer-Interactive.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 7fbd6bd
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py af2a05d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 33f1056
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json dde3e00
Diff: https://reviews.apache.org/r/54706/diff/
Testing
-------
Tested Hive and Hive2 with Atlas installation on cent-os 6.
test_make_valid_json_6 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_make_valid_json_7 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_make_valid_json_8 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_make_valid_json_9 (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_default_with_llap_multi_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_default_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_hsi_ha_with_llap_single_line_output (test_hive_server_int.TestHiveServerInteractive) ... ok
test_start_with_ha_and_llap_running (test_hive_server_int.TestHiveServerInteractive) ... ok
Thanks,
Vishal Suvagia