You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Shashank Shekhar (Jira)" <ji...@apache.org> on 2020/09/05 17:56:00 UTC
[jira] [Comment Edited] (SOLR-14723) Rremove the class atribute for
the caches in the _default/example configsets
[ https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191119#comment-17191119 ]
Shashank Shekhar edited comment on SOLR-14723 at 9/5/20, 5:55 PM:
------------------------------------------------------------------
Thanks for the detailed steps [~erickerickson] . I have forked the lucene-solr repo. I am not familiar with patches so planning to create a PR. Will keep this thread updated.
I have few questions:
# Should I do my changes on the master branch in my forked repo and raise a PR against the master in main repo?
# Assuming answer to 1 is yes I should be able to import the project in my intellij as a gradle project and have nothing to do with ant.
was (Author: shshnk28):
Thanks for the detailed steps Erick. I have forked the lucene-solr repo. I am not familiar with patches so planning to create a PR. Will keep this thread updated.
I have few questions:
# Should I do my changes on the master branch in my forked repo and raise a PR against the master in main repo?
# Assuming answer to 1 is yes I should be able to import the project in my intellij as a gradle project and have nothing to do with ant.
> Rremove the class atribute for the caches in the _default/example configsets
> ----------------------------------------------------------------------------
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomas Eduardo Fernandez Lobbe
> Priority: Trivial
> Labels: newdev
>
> In 8.x branch, the default and example configsets include LRUCache and FastLRUCache as the implementation for the various caches.
> {code:xml}
> <filterCache class="solr.FastLRUCache"
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute completely and let the default take over (as it's in master), this should make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org