You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/08/12 03:16:00 UTC
[PR] Use database metadata for logical default schema resolution [shardingsphere]
menghaoranss opened a new pull request, #39416:
URL: https://github.com/apache/shardingsphere/pull/39416
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database metadata for logical default schema resolution [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39416:
URL: https://github.com/apache/shardingsphere/pull/39416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database metadata for logical default schema resolution [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39416:
URL: https://github.com/apache/shardingsphere/pull/39416#issuecomment-5289914038
```markdown
### Result
**Review Result: Mergeable**
No actionable code-correctness issues were found.
### Evidence
- Reviewed public head `bd2718dfecc20fdc2257c67a268f8bea722044cd`.
- `SupportedSQLCheckEngine.java:56-58` now obtains the default schema from database metadata while preserving explicit-schema precedence and missing-schema null behavior.
- `SQLTokenGenerators.java:83-85` supplies `SchemaMetaDataAware` generators with the canonical loaded default schema.
- `findDefaultSchema()` uses the database’s identifier-aware schema index, as introduced and tested by [PR #39396](https://github.com/apache/shardingsphere/pull/39396).
- Updated tests verify that the exact default schema object reaches SQL checkers and rewrite generators.
- Exact-head `git diff --check` passed.
### Coverage
- Reviewed all four GitHub-listed files; the local triple-dot list matched GitHub.
- Behavior clusters: SQL-checker schema resolution and rewrite-generator schema injection.
- Traced default, explicit, case-normalized, canonical-name, and missing-schema paths.
- Reviewed the only `SchemaMetaDataAware` production consumer and all supported-SQL checker entry paths.
- Completed root-cause, blast-radius, tests/runtime, history, and convergence passes.
- Local Maven tests were not rerun because the current worktree is not the PR head and no Git state change was authorized.
- Unresolved evidence gaps: none.
- Code-scope result only; CI was not reviewed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org