[GitHub] syed commented on a change in pull request #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC

[gi...@git.apache.org]

syed commented on a change in pull request #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
URL: https://github.com/apache/cloudstack/pull/2221#discussion_r134241131
 
 

 ##########
 File path: systemvm/patches/debian/config/opt/cloud/bin/configure.py
 ##########
 @@ -886,7 +886,7 @@ def forward_vr(self, rule):
         self.fw.append(["filter", "", fw7])
 
     def forward_vpc(self, rule):
-        fw_prerout_rule = "-A PREROUTING -d %s/32 -i %s" % (rule["public_ip"], self.getDeviceByIp(rule['public_ip']))
+        fw_prerout_rule = "-A PREROUTING -d %s/32 " % (rule["public_ip"])
 
 Review comment:
   @rhtyd This is already fixed in `forward_vr` as there is only one internal network for each VR so the IPtables rules work correctly there. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services