You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <zs...@apache.org> on 2019/05/09 09:25:24 UTC

Review Request 70615: RANGER-2421 - add http client to atlas plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70615/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2421
    https://issues.apache.org/jira/browse/RANGER-2421


Repository: ranger


Description
-------

Due to http client version difference, and the lack of httpclient-4.5.3.jar inside the ranger-atlas-plugin/lib/ranger-atlas-plugin-impl/ folder, the following exception can be seen:

ava.lang.NoSuchMethodError: org.apache.http.impl.client.HttpClientBuilder.evictIdleConnections(JLjava/util/concurrent/TimeUnit;)Lorg/apache/http/impl/client/HttpClientBuilder;
        at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:311)
        at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:330)
        at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:268)
        at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:255)
        at org.apache.solr.client.solrj.impl.CloudSolrClient.<init>(CloudSolrClient.java:280)
        at org.apache.solr.client.solrj.impl.CloudSolrClient$Builder.build(CloudSolrClient.java:1600)
        at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:126)
        at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:123)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.security.auth.Subject.doAs(Subject.java:422)
        at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
        at org.apache.ranger.audit.provider.MiscUtil.executePrivilegedAction(MiscUtil.java:516)
        at org.apache.ranger.audit.destination.SolrAuditDestination.connect(SolrAuditDestination.java:123)
        at org.apache.ranger.audit.destination.SolrAuditDestination.init(SolrAuditDestination.java:72)
        at org.apache.ranger.audit.provider.AuditProviderFactory.init(AuditProviderFactory.java:179)
        at org.apache.ranger.plugin.service.RangerBasePlugin.init(RangerBasePlugin.java:217)

Atlas has a httpclient-4.4.x, which lacks the needed method.


Diffs
-----

  src/main/assembly/plugin-atlas.xml 4de27b071 


Diff: https://reviews.apache.org/r/70615/diff/1/


Testing
-------

Added the necessary jars to a deployed Atlas server, and noticed that the exception disapears, and audit correctly sent.


Thanks,

Zsombor Gegesy

Re: Review Request 70615: RANGER-2421 - add http client to atlas plugin

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70615/#review215361
-----------------------------------------------------------




src/main/assembly/plugin-atlas.xml
Lines 58 (patched)
<https://reviews.apache.org/r/70615/#comment302036>

    @Madhan,
    
    Atlas used 4.4.1 version of httpclient library. 
    Updating httpclient jar with 4.5.3 in Atlas resolves this NoSuchMethodError exception , I think it make sense to update this version at Atlas end.


- Nixon Rodrigues


On May 9, 2019, 9:25 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70615/
> -----------------------------------------------------------
> 
> (Updated May 9, 2019, 9:25 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2421
>     https://issues.apache.org/jira/browse/RANGER-2421
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Due to http client version difference, and the lack of httpclient-4.5.3.jar inside the ranger-atlas-plugin/lib/ranger-atlas-plugin-impl/ folder, the following exception can be seen:
> 
> ava.lang.NoSuchMethodError: org.apache.http.impl.client.HttpClientBuilder.evictIdleConnections(JLjava/util/concurrent/TimeUnit;)Lorg/apache/http/impl/client/HttpClientBuilder;
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:311)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:330)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:268)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:255)
>         at org.apache.solr.client.solrj.impl.CloudSolrClient.<init>(CloudSolrClient.java:280)
>         at org.apache.solr.client.solrj.impl.CloudSolrClient$Builder.build(CloudSolrClient.java:1600)
>         at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:126)
>         at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:123)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at javax.security.auth.Subject.doAs(Subject.java:422)
>         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
>         at org.apache.ranger.audit.provider.MiscUtil.executePrivilegedAction(MiscUtil.java:516)
>         at org.apache.ranger.audit.destination.SolrAuditDestination.connect(SolrAuditDestination.java:123)
>         at org.apache.ranger.audit.destination.SolrAuditDestination.init(SolrAuditDestination.java:72)
>         at org.apache.ranger.audit.provider.AuditProviderFactory.init(AuditProviderFactory.java:179)
>         at org.apache.ranger.plugin.service.RangerBasePlugin.init(RangerBasePlugin.java:217)
> 
> Atlas has a httpclient-4.4.x, which lacks the needed method.
> 
> 
> Diffs
> -----
> 
>   src/main/assembly/plugin-atlas.xml 4de27b071 
> 
> 
> Diff: https://reviews.apache.org/r/70615/diff/1/
> 
> 
> Testing
> -------
> 
> Added the necessary jars to a deployed Atlas server, and noticed that the exception disapears, and audit correctly sent.
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 70615: RANGER-2421 - add http client to atlas plugin

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70615/#review215161
-----------------------------------------------------------




src/main/assembly/plugin-atlas.xml
Lines 58 (patched)
<https://reviews.apache.org/r/70615/#comment301684>

    Zsombor - Atlas includes 4.4.1 version of httpsclient and httpcore libraries. If Atlas can be updated to  use 4.5.3 version of these libraries, we can avoid having 2 different versions in a single process.
    
    @Nixon - can you please investigate if Atlas can be updated for this?


- Madhan Neethiraj


On May 9, 2019, 9:25 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70615/
> -----------------------------------------------------------
> 
> (Updated May 9, 2019, 9:25 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2421
>     https://issues.apache.org/jira/browse/RANGER-2421
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Due to http client version difference, and the lack of httpclient-4.5.3.jar inside the ranger-atlas-plugin/lib/ranger-atlas-plugin-impl/ folder, the following exception can be seen:
> 
> ava.lang.NoSuchMethodError: org.apache.http.impl.client.HttpClientBuilder.evictIdleConnections(JLjava/util/concurrent/TimeUnit;)Lorg/apache/http/impl/client/HttpClientBuilder;
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:311)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:330)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:268)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:255)
>         at org.apache.solr.client.solrj.impl.CloudSolrClient.<init>(CloudSolrClient.java:280)
>         at org.apache.solr.client.solrj.impl.CloudSolrClient$Builder.build(CloudSolrClient.java:1600)
>         at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:126)
>         at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:123)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at javax.security.auth.Subject.doAs(Subject.java:422)
>         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
>         at org.apache.ranger.audit.provider.MiscUtil.executePrivilegedAction(MiscUtil.java:516)
>         at org.apache.ranger.audit.destination.SolrAuditDestination.connect(SolrAuditDestination.java:123)
>         at org.apache.ranger.audit.destination.SolrAuditDestination.init(SolrAuditDestination.java:72)
>         at org.apache.ranger.audit.provider.AuditProviderFactory.init(AuditProviderFactory.java:179)
>         at org.apache.ranger.plugin.service.RangerBasePlugin.init(RangerBasePlugin.java:217)
> 
> Atlas has a httpclient-4.4.x, which lacks the needed method.
> 
> 
> Diffs
> -----
> 
>   src/main/assembly/plugin-atlas.xml 4de27b071 
> 
> 
> Diff: https://reviews.apache.org/r/70615/diff/1/
> 
> 
> Testing
> -------
> 
> Added the necessary jars to a deployed Atlas server, and noticed that the exception disapears, and audit correctly sent.
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 70615: RANGER-2421 - add http client to atlas plugin

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70615/#review215409
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On May 9, 2019, 9:25 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70615/
> -----------------------------------------------------------
> 
> (Updated May 9, 2019, 9:25 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2421
>     https://issues.apache.org/jira/browse/RANGER-2421
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Due to http client version difference, and the lack of httpclient-4.5.3.jar inside the ranger-atlas-plugin/lib/ranger-atlas-plugin-impl/ folder, the following exception can be seen:
> 
> ava.lang.NoSuchMethodError: org.apache.http.impl.client.HttpClientBuilder.evictIdleConnections(JLjava/util/concurrent/TimeUnit;)Lorg/apache/http/impl/client/HttpClientBuilder;
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:311)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:330)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:268)
>         at org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:255)
>         at org.apache.solr.client.solrj.impl.CloudSolrClient.<init>(CloudSolrClient.java:280)
>         at org.apache.solr.client.solrj.impl.CloudSolrClient$Builder.build(CloudSolrClient.java:1600)
>         at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:126)
>         at org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:123)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at javax.security.auth.Subject.doAs(Subject.java:422)
>         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
>         at org.apache.ranger.audit.provider.MiscUtil.executePrivilegedAction(MiscUtil.java:516)
>         at org.apache.ranger.audit.destination.SolrAuditDestination.connect(SolrAuditDestination.java:123)
>         at org.apache.ranger.audit.destination.SolrAuditDestination.init(SolrAuditDestination.java:72)
>         at org.apache.ranger.audit.provider.AuditProviderFactory.init(AuditProviderFactory.java:179)
>         at org.apache.ranger.plugin.service.RangerBasePlugin.init(RangerBasePlugin.java:217)
> 
> Atlas has a httpclient-4.4.x, which lacks the needed method.
> 
> 
> Diffs
> -----
> 
>   src/main/assembly/plugin-atlas.xml 4de27b071 
> 
> 
> Diff: https://reviews.apache.org/r/70615/diff/1/
> 
> 
> Testing
> -------
> 
> Added the necessary jars to a deployed Atlas server, and noticed that the exception disapears, and audit correctly sent.
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>