[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2100: [IGNITE-19496] Sql. Implement SqlSchemaManager on top of CatalogService.

["AMashenkov (via GitHub)" <gi...@apache.org>]

AMashenkov commented on code in PR #2100:
URL: https://github.com/apache/ignite-3/pull/2100#discussion_r1211589245


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/TableDescriptor.java:
##########
@@ -88,6 +86,18 @@ public int engineId() {
         return engineId;
     }
 
+    public TableColumnDescriptor[] columns() {
+        return columns;
+    }
+
+    public boolean isKeyColumn(String name) {
+        return Arrays.binarySearch(primaryKeyColumns, name) >= 0;

Review Comment:
   primaryKeyColumns array is not sorted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org