[jira] [Commented] (BEAM-2389) GcpCoreApiSurfaceTest isn't testing right module

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062329#comment-16062329 ] 

ASF GitHub Bot commented on BEAM-2389:
--------------------------------------

GitHub user adude3141 opened a pull request:

    https://github.com/apache/beam/pull/3436

    BEAM-2389 moved GcpCoreApiSurfaceTest to corresponding module, adapte…

    …d exposed packagees
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adude3141/beam BEAM-2389

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3436
    
----
commit 67313b616d0f8ab5a7a8f7d2a6d11a693adadf9b
Author: Michael Luckey <mi...@ext.gfk.com>
Date:   2017-06-25T13:01:08Z

    BEAM-2389 moved GcpCoreApiSurfaceTest to corresponding module, adapted exposed packagees

----


> GcpCoreApiSurfaceTest isn't testing right module
> ------------------------------------------------
>
>                 Key: BEAM-2389
>                 URL: https://issues.apache.org/jira/browse/BEAM-2389
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>    Affects Versions: 2.0.0
>            Reporter: Daniel Halperin
>            Assignee: Michael Luckey
>             Fix For: 2.1.0
>
>
> It looks like a clone of {{SdkApiSurfaceTest}} that was not updated, outside of being renamed, now that it's in a new module. Even the java package of the test is wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)