You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/18 23:05:34 UTC
[GitHub] [arrow] vertexclique opened a new pull request #8487: ARROW-10338 - Use const fn for applicable methods
vertexclique opened a new pull request #8487:
URL: https://github.com/apache/arrow/pull/8487
This PR applies `const fn` to applicable methods. The advantage is that most bound checks are eliminated by this propagation. Moreover, it improves various kernels ranging from %2 to %10. In total **30 benchmarks** are improved significantly.
Scalar comparisons had the most valuable hit coming up with ~%10.
**Rustc version: rustc 1.47.0 (18bf6b4f0 2020-10-07) stable**
Freq. scaling disabled.
<details>
<summary>Benchmarks are here.</summary>
<br>
sum 512 time: [730.14 ns 730.51 ns 730.96 ns]
change: [-2.8084% -2.5687% -2.3508%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) high mild
4 (4.00%) high severe
min 512 time: [1.0519 us 1.0534 us 1.0553 us]
change: [-1.1276% -0.9096% -0.6971%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 16 outliers among 100 measurements (16.00%)
5 (5.00%) high mild
11 (11.00%) high severe
sum nulls 512 time: [396.12 ns 400.21 ns 406.04 ns]
change: [+0.2342% +0.7520% +1.3534%] (p = 0.01 < 0.05)
Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe
min nulls 512 time: [2.0660 us 2.0732 us 2.0809 us]
change: [-2.0040% -0.8910% +0.1270%] (p = 0.11 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
Running /Users/mahmut/projects/arrow/rust/target/release/deps/arithmetic_kernels-e0816675c633fa44
add 512 time: [1.8339 us 1.8383 us 1.8429 us]
change: [-1.6928% -1.3225% -0.9689%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
subtract 512 time: [1.8491 us 1.8586 us 1.8700 us]
change: [-2.6489% -2.1225% -1.6275%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
multiply 512 time: [1.8525 us 1.8624 us 1.8734 us]
change: [-1.3420% -0.8615% -0.3658%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
divide 512 time: [2.5951 us 2.6000 us 2.6050 us]
change: [-5.9829% -5.6697% -5.3636%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
limit 512, 512 time: [527.39 ns 530.38 ns 533.34 ns]
change: [+0.7720% +1.5131% +2.2692%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 29 outliers among 100 measurements (29.00%)
21 (21.00%) low mild
2 (2.00%) high mild
6 (6.00%) high severe
add_nulls_512 time: [1.8618 us 1.8702 us 1.8801 us]
change: [-1.4097% -1.0360% -0.6251%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
divide_nulls_512 time: [2.6223 us 2.6378 us 2.6553 us]
change: [-5.3277% -4.7876% -4.2442%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
Running /Users/mahmut/projects/arrow/rust/target/release/deps/array_from_vec-0a61d7deb0a4ad08
array_from_vec 128 time: [1.3979 us 1.4025 us 1.4073 us]
change: [-0.6887% -0.2000% +0.2621%] (p = 0.42 > 0.05)
No change in performance detected.
array_from_vec 256 time: [1.5764 us 1.5856 us 1.5946 us]
change: [-3.8454% -3.1015% -2.4497%] (p = 0.00 < 0.05)
Performance has improved.
array_from_vec 512 time: [2.1462 us 2.1581 us 2.1713 us]
change: [+0.9897% +1.6695% +2.2947%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
array_string_from_vec 128
time: [4.3700 us 4.4091 us 4.4525 us]
change: [-3.9824% -2.8529% -1.8460%] (p = 0.00 < 0.05)
Performance has improved.
Found 16 outliers among 100 measurements (16.00%)
16 (16.00%) high mild
array_string_from_vec 256
time: [5.7222 us 5.7639 us 5.8072 us]
change: [-0.5021% +0.2433% +1.0116%] (p = 0.52 > 0.05)
No change in performance detected.
array_string_from_vec 512
time: [8.1461 us 8.1927 us 8.2469 us]
change: [-2.7291% -1.9787% -1.2361%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
10 (10.00%) high mild
struct_array_from_vec 128
time: [9.9635 us 9.9840 us 10.008 us]
change: [-0.1159% +0.2595% +0.6715%] (p = 0.21 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
struct_array_from_vec 256
time: [12.409 us 12.453 us 12.498 us]
change: [-0.0931% +0.2616% +0.6219%] (p = 0.16 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
struct_array_from_vec 512
time: [17.549 us 17.627 us 17.729 us]
change: [+0.3782% +0.7137% +1.0386%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
struct_array_from_vec 1024
time: [27.594 us 27.643 us 27.692 us]
change: [-0.1451% +0.2013% +0.5480%] (p = 0.25 > 0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
Running /Users/mahmut/projects/arrow/rust/target/release/deps/boolean_kernels-5a3b92f060303cc5
and time: [51.807 us 51.934 us 52.090 us]
change: [-8.0736% -7.8646% -7.6033%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe
or time: [51.801 us 52.077 us 52.438 us]
change: [-8.5483% -8.1956% -7.8230%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe
not time: [26.180 us 26.215 us 26.254 us]
change: [-8.0415% -7.8240% -7.5292%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe
Running /Users/mahmut/projects/arrow/rust/target/release/deps/buffer_bit_ops-806f5758a2de3901
buffer_bit_ops and time: [550.87 ns 556.47 ns 562.11 ns]
change: [+4.1870% +5.0524% +5.9410%] (p = 0.00 < 0.05)
Performance has regressed.
Running /Users/mahmut/projects/arrow/rust/target/release/deps/builder-e09f6591400ab759
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Running /Users/mahmut/projects/arrow/rust/target/release/deps/cast_kernels-68b32310073982ff
cast int32 to int32 512 time: [34.010 ns 34.032 ns 34.057 ns]
change: [-1.2477% -1.1510% -1.0519%] (p = 0.00 < 0.05)
Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
6 (6.00%) high mild
7 (7.00%) high severe
cast int32 to uint32 512
time: [11.260 us 11.280 us 11.301 us]
change: [+9.4141% +9.7693% +10.133%] (p = 0.00 < 0.05)
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
cast int32 to float32 512
time: [9.3097 us 9.3736 us 9.4623 us]
change: [-0.7439% -0.1756% +0.4058%] (p = 0.58 > 0.05)
No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) low mild
2 (2.00%) high mild
3 (3.00%) high severe
cast int32 to float64 512
time: [7.8718 us 7.8838 us 7.8973 us]
change: [-3.7644% -3.5678% -3.3645%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
2 (2.00%) low mild
8 (8.00%) high mild
2 (2.00%) high severe
cast int32 to int64 512 time: [8.4630 us 8.4804 us 8.5067 us]
change: [+1.8584% +2.5901% +3.1686%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe
cast float32 to int32 512
time: [9.7656 us 9.7803 us 9.7967 us]
change: [+3.1147% +3.3757% +3.6695%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe
cast float64 to float32 512
time: [9.4568 us 9.4685 us 9.4807 us]
change: [-0.6625% -0.4879% -0.3207%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
cast float64 to uint64 512
time: [9.2359 us 9.2646 us 9.3068 us]
change: [+2.2418% +2.5474% +2.8270%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
cast int64 to int32 512 time: [9.0114 us 9.0239 us 9.0361 us]
change: [-6.8636% -6.6590% -6.4251%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe
cast date64 to date32 512
time: [21.177 us 21.190 us 21.204 us]
change: [-0.5928% -0.3259% -0.1146%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) high mild
4 (4.00%) high severe
cast date32 to date64 512
time: [21.804 us 21.827 us 21.855 us]
change: [+3.7815% +3.9684% +4.1431%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) high mild
8 (8.00%) high severe
cast time32s to time32ms 512
time: [3.1176 us 3.1271 us 3.1367 us]
change: [+0.0133% +0.3136% +0.5963%] (p = 0.05 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
cast time32s to time64us 512
time: [12.505 us 12.523 us 12.544 us]
change: [+4.8556% +5.0491% +5.2661%] (p = 0.00 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
5 (5.00%) high mild
7 (7.00%) high severe
cast time64ns to time32s 512
time: [28.007 us 28.058 us 28.130 us]
change: [-0.5278% +0.3060% +0.8301%] (p = 0.50 > 0.05)
No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe
cast timestamp_ns to timestamp_s 512
time: [37.517 ns 37.538 ns 37.566 ns]
change: [-1.2193% -1.0554% -0.8353%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 14 outliers among 100 measurements (14.00%)
6 (6.00%) high mild
8 (8.00%) high severe
cast timestamp_ms to timestamp_ns 512
time: [3.8174 us 3.8283 us 3.8388 us]
change: [-0.4472% -0.0468% +0.3186%] (p = 0.82 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
cast timestamp_ms to i64 512
time: [598.40 ns 602.05 ns 606.00 ns]
change: [-0.0315% +0.7652% +1.5887%] (p = 0.07 > 0.05)
No change in performance detected.
Found 21 outliers among 100 measurements (21.00%)
1 (1.00%) low mild
19 (19.00%) high mild
1 (1.00%) high severe
Running /Users/mahmut/projects/arrow/rust/target/release/deps/comparison_kernels-b4b370fd16be1a8f
Benchmarking eq Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.4s, enable flat sampling, or reduce sample count to 50.
eq Float32 time: [1.6429 ms 1.6436 ms 1.6443 ms]
change: [-5.1596% -5.0351% -4.9285%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
5 (5.00%) high mild
4 (4.00%) high severe
Benchmarking eq scalar Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.9s, enable flat sampling, or reduce sample count to 50.
eq scalar Float32 time: [1.5459 ms 1.5489 ms 1.5531 ms]
change: [-6.2835% -6.0869% -5.8551%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severe
Benchmarking neq Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.0s, enable flat sampling, or reduce sample count to 50.
neq Float32 time: [1.5511 ms 1.5523 ms 1.5543 ms]
change: [-7.7097% -7.3434% -6.8809%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe
Benchmarking neq scalar Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.0s, enable flat sampling, or reduce sample count to 50.
neq scalar Float32 time: [1.5630 ms 1.5653 ms 1.5686 ms]
change: [-8.6209% -8.5125% -8.3952%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
3 (3.00%) high mild
9 (9.00%) high severe
Benchmarking lt Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.9s, enable flat sampling, or reduce sample count to 50.
lt Float32 time: [1.5582 ms 1.5589 ms 1.5597 ms]
change: [-8.2943% -8.2057% -8.1260%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) high mild
8 (8.00%) high severe
Benchmarking lt scalar Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.9s, enable flat sampling, or reduce sample count to 50.
lt scalar Float32 time: [1.5464 ms 1.5501 ms 1.5555 ms]
change: [-7.7728% -7.6026% -7.3629%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe
Benchmarking lt_eq Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.3s, enable flat sampling, or reduce sample count to 50.
lt_eq Float32 time: [1.6407 ms 1.6419 ms 1.6437 ms]
change: [-8.7938% -8.0889% -7.6493%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severe
Benchmarking lt_eq scalar Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.2s, enable flat sampling, or reduce sample count to 50.
lt_eq scalar Float32 time: [1.6131 ms 1.6178 ms 1.6253 ms]
change: [-9.4530% -9.2145% -8.9892%] (p = 0.00 < 0.05)
Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
5 (5.00%) high mild
8 (8.00%) high severe
Benchmarking gt Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.9s, enable flat sampling, or reduce sample count to 50.
gt Float32 time: [1.5554 ms 1.5579 ms 1.5623 ms]
change: [-8.4561% -8.3107% -8.1348%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
4 (4.00%) high mild
7 (7.00%) high severe
Benchmarking gt scalar Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.6s, enable flat sampling, or reduce sample count to 50.
gt scalar Float32 time: [1.4794 ms 1.4807 ms 1.4827 ms]
change: [-8.6776% -8.4677% -8.2929%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe
Benchmarking gt_eq Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.4s, enable flat sampling, or reduce sample count to 50.
gt_eq Float32 time: [1.6462 ms 1.6470 ms 1.6478 ms]
change: [-7.5929% -7.4622% -7.3477%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe
Benchmarking gt_eq scalar Float32: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.9s, enable flat sampling, or reduce sample count to 50.
gt_eq scalar Float32 time: [1.5454 ms 1.5467 ms 1.5489 ms]
change: [-7.2288% -7.0962% -6.9612%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
6 (6.00%) high mild
6 (6.00%) high severe
Running /Users/mahmut/projects/arrow/rust/target/release/deps/csv_writer-02e9378e050d4a29
record_batches_to_csv time: [402.67 us 414.37 us 427.93 us]
change: [+0.4023% +3.4436% +6.6651%] (p = 0.04 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
Running /Users/mahmut/projects/arrow/rust/target/release/deps/filter_kernels-1cb8f0570893af4f
filter u8 low selectivity
time: [170.98 us 171.21 us 171.55 us]
change: [-0.1135% +0.0430% +0.2235%] (p = 0.63 > 0.05)
No change in performance detected.
Found 12 outliers among 100 measurements (12.00%)
3 (3.00%) high mild
9 (9.00%) high severe
filter u8 high selectivity
time: [9.6924 us 9.7375 us 9.7963 us]
change: [-0.2986% +0.0722% +0.5776%] (p = 0.77 > 0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe
filter u8 very low selectivity
time: [22.873 us 22.934 us 23.008 us]
change: [+0.0767% +0.4022% +0.7005%] (p = 0.02 < 0.05)
Change within noise threshold.
filter context u8 low selectivity
time: [165.06 us 165.20 us 165.38 us]
change: [-0.0294% +0.1595% +0.3533%] (p = 0.10 > 0.05)
No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
4 (4.00%) high mild
9 (9.00%) high severe
filter context u8 high selectivity
time: [3.8607 us 3.8741 us 3.8882 us]
change: [-1.8287% -1.3097% -0.8238%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
filter context u8 very low selectivity
time: [16.804 us 16.853 us 16.908 us]
change: [-0.5046% -0.0902% +0.3005%] (p = 0.68 > 0.05)
No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
filter context u8 w NULLs low selectivity
time: [205.70 us 205.84 us 206.02 us]
change: [-0.2811% -0.0342% +0.1580%] (p = 0.79 > 0.05)
No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
6 (6.00%) high mild
7 (7.00%) high severe
filter context u8 w NULLs high selectivity
time: [4.4608 us 4.4730 us 4.4854 us]
change: [-0.5800% -0.1571% +0.2621%] (p = 0.45 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
filter context u8 w NULLs very low selectivity
time: [180.75 us 181.10 us 181.67 us]
change: [-11.189% -9.7175% -8.4367%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
4 (4.00%) high mild
7 (7.00%) high severe
filter context f32 low selectivity
time: [183.44 us 183.83 us 184.30 us]
change: [+7.1739% +7.4404% +7.6807%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) high mild
8 (8.00%) high severe
filter context f32 high selectivity
time: [4.4723 us 4.4832 us 4.4945 us]
change: [+2.6883% +3.4866% +4.1517%] (p = 0.00 < 0.05)
Performance has regressed.
filter context f32 very low selectivity
time: [31.159 us 31.274 us 31.396 us]
change: [-0.9498% -0.4106% +0.1088%] (p = 0.13 > 0.05)
No change in performance detected.
Running /Users/mahmut/projects/arrow/rust/target/release/deps/length_kernel-f385d09003fc80c2
length time: [55.496 us 55.557 us 55.634 us]
change: [+3.9148% +4.4346% +5.2731%] (p = 0.00 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
5 (5.00%) high mild
7 (7.00%) high severe
Running /Users/mahmut/projects/arrow/rust/target/release/deps/take_kernels-c16253f742638102
take i32 512 time: [3.4889 us 3.4972 us 3.5058 us]
change: [+0.7591% +1.0734% +1.4177%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
take i32 1024 time: [4.9671 us 4.9907 us 5.0169 us]
change: [+2.0735% +2.5564% +3.0233%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe
take bool 512 time: [3.7778 us 3.7863 us 3.7952 us]
change: [-5.7498% -5.0626% -4.5022%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
take bool 1024 time: [4.7858 us 4.8205 us 4.8696 us]
change: [-2.1546% -1.7011% -1.2077%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
take str 512 time: [9.7499 us 9.7805 us 9.8183 us]
change: [-5.7140% -5.2089% -4.5813%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high severe
take str 1024 time: [16.447 us 16.495 us 16.546 us]
change: [-5.4249% -5.0873% -4.7156%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #8487: ARROW-10338: [Rust] Use const fn for applicable methods
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #8487:
URL: https://github.com/apache/arrow/pull/8487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8487: ARROW-10338: [Rust] Use const fn for applicable methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8487:
URL: https://github.com/apache/arrow/pull/8487#issuecomment-711437524
https://issues.apache.org/jira/browse/ARROW-10338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org