You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/03 05:22:40 UTC

[GitHub] [superset] rusackas commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box

rusackas commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145595276

   FWIW, when I run this locally, I'm not seeing the issue that @AAfghahi was tackling in his earlier PR, but I'm spinning up an ephemeral environment, and pinging him for a review, just in case :)
   
   <img width="583" alt="image" src="https://user-images.githubusercontent.com/812905/171791516-77f17eb5-b3f0-44a9-84e7-74ce7d95c742.png">
   
   <img width="513" alt="image" src="https://user-images.githubusercontent.com/812905/171791573-9ef59642-588f-462c-8de8-c99f6fa43fd5.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org