You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/21 17:45:17 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #8988: Timing and radii

rusackas opened a new pull request #8988: Timing and radii
URL: https://github.com/apache/incubator-superset/pull/8988
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This PR consolidates CSS transition timings and border-radius properties into a minimized set of values, and centralizes those values in the main `variables.less` file. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Any changes should be either imperceptible, or in a couple cases, barely perceptible, in the case of a couple border-radius properties that were moved from 5px to 4px. If anyone needs those screenshots, I can slog through to find/add them.
   
   There was also one timing that was sped up, from 1s to 0.3s, in the dashboard editor. You can see the new, faster transition here:
   ![component_toggler](https://user-images.githubusercontent.com/812905/72828998-b3c0a680-3c32-11ea-8961-84671f28639d.gif)
   
   ### REVIEWERS
   @mistercrunch @etr2460 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #8988: Timing and radii

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8988: Timing and radii
URL: https://github.com/apache/incubator-superset/pull/8988#issuecomment-576815270
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8988?src=pr&el=h1) Report
   > Merging [#8988](https://codecov.io/gh/apache/incubator-superset/pull/8988?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2fc5fd4f2921f24e5064bf54561eff87e754409a?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8988/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8988?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #8988   +/-   ##
   =======================================
     Coverage   59.16%   59.16%           
   =======================================
     Files         367      367           
     Lines       11679    11679           
     Branches     2862     2862           
   =======================================
     Hits         6910     6910           
     Misses       4590     4590           
     Partials      179      179
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8988?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8988?src=pr&el=footer). Last update [2fc5fd4...fb1cd57](https://codecov.io/gh/apache/incubator-superset/pull/8988?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #8988: Timing and radii

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8988: Timing and radii
URL: https://github.com/apache/incubator-superset/pull/8988#issuecomment-577469707
 
 
   obligatory 
   ![css](https://user-images.githubusercontent.com/487433/72950475-5c106100-3d40-11ea-9196-a21ea0516201.gif)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #8988: Timing and radii

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #8988: Timing and radii
URL: https://github.com/apache/incubator-superset/pull/8988
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #8988: Timing and radii

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8988: Timing and radii
URL: https://github.com/apache/incubator-superset/pull/8988#issuecomment-577470636
 
 
   after merge:
   ![blinds](https://user-images.githubusercontent.com/487433/72950710-f96b9500-3d40-11ea-8d01-4a5061991776.gif)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org