You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by outofmem0ry <gi...@git.apache.org> on 2017/07/27 15:19:13 UTC
[GitHub] incubator-hawq pull request #1272: HAWQ-1198 - Fix to filter out irrelevant ...
GitHub user outofmem0ry opened a pull request:
https://github.com/apache/incubator-hawq/pull/1272
HAWQ-1198 - Fix to filter out irrelevant fragments while accessing Hive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1272.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1272
----
commit 4289b1c2a178e713b152fed705614c16341db01b
Author: Shubham Sharma <sh...@gmail.com>
Date: 2017-07-27T15:17:55Z
HAWQ-1198 - Fix to filter out irrelevant fragments while accesing Hive
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1272
@sansanichfb Test cases added.
---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/1272
@outofmem0ry - @radarwave and I would like to get a status of this PR. Have you had a chance to work on the unit tests requested by @sansanichfb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1272
Thank you for the review and merge @sansanichfb. Marking this closed.
---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on the issue:
https://github.com/apache/incubator-hawq/pull/1272
Looks good overall, can you please add unit tests, covering multiple operation, edge cases etc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1272: HAWQ-1198 - Fix to filter out irrelevant ...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1272
---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1272
@edespino didn't get a chance to work on the unit cases yet, started some research around it but I need to read more about the testing frameworks used in pxf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on the issue:
https://github.com/apache/incubator-hawq/pull/1272
@outofmem0ry merged to master, feel free to close PR.
---