You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jihoon Son <ji...@apache.org> on 2014/03/26 13:47:43 UTC

Review Request 19677: TAJO-713: Missing INET4 in UniformRangePartition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19677/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-713
    https://issues.apache.org/jira/browse/TAJO-713


Repository: tajo


Description
-------

Since the INET4 type is not handled properly, an error occurs with the following log.

2014-03-26 18:16:34,978 ERROR querymaster.SubQuery (SubQuery.java:transition(652)) - SubQuery (eb_1395825278930_0001_000002) ERROR:
java.lang.UnsupportedOperationException: type: INET4
 is not supported yet
        at org.apache.tajo.engine.planner.UniformRangePartition.increment(UniformRangePartition.java:411)
        at org.apache.tajo.engine.planner.UniformRangePartition.partition(UniformRangePartition.java:104)
        at org.apache.tajo.master.querymaster.Repartitioner.scheduleRangeShuffledFetches(Repartitioner.java:355)
        at org.apache.tajo.master.querymaster.Repartitioner.scheduleFragmentsForNonLeafTasks(Repartitioner.java:301)
        at org.apache.tajo.master.querymaster.SubQuery$InitAndRequestContainer.schedule(SubQuery.java:790)
        at org.apache.tajo.master.querymaster.SubQuery$InitAndRequestContainer.transition(SubQuery.java:636)
        at org.apache.tajo.master.querymaster.SubQuery$InitAndRequestContainer.transition(SubQuery.java:617)
        at org.apache.hadoop.yarn.state.StateMachineFactory$MultipleInternalArc.doTransition(StateMachineFactory.java:385)
        at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
        at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
        at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
        at org.apache.tajo.master.querymaster.SubQuery.handle(SubQuery.java:594)
        at org.apache.tajo.master.querymaster.Query$SubQueryCompletedTransition.executeNextBlock(Query.java:574)
        at org.apache.tajo.master.querymaster.Query$SubQueryCompletedTransition.transition(Query.java:607)
        at org.apache.tajo.master.querymaster.Query$SubQueryCompletedTransition.transition(Query.java:560)
        at org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362)
        at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
        at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
        at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
        at org.apache.tajo.master.querymaster.Query.handle(Query.java:660)
        at org.apache.tajo.master.querymaster.Query.handle(Query.java:58)
        at org.apache.tajo.master.TajoAsyncDispatcher.dispatch(TajoAsyncDispatcher.java:137)
        at org.apache.tajo.master.TajoAsyncDispatcher$1.run(TajoAsyncDispatcher.java:79)
        at java.lang.Thread.run(Thread.java:744)


Diffs
-----

  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/UniformRangePartition.java a7df3e8 
  tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestUniformRangePartition.java dc5108a 

Diff: https://reviews.apache.org/r/19677/diff/


Testing
-------

- mvn clean install

- order by query test using real data on a real cluster


Thanks,

Jihoon Son


Re: Review Request 19677: TAJO-713: Missing INET4 in UniformRangePartition

Posted by Jinho Kim <jh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19677/#review38882
-----------------------------------------------------------

Ship it!


+1 
Looks great for me. I've verified 'mvn clean install'.

- Jinho Kim


On March 26, 2014, 12:47 p.m., Jihoon Son wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19677/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 12:47 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-713
>     https://issues.apache.org/jira/browse/TAJO-713
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> Since the INET4 type is not handled properly, an error occurs with the following log.
> 
> 2014-03-26 18:16:34,978 ERROR querymaster.SubQuery (SubQuery.java:transition(652)) - SubQuery (eb_1395825278930_0001_000002) ERROR:
> java.lang.UnsupportedOperationException: type: INET4
>  is not supported yet
>         at org.apache.tajo.engine.planner.UniformRangePartition.increment(UniformRangePartition.java:411)
>         at org.apache.tajo.engine.planner.UniformRangePartition.partition(UniformRangePartition.java:104)
>         at org.apache.tajo.master.querymaster.Repartitioner.scheduleRangeShuffledFetches(Repartitioner.java:355)
>         at org.apache.tajo.master.querymaster.Repartitioner.scheduleFragmentsForNonLeafTasks(Repartitioner.java:301)
>         at org.apache.tajo.master.querymaster.SubQuery$InitAndRequestContainer.schedule(SubQuery.java:790)
>         at org.apache.tajo.master.querymaster.SubQuery$InitAndRequestContainer.transition(SubQuery.java:636)
>         at org.apache.tajo.master.querymaster.SubQuery$InitAndRequestContainer.transition(SubQuery.java:617)
>         at org.apache.hadoop.yarn.state.StateMachineFactory$MultipleInternalArc.doTransition(StateMachineFactory.java:385)
>         at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
>         at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
>         at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
>         at org.apache.tajo.master.querymaster.SubQuery.handle(SubQuery.java:594)
>         at org.apache.tajo.master.querymaster.Query$SubQueryCompletedTransition.executeNextBlock(Query.java:574)
>         at org.apache.tajo.master.querymaster.Query$SubQueryCompletedTransition.transition(Query.java:607)
>         at org.apache.tajo.master.querymaster.Query$SubQueryCompletedTransition.transition(Query.java:560)
>         at org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362)
>         at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
>         at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
>         at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
>         at org.apache.tajo.master.querymaster.Query.handle(Query.java:660)
>         at org.apache.tajo.master.querymaster.Query.handle(Query.java:58)
>         at org.apache.tajo.master.TajoAsyncDispatcher.dispatch(TajoAsyncDispatcher.java:137)
>         at org.apache.tajo.master.TajoAsyncDispatcher$1.run(TajoAsyncDispatcher.java:79)
>         at java.lang.Thread.run(Thread.java:744)
> 
> 
> Diffs
> -----
> 
>   tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/UniformRangePartition.java a7df3e8 
>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestUniformRangePartition.java dc5108a 
> 
> Diff: https://reviews.apache.org/r/19677/diff/
> 
> 
> Testing
> -------
> 
> - mvn clean install
> 
> - order by query test using real data on a real cluster
> 
> 
> Thanks,
> 
> Jihoon Son
> 
>