You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "YuangGao (via GitHub)" <gi...@apache.org> on 2026/06/02 04:43:31 UTC

[PR] feat(azure-storage): add missing setters for client secret and workload identity providers [opendal-reqsign]

YuangGao opened a new pull request, #764:
URL: https://github.com/apache/opendal-reqsign/pull/764

   ## Which issue does this PR close?
   
   - Closes #756.
   
   ## What changes are included in this PR?
   
   `ClientSecretCredentialProvider`:
   - Add `client_secret` and `authority_host` fields with corresponding setters.
   - `provide_credential` now reads `self.client_id` / `self.client_secret` / `self.authority_host` first, falling back to `AZURE_CLIENT_ID` / `AZURE_CLIENT_SECRET` / `AZURE_AUTHORITY_HOST`. Fixes `with_client_id` being a silent no-op.
   
   `WorkloadIdentityCredentialProvider`:
   - Add `client_id`, `federated_token_file`, and `authority_host` fields with corresponding setters.
   - `provide_credential` now reads each from `self` first, falling back to env vars. Fixes `with_tenant_id` being a silent no-op.
   
   Purely additive — all new fields default to `None`, so existing callers see no behavior change.
   
   ## Are there any user-facing changes?
   
   New builder API for downstream crates (opendal azdls/azblob in particular) to inject Azure OAuth2 credentials without resorting to `StaticEnv` fake-env workarounds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(azure-storage): add missing setters for client secret and workload identity providers [opendal-reqsign]

Posted by "YuangGao (via GitHub)" <gi...@apache.org>.
YuangGao closed pull request #764: feat(azure-storage): add missing setters for client secret and workload identity providers
URL: https://github.com/apache/opendal-reqsign/pull/764


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org