You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2024/06/05 12:13:04 UTC
[PR] Update the transform label error message [beam]
liferoad opened a new pull request, #31508:
URL: https://github.com/apache/beam/pull/31508
Now we surface `auto_unique_labels` in the error message when two PTransforms have the same labels.
Context: https://github.com/apache/beam/pull/28984
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31508:
URL: https://github.com/apache/beam/pull/31508#issuecomment-2149837532
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey merged PR #31508:
URL: https://github.com/apache/beam/pull/31508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #31508:
URL: https://github.com/apache/beam/pull/31508#issuecomment-2150930235
It can cause data loss for pipeline update.
Suppose one has (as a simplified example)
```
p | ReadFromPubSub(topic1) | SomeAnalysis() | WriteToPubSub(somewhere)
p | ReadFromPubSub(topic2) | SomeAnalysis() | WriteToPubSub(somewhere else)
```
If I modify the pipeline and remove the first line (and auto_unique_labels is set), the stages from the second line would now inherit the non-uniquified names that would collide with those of the first. Any state that was present in the first (now deleted) line would then get matched up and used in the updated pipeline as if it were part of the second. This includes in-flight messages (e.g. messages from `topic1` could get written to `somewhere else`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #31508:
URL: https://github.com/apache/beam/pull/31508#issuecomment-2150846345
> We should make sure we're clear about the downsides of `auto_unique_labels`.
what kind of downsides? random labels?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #31508:
URL: https://github.com/apache/beam/pull/31508#issuecomment-2150366503
We should make sure we're clear about the downsides of `auto_unique_labels`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #31508:
URL: https://github.com/apache/beam/pull/31508#issuecomment-2151107441
+1, filed https://github.com/apache/beam/issues/31523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #31508:
URL: https://github.com/apache/beam/pull/31508#issuecomment-2150936284
Also, even if you didn't update the pipeline and tried to re-load you'd loose the state (and in-flight messages) from the second line due to the unique nonce that gets added not lining up. (This was considered preferable to a deterministic counter which could give you many state collisions, e.g. 1->2, 2->3, 3->4, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the transform label error message [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #31508:
URL: https://github.com/apache/beam/pull/31508#issuecomment-2151100926
Got it. How about we update the doc here https://github.com/apache/beam/blob/master/sdks/python/apache_beam/options/pipeline_options.py#L553 for this option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org