You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "airstring (via GitHub)" <gi...@apache.org> on 2023/02/27 10:33:51 UTC

[GitHub] [apisix] airstring opened a new issue, #8954: help request:

airstring opened a new issue, #8954:
URL: https://github.com/apache/apisix/issues/8954

   ### Description
   
   [ec2-user@ip-10-10-6-22 ~]$ curl -i http://127.0.0.1:9180/apisix/admin/services/aslan-service2 -H 'X-API-KEY: fdd1c9f034335f13sdd84b625c8f81' -X PUT -d '{"name":"aslan-service2","desc":"xx company","plugins":{"limit-count":{"count":5,"time_window":86400,"rejected_code":403,"rejected_msg":"date limit","key_type":"constant","key":"aslan","group":"aslan-group","policy":"redis","redis_host":"redis.example.com","redis_port":6379}}}'
   HTTP/1.1 200 OK
   Date: Mon, 27 Feb 2023 10:04:07 GMT
   Content-Type: application/json
   Transfer-Encoding: chunked
   Connection: keep-alive
   Server: APISIX/3.1.0
   Access-Control-Allow-Origin: *
   Access-Control-Allow-Credentials: true
   Access-Control-Expose-Headers: *
   Access-Control-Max-Age: 3600
   X-API-VERSION: v3
   
   {"key":"\/apisix\/services\/aslan-service2","value":{"plugins":{"limit-count":{"policy":"redis","time_window":86400,"key_type":"constant","group":"aslan-group","rejected_code":403,"rejected_msg":"date limit","count":5,"redis_timeout":1000,"key":"aslan","show_limit_quota_header":true,"redis_host":"redis.example.com","allow_degradation":false,"redis_port":6379,"redis_database":0}},"update_time":1677492247,"create_time":1677491610,"name":"aslan-service2","desc":"xx company","id":"aslan-service2"}}
   
   [ec2-user@ip-10-10-6-22 ~]$ curl -i http://127.0.0.1:9180/apisix/admin/services/aslan-service2 -H 'X-API-KEY: fdd1c9f034335f13sdd84b625c8f81' -X PUT -d '{"name":"aslan-service2","desc":"xx company","plugins":{"limit-count":{"count":50,"time_window":86400,"rejected_code":403,"rejected_msg":"date limit","key_type":"constant","key":"aslan","group":"aslan-group","policy":"redis","redis_host":"redis.example.com","redis_port":6379}}}'
   HTTP/1.1 400 Bad Request
   Date: Mon, 27 Feb 2023 10:05:13 GMT
   Content-Type: application/json
   Transfer-Encoding: chunked
   Connection: keep-alive
   Server: APISIX/3.1.0
   Access-Control-Allow-Origin: *
   Access-Control-Allow-Credentials: true
   Access-Control-Expose-Headers: *
   Access-Control-Max-Age: 3600
   X-API-VERSION: v3
   
   {"error_msg":"failed to check the configuration of plugin limit-count err: group conf mismatched"}
   
   ### Environment
   
   - APISIX version (run `apisix version`):
   - Operating system (run `uname -a`):
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] shreemaan-abhishek commented on issue #8954: help request: Can't me change service once it's set ?

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #8954:
URL: https://github.com/apache/apisix/issues/8954#issuecomment-1449344442

   It looks like you are updating the plugin configuration and by implementation, this is disallowed:
   
   https://github.com/apache/apisix/blob/789e1222f543431aa9844ce66c33203f008d63e7/apisix/plugins/limit-count/init.lua#L177-L187
   
   Not sure if this is a bug or feature.
   
   cc: @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] kingluo closed issue #8954: help request: Can't me change service once it's set ?

Posted by "kingluo (via GitHub)" <gi...@apache.org>.
kingluo closed issue #8954: help request: Can't me change service once it's set ?
URL: https://github.com/apache/apisix/issues/8954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] spacewander commented on issue #8954: help request: Can't me change service once it's set ?

Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on issue #8954:
URL: https://github.com/apache/apisix/issues/8954#issuecomment-1451171152

   It's expected.
   
   https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/limit-count.md
   > The configuration of limit-count in the same group must be consistent. If you want to change the configuration, you need to update the value of the corresponding group at the same time.
   
   It is the limitation of the current group implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] shreemaan-abhishek commented on issue #8954: help request: Can't me change service once it's set ?

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #8954:
URL: https://github.com/apache/apisix/issues/8954#issuecomment-1449348386

   @airstring I would highly recommend you to share any relevant information with proper formatting it makes it very easy for maintainers (who are usually busy) to help with your issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] shreemaan-abhishek commented on issue #8954: help request: Can't me change service once it's set ?

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #8954:
URL: https://github.com/apache/apisix/issues/8954#issuecomment-1449283901

   Let me take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org