[GitHub] [cassandra] Claudenw commented on a diff in pull request #2004: sstabledump errors when dumping data from index for CASSANDRA-17698

[GitBox <gi...@apache.org>]

Claudenw commented on code in PR #2004:
URL: https://github.com/apache/cassandra/pull/2004#discussion_r1020126001


##########
src/java/org/apache/cassandra/index/internal/CassandraIndexFunctions.java:
##########
@@ -51,6 +59,8 @@ default AbstractType<?> getIndexedValueType(ColumnMetadata indexedColumn)
         return indexedColumn.type;
     }
 
+    public AbstractType<?> getIndexedPartitionKeyType(ColumnMetadata indexedColumn);

Review Comment:
   Add a default implementation for the standard cases and only override when the return values i not indexedColumn.type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org