[jira] Closed: (TAPESTRY-2351) Expansions ${...} does not work inside html comments.

["Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>]

     [ https://issues.apache.org/jira/browse/TAPESTRY-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAPESTRY-2351.
------------------------------------------

    Resolution: Won't Fix
      Assignee: Howard M. Lewis Ship

Expansions inside comments is the wrong solution to the problem.

You should create an IEConditional components, with usage:

<t:ieconditonal version="7" stylesheet="${mediaUrl}/css/ie.css"/>

This ends up being, maybe 5 lines of Java code to implements.  

> Expansions ${...} does not work inside html comments.
> -----------------------------------------------------
>
>                 Key: TAPESTRY-2351
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2351
>             Project: Tapestry
>          Issue Type: Bug
>    Affects Versions: 5.0.11
>            Reporter: Igor E. Poteryaev
>            Assignee: Howard M. Lewis Ship
>
> There is use case for variable expansions to work for inside html comments.
> Internet Explorer "Conditional comments" described here:
> http://msdn2.microsoft.com/en-us/library/ms537512(VS.85).aspx
> We want to this snippet to isolate all IE css quirks/hacks in IE-only files:
> <head>
> <title>${customerTitle}</title>
> <link href="${mediaUrl}/css/common.css" rel="stylesheet" type="text/css" />
> <!--[if lte IE 7]><link href="${mediaUrl}/css/ie.css" rel="stylesheet" type="text/css" /><![endif]-->
> <!--[if lte IE 6]><link href="${mediaUrl}/css/ie6.css" rel="stylesheet" type="text/css" /><![endif]-->
> </head>
> mediaUrl variable is correctly expanded for the first <link>, but not for <link>s inside html comments.
> It is important for us to can use IE  "Conditional comments".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org