You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/11 05:41:36 UTC
[GitHub] [spark] c21 opened a new pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
c21 opened a new pull request #29724:
URL: https://github.com/apache/spark/pull/29724
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Several minor code and documentation improvement for stream-stream join. Specifically:
* Remove extending from `SparkPlan`, as extending from `BinaryExecNode` is enough.
* Return `left/right.outputPartitioning` for `Left/RightOuter` in `outputPartitioning`, as the `PartitioningCollection` wrapper is unnecessary (similar to batch joins `ShuffledHashJoinExec`, `SortMergeJoinExec`).
* Avoid per-row check for join type (https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala#L486-L492), by creating the method before the loop of reading rows (`generateFilteredJoinedRow` in `storeAndJoinWithOtherSide`). Similar optimization (i.e. create auxiliary method/variable per different join type before the iterator of input rows) has been done in batch join world (`SortMergeJoinExec`, `ShuffledHashJoinExec`).
* Minor fix for comment/indentation for better readability.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Minor optimization to avoid per-row unnecessary work (this probably can be optimized away by compiler, but we can do a better join to avoid it at the first place). And other comment/indentation fix to have better code readability for future developers.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests in `StreamingJoinSuite.scala` as no new logic is introduced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487250765
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487206481
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486837991
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487229420
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487255626
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691066506
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487229420
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486993687
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486837991
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487206481
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486840286
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690920318
**[Test build #128556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128556/testReport)** for PR 29724 at commit [`069ad73`](https://github.com/apache/spark/commit/069ad73da7197a5db82b3d2d3fbf515f11bae6f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690887740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691241906
**[Test build #128578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128578/testReport)** for PR 29724 at commit [`cfd9cc0`](https://github.com/apache/spark/commit/cfd9cc0cdc0c319da6bf10e95e5dc74d7dbb6266).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889136
**[Test build #128552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128552/testReport)** for PR 29724 at commit [`069ad73`](https://github.com/apache/spark/commit/069ad73da7197a5db82b3d2d3fbf515f11bae6f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690917710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691241906
**[Test build #128578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128578/testReport)** for PR 29724 at commit [`cfd9cc0`](https://github.com/apache/spark/commit/cfd9cc0cdc0c319da6bf10e95e5dc74d7dbb6266).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486837991
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486993687
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691242500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29724:
URL: https://github.com/apache/spark/pull/29724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691065454
**[Test build #128556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128556/testReport)** for PR 29724 at commit [`069ad73`](https://github.com/apache/spark/commit/069ad73da7197a5db82b3d2d3fbf515f11bae6f6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691349096
**[Test build #128578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128578/testReport)** for PR 29724 at commit [`cfd9cc0`](https://github.com/apache/spark/commit/cfd9cc0cdc0c319da6bf10e95e5dc74d7dbb6266).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-692184842
Thank you @cloud-fan , @HeartSaVioR and @xuanyuanking for review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486993687
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
The comment seems to be just modified for replacing `leftJoiner.joinWith(rightJoiner)` with `leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for right side. Other parts aren't modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690920318
**[Test build #128556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128556/testReport)** for PR 29724 at commit [`069ad73`](https://github.com/apache/spark/commit/069ad73da7197a5db82b3d2d3fbf515f11bae6f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690917366
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690916887
**[Test build #128552 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128552/testReport)** for PR 29724 at commit [`069ad73`](https://github.com/apache/spark/commit/069ad73da7197a5db82b3d2d3fbf515f11bae6f6).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889136
**[Test build #128552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128552/testReport)** for PR 29724 at commit [`069ad73`](https://github.com/apache/spark/commit/069ad73da7197a5db82b3d2d3fbf515f11bae6f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690917362
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691242500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691284297
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691361728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691349550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691361410
**[Test build #128580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128580/testReport)** for PR 29724 at commit [`ed800ee`](https://github.com/apache/spark/commit/ed800ee41814eabf9fb1f00ee79092ff2c2fa34b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690917369
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128552/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691915645
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690887740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691284297
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691283703
**[Test build #128580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128580/testReport)** for PR 29724 at commit [`ed800ee`](https://github.com/apache/spark/commit/ed800ee41814eabf9fb1f00ee79092ff2c2fa34b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690887740
cc @cloud-fan and @sameeragarwal if you have time to take a look, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691785756
Addressed all comments and tests are passed. Let me know if anything needs to be changed, thanks, @cloud-fan .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486837991
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
`uses the watermark to figure out`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I'm not familiar with this part, cc @zsxwing @HeartSaVioR @xuanyuanking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691361728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690917362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691066506
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690917710
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487229420
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Nich catch,
nit: let's remove the duplicate error string in https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR168 and https://github.com/apache/spark/pull/29724/files#diff-e9db271d8593f070ba7096e758c8b89dR162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
I think the original PR just wants to use pseudocode to explain, either way is ok to me.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
Yes, have a string val for the same error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691349550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-691283703
**[Test build #128580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128580/testReport)** for PR 29724 at commit [`ed800ee`](https://github.com/apache/spark/commit/ed800ee41814eabf9fb1f00ee79092ff2c2fa34b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29724:
URL: https://github.com/apache/spark/pull/29724#issuecomment-690889136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487249765
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #29724: [SPARK-32854][SS] Minor code and doc improvement for stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487206481
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -56,8 +56,8 @@ import org.apache.spark.util.{CompletionIterator, SerializableConfiguration}
* - Apply the optional condition to filter the joined rows as the final output.
*
* If a timestamp column with event time watermark is present in the join keys or in the input
- * data, then the it uses the watermark figure out which rows in the buffer will not join with
- * and the new data, and therefore can be discarded. Depending on the provided query conditions, we
+ * data, then it uses the watermark figure out which rows in the buffer will not join with
Review comment:
@cloud-fan - updated.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching new left input with
Review comment:
@cloud-fan , @HeartSaVioR - yes, this is just updating the comment, because there's no `leftJoiner`/`rightJoiner`/`joinWith` in the file, and the original author (https://github.com/apache/spark/pull/19271) should mean to refer to `leftSideJoiner`/`rightSideJoiner`/`storeAndJoinWithOtherSide`. I think it would make sense to be consistent between code and comment here. This is anyway a minor change for comment only.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting to have a string val for error message to be used in `throwBadJoinTypeException ` and `require(...)`: `val errorMessageForJoinType = s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or something else?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning, right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sure, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org