You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "zhoujinsong (via GitHub)" <gi...@apache.org> on 2024/09/11 07:26:10 UTC
Re: [PR] [AMORO-3111]Avoid optimization state blocking in planning [amoro]
zhoujinsong commented on code in PR #3115:
URL: https://github.com/apache/amoro/pull/3115#discussion_r1753379193
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -299,7 +299,7 @@ public class AmoroManagementConf {
public static final ConfigOption<Long> DB_CONNECT_MAX_WAIT_MILLIS =
ConfigOptions.key("database.connection-pool-max-wait-millis")
.longType()
- .defaultValue(1000L)
+ .defaultValue(-1L)
Review Comment:
We may need to roll back the change here.
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/table/TableRuntime.java:
##########
@@ -188,13 +188,21 @@ public void beginPlanning() {
}
public void planFailed() {
- invokeConsistency(
- () -> {
- OptimizingStatus originalStatus = optimizingStatus;
- updateOptimizingStatus(OptimizingStatus.PENDING);
- persistUpdatingRuntime();
- tableHandler.handleTableChanged(this, originalStatus);
- });
+ try {
+ invokeConsistency(
+ () -> {
+ OptimizingStatus originalStatus = optimizingStatus;
+ updateOptimizingStatus(OptimizingStatus.PENDING);
+ persistUpdatingRuntime();
+ tableHandler.handleTableChanged(this, originalStatus);
+ });
+ } catch (Exception e) {
+ OptimizingStatus originalStatus = optimizingStatus;
+ updateOptimizingStatus(OptimizingStatus.PENDING);
+ LOG.error(
Review Comment:
Warn logging level may be proper here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org