You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/22 11:25:41 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request #6027: prevent - handler from from toggling checkboxes

DaanHoogland opened a new pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027


   ### Description
   
   This PR...
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   Fixes: #6017
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048542435


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047702171


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047881748


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6027 (SL-JID-1175)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048547547






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048542286


   I reverted the generic change and limited to the register template form. I'm sure more of these issues will come up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#discussion_r812754381



##########
File path: ui/src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -16,15 +16,16 @@
 // under the License.
 
 <template>
-  <div class="form-layout">
+  <div
+    class="form-layout"
+    @keyup.ctrl.enter="handleSubmit">
     <span v-if="uploadPercentage > 0">
       <a-icon type="loading" />
       {{ $t('message.upload.file.processing') }}
       <a-progress :percent="uploadPercentage" />
     </span>
     <a-spin :spinning="loading" v-else>
       <a-form
-        v-ctrl-enter="handleSubmit"

Review comment:
       I am working on that, but the RegisterOrUploadIso doesn't use `a-check`s but `a-switch`s, which work differently. these will not accept the  `space` event. I think we should merge like this and handle the rest when we encounter it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047876015


   @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047885474


   @utchoang can you advice if there is a better generic solution to handling keyboard navigation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048547547


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6027 (SL-JID-1180)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#discussion_r812734295



##########
File path: ui/src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -16,15 +16,16 @@
 // under the License.
 
 <template>
-  <div class="form-layout">
+  <div
+    class="form-layout"
+    @keyup.ctrl.enter="handleSubmit">
     <span v-if="uploadPercentage > 0">
       <a-icon type="loading" />
       {{ $t('message.upload.file.processing') }}
       <a-progress :percent="uploadPercentage" />
     </span>
     <a-spin :spinning="loading" v-else>
       <a-form
-        v-ctrl-enter="handleSubmit"

Review comment:
       ok, is the same change required in _RegisterOrUploadIso.vue_




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti merged pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#discussion_r812703466



##########
File path: ui/src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -16,15 +16,16 @@
 // under the License.
 
 <template>
-  <div class="form-layout">
+  <div
+    class="form-layout"
+    @keyup.ctrl.enter="handleSubmit">
     <span v-if="uploadPercentage > 0">
       <a-icon type="loading" />
       {{ $t('message.upload.file.processing') }}
       <a-progress :percent="uploadPercentage" />
     </span>
     <a-spin :spinning="loading" v-else>
       <a-form
-        v-ctrl-enter="handleSubmit"

Review comment:
       yes, this is the one obfuscating the `space` event. that's why it was moved to the `div` element




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048778513


   Manually tested the forms for 'Register template', 'Create Network Offering', 'Create VPC offering' forms. LGTM
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048542435


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048754774


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6027 (SL-JID-1182)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047705830






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047705830


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6027 (SL-JID-1174)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048748959


   > LGTM. There are a few other forms where we have checkboxes that are effected which include:
   > 
   >     * Create Network Offering
   > 
   >     * Create VPC offering
   > 
   >     * Assign LB rule to VM
   >       However, we can address these in 4.17 too.
   
   tnx @Pearl, added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048543030


   @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047875146


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#discussion_r812667582



##########
File path: ui/src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -16,15 +16,16 @@
 // under the License.
 
 <template>
-  <div class="form-layout">
+  <div
+    class="form-layout"
+    @keyup.ctrl.enter="handleSubmit">
     <span v-if="uploadPercentage > 0">
       <a-icon type="loading" />
       {{ $t('message.upload.file.processing') }}
       <a-progress :percent="uploadPercentage" />
     </span>
     <a-spin :spinning="loading" v-else>
       <a-form
-        v-ctrl-enter="handleSubmit"

Review comment:
       @DaanHoogland Should we remove here as well ?
   
   https://github.com/apache/cloudstack/blob/1a47cc3c954ded8db7afdc8a0154929ae54c6c48/ui/src/views/image/RegisterOrUploadIso.vue#L29




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047876015






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048750058


   @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047875146


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1048749154


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #6027: prevent - handler from from toggling checkboxes

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6027:
URL: https://github.com/apache/cloudstack/pull/6027#issuecomment-1047701457


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org