You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/04 02:15:18 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #4068: Adding Centos8 Support

davidjumani opened a new pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068


   This adds support for CentOS8 packaging. The first would be to support CentOS8 as KVM host, and then as mgmt+usage server host.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664162849


   <b>Trillian test result (tid-2173)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 326853 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2173-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 36 look OK, 47 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 3677.22 | test_accounts.py
   test_DeleteDomain | `Error` | 2696.39 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 3674.46 | test_accounts.py
   test_forceDeleteDomain | `Error` | 4050.28 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 2694.18 | test_accounts.py
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 3675.34 | test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 2689.20 | test_async_job.py
   test_07_deploy_vm_with_extraconfig_xenserver | `Error` | 3674.65 | test_deploy_vm_extra_config_data.py
   test_deploy_vm_from_iso | `Error` | 3680.32 | test_deploy_vm_iso.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 1348.14 | test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 1356.17 | test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 1353.08 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 1355.13 | test_internal_lb.py
   test_00_deploy_vm_root_resize | `Error` | 3674.15 | test_deploy_vm_root_resize.py
   test_deployvm_firstfit | `Error` | 2699.40 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userconcentrated | `Error` | 2701.59 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdispersing | `Error` | 2727.91 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdata | `Error` | 2711.61 | test_deploy_vm_with_userdata.py
   test_deployvm_userdata_post | `Error` | 2690.50 | test_deploy_vm_with_userdata.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   test_03_deploy_vm_domain_service_offering | `Error` | 3679.88 | test_domain_service_offerings.py
   test_03_create_vpc_domain_vpc_offering | `Error` | 1359.14 | test_domain_vpc_offerings.py
   test_01_deploy_kubernetes_cluster | `Error` | 1361.02 | test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 1362.08 | test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 1353.43 | test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 1354.31 | test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 1353.47 | test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 1348.14 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 1384.04 | test_kubernetes_clusters.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
   test_list_vms_metrics | `Error` | 3680.12 | test_metrics_api.py
   test_nic_secondaryip_add_remove | `Error` | 2710.16 | test_multipleips_per_nic.py
   test_network_acl | `Error` | 1345.82 | test_network_acl.py
   test_delete_account | `Error` | 3697.48 | test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 2754.12 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 2690.24 | test_network.py
   test_reboot_router | `Error` | 2691.00 | test_network.py
   test_releaseIP | `Error` | 3680.33 | test_network.py
   ContextSuite context=TestRouterRules>:setup | `Error` | 6382.61 | test_network.py
   test_01_nic | `Error` | 2713.93 | test_nic.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
   test_01_create_delete_portforwarding_fornonvpc | `Error` | 2693.45 | test_portforwardingrules.py
   test_01_add_primary_storage_disabled_host | `Error` | 15.25 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.18 | test_primary_storage.py
   test_01_vpc_privategw_acl | `Failure` | 1344.86 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 1343.11 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1344.42 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1345.17 | test_privategw_acl.py
   test_09_project_suspend | `Error` | 2686.50 | test_projects.py
   test_10_project_activation | `Error` | 2685.31 | test_projects.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
   test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 1513.12 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.49 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.53 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.41 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.45 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 1.92 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_deploy_vm_on_specific_host | `Error` | 1344.82 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 1342.56 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 1343.51 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1342.62 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 1344.54 | test_vm_deployment_planner.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=TestChangeServiceOfferingForVmWithSnapshots>:setup | `Error` | 0.00 | test_vm_snapshots.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.00 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-666338423


   <b>Trillian test result (tid-2236)</b>
   Environment: xcpng81 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 58015 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2236-xcpng81.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 5.35 | test_scale_vm.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 567.46 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3985.41 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655187632


   <b>Trillian test result (tid-2017)</b>
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 49184 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2017-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_06_download_detached_volume | `Error` | 16.37 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 435.38 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 348.58 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3903.57 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652913875


   Packaging result: ✖centos7 ✔debian. JID-1505


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-639175912


   Packaging result: ✖centos7 ✔debian. JID-1295


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664193373


   <b>Trillian test result (tid-2172)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 331460 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2172-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 36 look OK, 47 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-663793957


   <b>Trillian test result (tid-2178)</b>
   Environment: xcpng81 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 63053 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2178-xcpng81.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 80 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 6.19 | test_scale_vm.py
   test_01_volume_usage | `Error` | 97.78 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 853.00 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 4054.18 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-666122882


   <b>Trillian test result (tid-2225)</b>
   Environment: xcpng81 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 72944 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2225-xcpng81.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 7.27 | test_scale_vm.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 758.76 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 4113.86 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662957891


   @blueorangutan test centos8 xcpng81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664215792


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-648832546


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662244005


   @blueorangutan test centos8 xcpng81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654643052


   Packaging result: ✔centos7 ✔debian. JID-1540


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662959386


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xcpng81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655810252


   <b>Trillian test result (tid-2035)</b>
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 43356 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2035-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_kubernetes_cluster | `Error` | 3619.74 | test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 0.06 | test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 130.26 | test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 35.80 | test_kubernetes_clusters.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668450008


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649534053


   @blueorangutan test centos7 xenserver-71


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664626019


   > @weizhouapache - related to the Ubuntu 20 changes (your original PR was closed, and Rohit cherry-picked the changes to this PR) - please feel free to test Ubuntu 20 specifically (i.e. for the moment, we are not testing Ubuntu 20 as part of this PR). Thx
   
   @andrijapanicsb ok.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-642537273


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674813062


   Thanks @andrijapanicsb @borisstoyanov - agree failing tests are all intermittent failures. Merging this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-647031753


   @davidjumani I see a lot of tabs for indentation and also mixed tab/space indentation. did you check this with a python linter? Also I saw some changes in the way indentation is done. Are these tested?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r446268733



##########
File path: debian/rules
##########
@@ -6,7 +6,8 @@ SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
 %:
-	dh $@ --with python2,systemd
+	# TODO : Make it work with python2 also

Review comment:
       Does this needs update?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649518982


   @blueorangutan test centos7 xcpng-81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674336158


   <b>Trillian test result (tid-2450)</b>
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 52615 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2450-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 82 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1807.51 | test_kubernetes_supported_versions.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 430.26 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3922.06 | test_vpc_redundant.py
   test_hostha_kvm_host_fencing | `Error` | 170.85 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654642563


   Packaging kicked at backend


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649531025


   @blueorangutan test centos7 xcpng80


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438670969



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -14,38 +14,44 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from utilities import writeProgressBar, bash
-from cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
+from .utilities import writeProgressBar, bash
+from .cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
 import logging
-from networkConfig import networkConfig
+from .networkConfig import networkConfig
 import re
-from configFileOps import configFileOps
+from .configFileOps import configFileOps
 import os
 import shutil
 
 # exit() error constants
 Unknown = 0
 CentOS6 = 1
 CentOS7 = 2
-Ubuntu = 3
-RHEL6 = 4
-RHEL7 = 5
+CentOS8 = 3

Review comment:
       Does changing these constants cause any error?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644544024


   Packaging result: ✔centos7 ✖debian. JID-1382


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644575288


   Packaging result: ✔centos7 ✔debian. JID-1392


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655351990


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653393443


   <b>Trillian test result (tid-1951)</b>
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 55552 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1951-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 73 look OK, 10 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_query_async_job_result | `Failure` | 71.25 | test_async_job.py
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 46.87 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 155.31 | test_deploy_vm_extra_config_data.py
   test_07_deploy_and_scale_kubernetes_cluster | `Failure` | 516.07 | test_kubernetes_clusters.py
   test_oobm_background_powerstate_sync | `Failure` | 21.63 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 29.64 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 19.66 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 18.62 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 18.64 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 19.71 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 19.64 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 19.66 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.45 | test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 7.32 | test_outofbandmanagement.py
   test_isolate_network_password_server | `Failure` | 12.09 | test_password_server.py
   test_router_dhcphosts | `Failure` | 12.22 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 23.57 | test_router_dhcphosts.py
   test_11_migrate_vm | `Error` | 45.80 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 85.07 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Error` | 9.37 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 373.69 | test_vpc_redundant.py
   test_hostha_kvm_host_degraded | `Error` | 8.67 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 9.78 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 9.68 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-648748044


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654621649


   @shwstppr can you review XCP-ng 8.1 failures and kick packaging/test again; let me know for any assistance. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-651853600


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668400542


   @davidjumani can you address outstanding comments when you're back from Primate work, thnx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649533380


   @blueorangutan test centos7 xcpng76


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655371266


   @shwstppr please kick test from jenkins for the centos8mgmt server + centos8 kvm host combination.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655352521


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655371422


   I'll kick test for centos7+centos7 kvm combination
   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r447403280



##########
File path: packaging/centos7/cloud.spec
##########
@@ -279,6 +280,11 @@ install -D server/target/conf/cloudstack-sudoers ${RPM_BUILD_ROOT}%{_sysconfdir}
 touch ${RPM_BUILD_ROOT}%{_localstatedir}/run/%{name}-management.pid
 #install -D server/target/conf/cloudstack-catalina.logrotate ${RPM_BUILD_ROOT}%{_sysconfdir}/logrotate.d/%{name}-catalina
 
+# Package mysql-connector-python
+wget -P ${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/setup/wheel https://files.pythonhosted.org/packages/ee/ff/48bde5c0f013094d729fe4b0316ba2a24774b3ff1c52d924a8a4cb04078a/six-1.15.0-py2.py3-none-any.whl
+wget -P ${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/setup/wheel https://files.pythonhosted.org/packages/28/05/9867ef8eafd12265267bee138fa2c46ebf34a276ea4cbe184cba4c606e8b/protobuf-3.12.2-cp36-cp36m-manylinux1_x86_64.whl
+wget -P ${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/setup/wheel https://files.pythonhosted.org/packages/d1/53/4cf90d2fe81b9cdb55dc180951bcec44ea8685665f1bdb1412501dc362dd/mysql_connector_python-8.0.20-cp36-cp36m-manylinux1_x86_64.whl
+

Review comment:
       @andrijapanicsb discussed regarding this. We will have to change links once they become unavailable else we won't be able to package python-mysql-connector and it will have to be installed from mysql repo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644527187


   @shwstppr @davidjumani good work both! Please keep it as a draft until testing validates, thanks cc @borisstoyanov @vladimirpetrov
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643071719


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-648747566


   @andrijapanicsb moved/clubed in this PR
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649521306


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xcpng81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r447403649



##########
File path: scripts/vm/hypervisor/xenserver/vmops
##########
@@ -162,7 +162,7 @@ def setLinkLocalIP(session, args):
 
         if result.lower().strip() == "bridge":
             try:
-                cmd = ["brctl", "addbr", brName]
+                cmd = ["ip", "link", "add", "name", brName, "type", "bridge"]

Review comment:
       Though both work. I've reverted the change




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673934059


   Manually rekicked env.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649902270


   <b>Trillian test result (tid-1852)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43186 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1852-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 11.38 | test_scale_vm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-650757013


   @blueorangutan test centos7 xcpng76
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-724601776


   Management server with Ubuntu 20.04 - LGTM, here is what I've tested:
   
   * VM network - add/delete secondary IP, change IP address, change default NIC, add/remove NIC
   * Guest networks - create/remove/restart with clean up isolated, L2 and shared network, add/remove egress, firewall and port-forwarding rules
   * Images - register/delete ISO, register/delete template, 
   * Volumes - create, attach/detach, migrate, create/restore snapshot, create template from volume, download volume, resize, delete
   * System VMs operations - start/stop, reboot, migrate, get diag. data, run diagnostics, destroy
   * Storages - add/remove primary and secondary storages


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-724606676


   (same goes for CentOS 8, had to upgrade to Elrepo 5.8+ kernel to solve the same issues)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664596982






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-651538787


   Packaging result: ✔centos7 ✔debian. JID-1487


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654106669


   Manually kicked a test against XCP-ng 8.1 let's see cc @shwstppr 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-651852791


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653016727


   Packaging result: ✔centos7 ✔debian. JID-1513


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644527511


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r428631368



##########
File path: python/bindir/cloud-grab-dependent-library-versions
##########
@@ -27,7 +27,7 @@ def runCmd(cmds):
     stdout, stderr = process.communicate()
     if process.returncode != 0:
         raise Exception(stderr)
-    return stdout
+    return stdout.decode('utf-8')

Review comment:
       On depLibraries I think that it would be necessary also to add python3.
   
   depLibraries = ['python', 'pythom3', ...]




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-639166680


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-640316222


   @shwstppr @davidjumani can you fix/pull the change from https://github.com/apache/cloudstack/pull/4094 (I'll close #4094 once that snasphot issue has been addressed in this PR)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649532591


   @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng80, xcpng81`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673914716


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438693387



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -14,38 +14,44 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from utilities import writeProgressBar, bash
-from cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
+from .utilities import writeProgressBar, bash
+from .cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
 import logging
-from networkConfig import networkConfig
+from .networkConfig import networkConfig
 import re
-from configFileOps import configFileOps
+from .configFileOps import configFileOps
 import os
 import shutil
 
 # exit() error constants
 Unknown = 0
 CentOS6 = 1
 CentOS7 = 2
-Ubuntu = 3
-RHEL6 = 4
-RHEL7 = 5
+CentOS8 = 3
+Ubuntu = 4
+RHEL6 = 5
+RHEL7 = 6
+RHEL8 = 7
 distro = None
 
 #=================== DISTRIBUTION DETECTION =================
 if os.path.exists("/etc/centos-release"):
-    version = file("/etc/centos-release").readline()
+    version = open("/etc/centos-release").readline()
     if version.find("CentOS release 6") != -1:
       distro = CentOS6
     elif version.find("CentOS Linux release 7") != -1:
       distro = CentOS7
+    elif version.find("CentOS Linux release 8") != -1:
+      distro = CentOS8
 elif os.path.exists("/etc/redhat-release"):
-    version = file("/etc/redhat-release").readline()
+    version = open("/etc/redhat-release").readline()
     if version.find("Red Hat Enterprise Linux Server release 6") != -1:
       distro = RHEL6
     elif version.find("Red Hat Enterprise Linux Server 7") != -1:
       distro = RHEL7
-elif os.path.exists("/etc/lsb-release") and "Ubuntu" in file("/etc/lsb-release").read(-1): distro = Ubuntu
+    elif version.find("Red Hat Enterprise Linux Server 8") != -1:

Review comment:
       @rhtyd extrapolating cc @davidjumani 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672705835


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673992651


   @vladimirpetrov a Trillian-Jenkins test job (centos8 mgmt + kvm-centos8) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-650045975


   Packaging result: ✔centos7 ✔debian. JID-1468


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671434990


   Packaging result: ✖centos7 ✖debian. JID-1698


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-665762139


   The failed test in this last env, the "test_01_redundant_vpc_site2site_vpn" from the "test_vpc_vpn.py" is passing fine when repeated manually (via margin) - i.e. intermittent failures, just like the other failing tests i.e. "test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL" and "test_05_rvpc_multi_tiers" from the "test_vpc_redundant.py" tests - sometimes they would pass, sometimes will fail - I've opened a new issue to ask dev community to address these not-robust-enough tests -  https://github.com/apache/cloudstack/issues/4224
   
   AS far as XCP-ng 8.x testing goes, this PR looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr edited a comment on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-631402758


   > nmcli conn show --active                                                           
   > nmcli conn add type bridge autoconnect yes con-name cloudbr0 ifname cloudbr0                                                                                            
   > nmcli conn modify cloudbr0 ipv4.addresses '172.20.1.10/16'                         
   > nmcli conn modify cloudbr0 ipv4.gateway '172.20.0.1'                               
   > nmcli conn modify cloudbr0 ipv4.dns '8.8.8.8'                                      
   > nmcli conn modify cloudbr0 ipv4.method manual                                      
   > nmcli conn add type ethernet slave-type bridge con-name bridge-cloudbr0 ifname eth0 master cloudbr0
   > nmcli conn add type bridge-slave ifname eth0 master cloudbr0                       
   > nmcli conn up cloudbr0
   
   nmcli commands that worked for me,
   ```
   nmcli conn show --active
   nmcli conn add type bridge autoconnect yes con-name cloudbr0 ifname cloudbr0
   nmcli conn modify cloudbr0 ipv4.addresses '172.20.1.10/16'
   nmcli conn modify cloudbr0 ipv4.gateway '172.20.0.1'
   nmcli conn modify cloudbr0 ipv4.dns '8.8.8.8'
   nmcli conn modify cloudbr0 ipv4.method manual
   nmcli connection delete enp1s0
   nmcli connection add type bridge-slave autoconnect yes con-name enp1s0 ifname enp1s0 master cloudbr0                     
   nmcli conn up cloudbr0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-642566804


   Packaging result: ✖centos7 ✖debian. JID-1342


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649534343


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662957282


   @blueorangutan test centos8 xenserver-71


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438670233



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -566,6 +572,12 @@ def setupLiveMigration(self):
         elif os.path.exists("/etc/default/libvirtd"):
             cfo = configFileOps("/etc/default/libvirtd", self)
             cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'")
+            if os.path.exists("/lib/systemd/system/libvirtd.socket"):

Review comment:
       This LGTM for newer Ubuntus




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-631057352


   Packaging result: ✖centos7 ✔debian. JID-1233


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-648759380


   Packaging result: ✔centos7 ✔debian. JID-1446


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662243866


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655222575


   <b>Trillian test result (tid-2018)</b>
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 54558 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2018-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_06_download_detached_volume | `Error` | 14.30 | test_volumes.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 382.36 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3900.75 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662958966


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xcpng80) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-661744386


   @blueorangutan help


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-650051496


   are we done with the changes here @shwstppr - i.e. is it good for review/testing now?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652648870


   Packaging result: ✔centos7 ✔debian. JID-1500


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672714252


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673404689


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438670528



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -343,7 +349,7 @@ def config(self):
             cfo.addEntry("NOZEROCONF", "yes")
             cfo.save()
 
-            if not bash("service network restart").isSuccess():
+            if not bash("systemctl restart NetworkManager.service").isSuccess():

Review comment:
       @davidjumani @shwstppr Check if this is true for distros applicable? Usually `systemctl restart network` works




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664333020


   @andrijapanicsb `test_01_volume_usage` failure here https://github.com/apache/cloudstack/pull/4068#issuecomment-663793957 seems intermittent. Tried running the test manually. In the failure though VM is created with Macchinina but it still showed PV template error from XCP-ng end.
   
   ```
   [root@pr4068-t2200-xcpng81-marvin marvin]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./pr4068-t2200-xcpng81-advanced-cfg -s -a tags=advanced --hypervisor=Xenserver tests/smoke/test_usage.py 
   
   ==== Marvin Init Started ====
   
   === Marvin Parse Config Successful ===
   
   === Marvin Setting TestData Successful===
   
   ==== Log Folder Path: /marvin/MarvinLogs/Jul_27_2020_10_43_34_NTMACM. All logs will be available here ====
   
   === Marvin Init Logging Successful===
   
   ==== Marvin Init Successful ====
   === TestName: test_01_ISO_usage | Status : SUCCESS ===
   
   === TestName: test_01_lb_usage | Status : SUCCESS ===
   
   === TestName: test_01_nat_usage | Status : SUCCESS ===
   
   === TestName: test_01_public_ip_usage | Status : SUCCESS ===
   
   === TestName: test_01_snapshot_usage | Status : SUCCESS ===
   
   === TestName: test_01_template_usage | Status : SUCCESS ===
   
   === TestName: test_01_vm_usage | Status : SUCCESS ===
   
   === TestName: test_01_volume_usage | Status : SUCCESS ===
   
   === TestName: test_01_vpn_usage | Status : SUCCESS ===
   
   ===final results are now copied to: /marvin//MarvinLogs/test_usage_L4KAQG===
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643071390


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-675178805


   <b>Trillian test result (tid-2476)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 49408 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2476-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 82 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1806.94 | test_kubernetes_supported_versions.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 439.99 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 361.84 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3884.86 | test_vpc_redundant.py
   test_hostha_kvm_host_fencing | `Error` | 8.76 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-691048865


   not trying to be a smart one, but don't we only implement fixes on 4.14.x release? (i.e. no new features) - or am I confusing things here @weizhouapache ? Otherwise that sounds good (from a user perspective)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-645109075


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438692916



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -14,38 +14,44 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from utilities import writeProgressBar, bash
-from cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
+from .utilities import writeProgressBar, bash
+from .cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
 import logging
-from networkConfig import networkConfig
+from .networkConfig import networkConfig
 import re
-from configFileOps import configFileOps
+from .configFileOps import configFileOps
 import os
 import shutil
 
 # exit() error constants
 Unknown = 0
 CentOS6 = 1
 CentOS7 = 2
-Ubuntu = 3
-RHEL6 = 4
-RHEL7 = 5
+CentOS8 = 3

Review comment:
       @rhtyd have checked the code, as per my understanding, value for these constants is used within this file only at line 533 cc @davidjumani 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673915190


   @vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-631044894


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649518424


   @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng-81`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673404374


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673991850


   @vladimirpetrov I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653801359


   <b>Trillian test result (tid-1973)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47409 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1973-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1809.48 | test_kubernetes_supported_versions.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-661744675


   @andrijapanicsb I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466812401



##########
File path: setup/db/create-database-simulator.sql
##########
@@ -20,8 +20,8 @@ DROP DATABASE IF EXISTS `simulator`;
 
 CREATE DATABASE `simulator`;
 
-GRANT ALL ON simulator.* to cloud@`localhost` identified by 'cloud';
-GRANT ALL ON simulator.* to cloud@`%` identified by 'cloud';
+GRANT ALL ON simulator.* to cloud@`localhost`;
+GRANT ALL ON simulator.* to cloud@`%`;

Review comment:
       @andrijapanicsb User `cloud` with the password will already be created in create-database.sql https://github.com/apache/cloudstack/pull/4068/commits/b895cf98f3927b8fbae7c927367e2c1d3bb68e0b#diff-ca79fa3d84677eec693e98f41aca3a0eR58-R59




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664215259


   @blueorangutan test centos7 xenserver-71


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662243866


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438561981



##########
File path: python/bindir/cloud-grab-dependent-library-versions
##########
@@ -27,7 +27,7 @@ def runCmd(cmds):
     stdout, stderr = process.communicate()
     if process.returncode != 0:
         raise Exception(stderr)
-    return stdout
+    return stdout.decode('utf-8')

Review comment:
       @GabrielBrascher centos8 has python2 as python2 python3 as python36 and centos7 has python2 as python and python3 as python3 so I've added condition for that in the script.
   Though I'm not sure where that script is used. Could see it getting installed
   https://github.com/apache/cloudstack/pull/4068/commits/41a69cb3d985b55f76d1f47b51aae34b60e61763




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438683406



##########
File path: scripts/storage/qcow2/managesnapshot.sh
##########
@@ -187,6 +187,7 @@ backup_snapshot() {
   local snapshotname="$2"
   local destPath=$3
   local destName=$4
+  local forceShareFlag="-U"

Review comment:
       @rhtyd  `qemu-img` with QEMU 2.1 is not able to read QCOW2 file when it is already have a read lock by another process (libvirt). Due to this, both Ubuntu and CentOS8 fail to snapshot a running VM.
   For a running VM and volume snapshot, as per code (and my understanding), we create an external snapshot for VM using libvirt, then this script is used to read, convert (to a new file) and backup that snapshot to secondary storage using qemu-img. Since we are not making any change as such in original QCOW2 disk file, we can open it shared open (`-U`) flag which will prevent regression from CentOS7 or distros with older QEMU.
   I've added checks in code avoid any failures if `-U` is not supported




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-691048865






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649527492


   @blueorangutan test centos7 xcpng81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655357757


   Volume test passing after the latest changes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654615808


   Packaging result: ✔centos7 ✔debian. JID-1538


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr removed a comment on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-631044318


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664677157






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r469069219



##########
File path: agent/bindir/rolling-maintenance.in
##########
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/python3

Review comment:
       Latest commit should solve this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644551361


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671786226


   @vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-666352760


   <b>Trillian test result (tid-2232)</b>
   Environment: xcpng76 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 66315 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2232-xcpng76.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 17.50 | test_scale_vm.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 6035.88 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3923.39 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 4687.95 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 4858.78 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438670762



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -14,38 +14,44 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from utilities import writeProgressBar, bash
-from cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
+from .utilities import writeProgressBar, bash
+from .cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
 import logging
-from networkConfig import networkConfig
+from .networkConfig import networkConfig
 import re
-from configFileOps import configFileOps
+from .configFileOps import configFileOps
 import os
 import shutil
 
 # exit() error constants
 Unknown = 0
 CentOS6 = 1
 CentOS7 = 2
-Ubuntu = 3
-RHEL6 = 4
-RHEL7 = 5
+CentOS8 = 3
+Ubuntu = 4
+RHEL6 = 5
+RHEL7 = 6
+RHEL8 = 7
 distro = None
 
 #=================== DISTRIBUTION DETECTION =================
 if os.path.exists("/etc/centos-release"):
-    version = file("/etc/centos-release").readline()
+    version = open("/etc/centos-release").readline()
     if version.find("CentOS release 6") != -1:
       distro = CentOS6
     elif version.find("CentOS Linux release 7") != -1:
       distro = CentOS7
+    elif version.find("CentOS Linux release 8") != -1:
+      distro = CentOS8
 elif os.path.exists("/etc/redhat-release"):
-    version = file("/etc/redhat-release").readline()
+    version = open("/etc/redhat-release").readline()
     if version.find("Red Hat Enterprise Linux Server release 6") != -1:
       distro = RHEL6
     elif version.find("Red Hat Enterprise Linux Server 7") != -1:
       distro = RHEL7
-elif os.path.exists("/etc/lsb-release") and "Ubuntu" in file("/etc/lsb-release").read(-1): distro = Ubuntu
+    elif version.find("Red Hat Enterprise Linux Server 8") != -1:

Review comment:
       @shwstppr @davidjumani have we tested RHEL 8, or just extrapolating?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649454518


   Packaging result: ✖centos7 ✖debian. JID-1460


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-648833427


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674505346


   <b>Trillian test result (tid-2457)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 55363 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2457-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 83 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1568.38 | test_kubernetes_supported_versions.py
   test_01_scale_vm | `Failure` | 25.70 | test_scale_vm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662958574


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xcpng80) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662243506


   @blueorangutan test centos8 xenserver-71


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671760856


   @vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671210249


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672709237


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649519473


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xcpng-81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649517969


   @blueorangutan test centos7 + xcpng-81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655368948


   Packaging result: ✔centos7 ✔debian. JID-1557


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-631402758


   > nmcli conn show --active                                                           
   > nmcli conn add type bridge autoconnect yes con-name cloudbr0 ifname cloudbr0                                                                                            
   > nmcli conn modify cloudbr0 ipv4.addresses '172.20.1.10/16'                         
   > nmcli conn modify cloudbr0 ipv4.gateway '172.20.0.1'                               
   > nmcli conn modify cloudbr0 ipv4.dns '8.8.8.8'                                      
   > nmcli conn modify cloudbr0 ipv4.method manual                                      
   > nmcli conn add type ethernet slave-type bridge con-name bridge-cloudbr0 ifname eth0 master cloudbr0
   > nmcli conn add type bridge-slave ifname eth0 master cloudbr0                       
   > nmcli conn up cloudbr0
   
   nmcli commands that worked for me,
   ```
   nmcli conn show --active
   nmcli conn add type bridge autoconnect yes con-name cloudbr0 ifname cloudbr0
   nmcli conn modify cloudbr0 ipv4.addresses '172.20.1.10/16'
   nmcli conn modify cloudbr0 ipv4.gateway '172.20.0.1'
   nmcli conn modify cloudbr0 ipv4.dns '8.8.8.8'
   nmcli conn modify cloudbr0 ipv4.method manual
   sudo nmcli connection delete enp1s0
   sudo nmcli connection add type bridge-slave autoconnect yes con-name enp1s0 ifname enp1s0 master cloudbr0                     
   nmcli conn up cloudbr0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662243340


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672705835


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662243506


   @blueorangutan test centos8 xenserver-71


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674019667


   Env issue failed, rekicked job at the backend (job/acs-pr-trillian/2449/console)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653724425


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672715081


   /here I've disabled centos8 pkg building at BO/Jenkins by default, which fails for all other PRs, until this PR is merged. Pl kick centos8 pkging for this PR manually cc @davidjumani @andrijapanicsb @borisstoyanov @vladimirpetrov 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4068: [WIP] Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-626469360


   @weizhouapache We'll be adding our changes here, including the python3 support!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655304613


   @shwstppr please  fix conflicts as well


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662244413


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xcpng81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-645108796


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-636247811


   <b>Trillian test result (tid-1588)</b>
   Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
   Total time taken: 46990 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1588-kvm-ubuntu18.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 79 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 32.93 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 146.70 | test_deploy_vm_extra_config_data.py
   test_01_snapshot_root_disk | `Error` | 9.37 | test_snapshots.py
   test_01_snapshot_usage | `Error` | 5.26 | test_usage.py
   test_06_download_detached_volume | `Error` | 9.44 | test_volumes.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-635907316


   @shwstppr unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649518424


   @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng-81`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649519473


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xcpng-81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-663804838


   <b>Trillian test result (tid-2188)</b>
   Environment: xcpng80 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 69342 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2188-xcpng80.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 80 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r462802219



##########
File path: agent/bindir/libvirtqemuhook.in
##########
@@ -76,7 +76,7 @@ def handleMigrateBegin():
                 continue
             newBrName = "br" + phyDev + "-" + vlanId
             source.setAttribute("bridge", newBrName)
-        print(domain.toxml())
+        print((domain.toxml()))

Review comment:
       why is this needed @davidjumani ?

##########
File path: test/integration/smoke/test_vm_snapshots.py
##########
@@ -316,11 +325,20 @@ def setUpClass(cls):
                 cls.testClient.getZoneForTests()
             )
             cls.services["small"]["zoneid"] = cls.zone.id
-            cls.template = get_template(
-                cls.api_client,
-                cls.zone.id,
-                cls.services["ostype"]
-            )
+
+            cls.template = FAILED
+            if cls.hypervisor.lower() in ["xenserver"]:
+                cls.template = get_test_template(
+                    cls.api_client,
+                    cls.zone.id,
+                    cls.hypervisor
+                )
+            if cls.template == FAILED:

Review comment:
       6

##########
File path: scripts/vm/hypervisor/vmware/discover_networks.py
##########
@@ -16,7 +16,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-from __future__ import print_function
+

Review comment:
       why not remove this line?

##########
File path: test/integration/smoke/test_vm_snapshots.py
##########
@@ -50,11 +51,19 @@ def setUpClass(cls):
         cls.domain = get_domain(cls.apiclient)
         cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
 
-        template = get_template(
-            cls.apiclient,
-            cls.zone.id,
-            cls.services["ostype"]
-        )
+        template = FAILED
+        if cls.hypervisor.lower() in ["xenserver"]:
+            template = get_test_template(
+                cls.apiclient,
+                cls.zone.id,
+                cls.hypervisor
+            )
+        if template == FAILED:

Review comment:
       and the same code in a different file...

##########
File path: test/integration/smoke/test_volumes.py
##########
@@ -302,17 +312,25 @@ def setUpClass(cls):
                                     custom=True
                                     )
 
-        template = get_template(
-                            cls.apiclient,
-                            cls.zone.id,
-                            cls.services["ostype"]
-                            )
-        if template == FAILED:
+        cls.template = FAILED
+        if cls.hypervisor.lower() in ["xenserver"]:
+            cls.template = get_test_template(
+                cls.apiclient,
+                cls.zone.id,
+                cls.hypervisor
+            )
+        if cls.template == FAILED:

Review comment:
       you get the message by now

##########
File path: test/integration/smoke/test_vm_life_cycle.py
##########
@@ -850,11 +875,19 @@ def setUpClass(cls):
             0].__dict__
         cls.management_ip = cls.config.__dict__["mgtSvr"][0].__dict__["mgtSvrIp"]
 
-        template = get_template(
-            cls.apiclient,
-            cls.zone.id,
-            cls.services["ostype"]
-        )
+        template = FAILED
+        if cls.hypervisor.lower() in ["xenserver"]:
+            template = get_test_template(
+                cls.apiclient,
+                cls.zone.id,
+                cls.hypervisor
+            )
+        if template == FAILED:

Review comment:
       meaning if xenserver try again?

##########
File path: test/integration/smoke/test_vm_life_cycle.py
##########
@@ -1334,11 +1375,19 @@ def setUpClass(cls):
             0].__dict__
         cls.management_ip = cls.config.__dict__["mgtSvr"][0].__dict__["mgtSvrIp"]
 
-        template = get_template(
-            cls.apiclient,
-            cls.zone.id,
-            cls.services["ostype"]
-        )
+        template = FAILED
+        if cls.hypervisor.lower() in ["xenserver"]:
+            template = get_test_template(
+                cls.apiclient,
+                cls.zone.id,
+                cls.hypervisor
+            )
+        if template == FAILED:

Review comment:
       3rd

##########
File path: test/integration/smoke/test_vm_life_cycle.py
##########
@@ -1533,13 +1582,20 @@ def setUpClass(cls):
         cls.domain = get_domain(cls.apiclient)
         cls.zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
         cls.services['mode'] = cls.zone.networktype
-
-        cls.template = get_template(
-            cls.apiclient,
-            cls.zone.id,
-            cls.services["ostype"],
-            hypervisor=cls.hypervisor.lower()
-        )
+        template = FAILED
+        if cls.hypervisor.lower() in ["xenserver"]:
+            cls.template = get_test_template(
+                cls.apiclient,
+                cls.zone.id,
+                cls.hypervisor
+            )
+        if cls.template == FAILED:

Review comment:
       4th now it really starts paying off

##########
File path: test/integration/smoke/test_vm_life_cycle.py
##########
@@ -1122,11 +1155,19 @@ def setUpClass(cls):
             0].__dict__
         cls.management_ip = cls.config.__dict__["mgtSvr"][0].__dict__["mgtSvrIp"]
 
-        template = get_template(
-            cls.apiclient,
-            cls.zone.id,
-            cls.services["ostype"]
-        )
+        template = FAILED
+        if cls.hypervisor.lower() in ["xenserver"]:
+            template = get_test_template(
+                cls.apiclient,
+                cls.zone.id,
+                cls.hypervisor
+            )
+        if template == FAILED:

Review comment:
       same code as above make a method?

##########
File path: test/integration/smoke/test_volumes.py
##########
@@ -83,11 +84,20 @@ def setUpClass(cls):
                                     cls.services["disk_offering"],
                                     custom=True
                                     )
-        template = get_template(
-                            cls.apiclient,
-                            cls.zone.id,
-                            cls.services["ostype"]
-                            )
+
+        template = FAILED
+        if cls.hypervisor.lower() in ["xenserver"]:
+            template = get_test_template(
+                cls.apiclient,
+                cls.zone.id,
+                cls.hypervisor
+            )
+        if template == FAILED:

Review comment:
       3rd file #7




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r468868061



##########
File path: agent/bindir/rolling-maintenance.in
##########
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/python3

Review comment:
       i.e. 20:50:23,239 rolling-maintenance INFO **b**'preflight stage' (from the log)
   or
   "output": "**b**'This is Maintenance Stage'**\n**", (from the API output)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671209608


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-661750322


   @andrijapanicsb I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652923319


   Packaging result: ✔centos7 ✔debian. JID-1506


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668993943


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466304580



##########
File path: scripts/storage/qcow2/managesnapshot.sh
##########
@@ -187,6 +187,7 @@ backup_snapshot() {
   local snapshotname="$2"
   local destPath=$3
   local destName=$4
+  local forceShareFlag="-U"

Review comment:
       qemu 2.10 I believe, which also means when using qemu-kvm-ev 2.10+ on i.e. CentOS7+NFS3 PRimary Storage - is fixed!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-642591074


   Packaging result: ✔centos7 ✔debian. JID-1346


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466304580



##########
File path: scripts/storage/qcow2/managesnapshot.sh
##########
@@ -187,6 +187,7 @@ backup_snapshot() {
   local snapshotname="$2"
   local destPath=$3
   local destName=$4
+  local forceShareFlag="-U"

Review comment:
       qemu 2.10 I believe, which also means when using qemu-kvm-ev 2.10+ on i.e. CentOS7 is fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662958641


   @blueorangutan test centos7 xcpng80


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672708683


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654035177


   <b>Trillian test result (tid-1996)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 49147 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1996-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 962.05 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 329.55 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3926.77 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr removed a comment on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-635906791


   @blueorangutan test u18 kvm-ubuntu18


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466305525



##########
File path: setup/db/create-database-simulator.sql
##########
@@ -20,8 +20,8 @@ DROP DATABASE IF EXISTS `simulator`;
 
 CREATE DATABASE `simulator`;
 
-GRANT ALL ON simulator.* to cloud@`localhost` identified by 'cloud';
-GRANT ALL ON simulator.* to cloud@`%` identified by 'cloud';
+GRANT ALL ON simulator.* to cloud@`localhost`;
+GRANT ALL ON simulator.* to cloud@`%`;

Review comment:
       @shwstppr I assume a password for this user is set elsewhere?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674786944


   @blueorangutan test centos7 kvm-centos7


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-642536665


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649451536


   Packaging result: ✔centos7 ✔debian. JID-1458


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd edited a comment on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-640316222


   ~@shwstppr @davidjumani can you fix/pull the change from https://github.com/apache/cloudstack/pull/4094 (I'll close #4094 once that snasphot issue has been addressed in this PR)~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-642173939


   Packaging result: ✔centos7 ✔debian. JID-1334


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-673992402


   @blueorangutan test centos8 kvm-centos8


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-641172607






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438669648



##########
File path: python/lib/cloudutils/test.py
##########
@@ -0,0 +1,11 @@
+#!/usr/bin/env python3
+
+from .utilities import bash
+import logging
+
+cmd = bash("route -n|awk \'/^0.0.0.0/ {print $2,$8}\'")
+if not cmd.isSuccess():
+    logging.debug("Failed to get default route")
+    raise CloudRuntimeException("Failed to get default route")
+
+result = cmd.getStdout().split(" ")

Review comment:
       @davidjumani @shwstppr This looks like a new file, if this was for testing while developing the feature and is unecessary (not tied or run with travis/trillia) - remove it please.

##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -193,6 +200,17 @@ def __init__(self, glbEnv):
                          nfsConfig(self),
                          cloudAgentConfig(self)]
 
+#it covers RHEL8

Review comment:
       Remove comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438703914



##########
File path: python/lib/cloudutils/test.py
##########
@@ -0,0 +1,11 @@
+#!/usr/bin/env python3
+
+from .utilities import bash
+import logging
+
+cmd = bash("route -n|awk \'/^0.0.0.0/ {print $2,$8}\'")
+if not cmd.isSuccess():
+    logging.debug("Failed to get default route")
+    raise CloudRuntimeException("Failed to get default route")
+
+result = cmd.getStdout().split(" ")

Review comment:
       removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652999732


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd edited a comment on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-640316222


   ~@shwstppr @davidjumani can you fix/pull the change from https://github.com/apache/cloudstack/pull/4094 (I'll close #4094 once that snasphot issue has been addressed in this PR)~
   
   @shwstppr @davidjumani please refer https://github.com/apache/cloudstack/pull/4094/files and fix snapshot failures for centos8/ubuntu 20.04 and other supported distros in this PR itself. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664193373






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-638560036


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438692916



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -14,38 +14,44 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from utilities import writeProgressBar, bash
-from cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
+from .utilities import writeProgressBar, bash
+from .cloudException import CloudRuntimeException, CloudInternalException, formatExceptionInfo
 import logging
-from networkConfig import networkConfig
+from .networkConfig import networkConfig
 import re
-from configFileOps import configFileOps
+from .configFileOps import configFileOps
 import os
 import shutil
 
 # exit() error constants
 Unknown = 0
 CentOS6 = 1
 CentOS7 = 2
-Ubuntu = 3
-RHEL6 = 4
-RHEL7 = 5
+CentOS8 = 3

Review comment:
       @rhtyd have checked the code, as per my understanding, value these constants is used within this file only at line 533 cc @davidjumani 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674429006


   @blueorangutan test centos8 xenserver-71


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649472306


   Packaging result: ✔centos7 ✔debian. JID-1461


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668492061


   Packaging result: ✔centos7 ✔debian. JID-1643


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662240647


   <b>Trillian test result (tid-2157)</b>
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 60066 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2157-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 1846.76 | test_kubernetes_clusters.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3909.46 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664215872


   @blueorangutan test centos8 xenserver-71


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652124111


   <b>Trillian test result (tid-1915)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33333 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1915-kvm-centos7.zip
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r447404050



##########
File path: debian/rules
##########
@@ -6,7 +6,8 @@ SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
 %:
-	dh $@ --with python2,systemd
+	# TODO : Make it work with python2 also

Review comment:
       Addressed by David's commit @andrijapanicsb 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-650082859


   Packaging result: ✔centos7 ✔debian. JID-1469


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654493657


   <b>Trillian test result (tid-2007)</b>
   Environment: xcpng81 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47815 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2007-xcpng81.zip
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 76 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_nic | `Error` | 117.62 | test_nic.py
   test_01_deploy_vms_storage_tags | `Error` | 7.48 | test_primary_storage.py
   test_01_scale_vm | `Failure` | 4.15 | test_scale_vm.py
   test_01_volume_usage | `Error` | 85.15 | test_usage.py
   test_11_migrate_vm | `Error` | 58.02 | test_vm_life_cycle.py
   test_13_attachAndDetach_iso | `Failure` | 674.00 | test_vm_life_cycle.py
   test_change_service_offering_for_vm_with_snapshots | `Failure` | 759.02 | test_vm_snapshots.py
   test_01_create_vm_snapshots | `Failure` | 664.77 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | `Failure` | 664.77 | test_vm_snapshots.py
   test_03_delete_vm_snapshots | `Failure` | 0.01 | test_vm_snapshots.py
   test_01_create_volume | `Error` | 3.24 | test_volumes.py
   test_02_attach_volume | `Error` | 2.09 | test_volumes.py
   test_03_download_attached_volume | `Error` | 1.07 | test_volumes.py
   test_04_delete_attached_volume | `Error` | 2.08 | test_volumes.py
   test_05_detach_volume | `Error` | 2.09 | test_volumes.py
   test_06_download_detached_volume | `Error` | 2.08 | test_volumes.py
   test_07_resize_fail | `Error` | 2.16 | test_volumes.py
   test_08_resize_volume | `Error` | 2.09 | test_volumes.py
   test_09_delete_detached_volume | `Error` | 2.17 | test_volumes.py
   test_11_attach_volume_with_unstarted_vm | `Error` | 13.59 | test_volumes.py
   test_11_migrate_volume_and_change_offering | `Error` | 4.21 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 4.29 | test_volumes.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-651824598


   Packaging result: ✔centos7 ✔debian. JID-1494


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-635904763


   @blueorangutan test ubuntu kvm-ubuntu


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-661749964


   @blueorangutan help
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-635906791


   @blueorangutan test u18 kvm-ubuntu18


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-639166423


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438669141



##########
File path: scripts/storage/qcow2/managesnapshot.sh
##########
@@ -187,6 +187,7 @@ backup_snapshot() {
   local snapshotname="$2"
   local destPath=$3
   local destName=$4
+  local forceShareFlag="-U"

Review comment:
       @davidjumani @shwstppr can you explain this change and how it is used - is this for the snapshot failure fix?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674347629


   <b>Trillian test result (tid-2451)</b>
   Environment: xenserver-74 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 59393 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2451-xenserver-74.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 82 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1807.42 | test_kubernetes_supported_versions.py
   test_01_scale_vm | `Failure` | 27.73 | test_scale_vm.py
   test_11_migrate_volume_and_change_offering | `Error` | 8.42 | test_volumes.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662957808


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: [WIP] Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r425916165



##########
File path: scripts/vm/hypervisor/xenserver/vmops
##########
@@ -162,7 +162,7 @@ def setLinkLocalIP(session, args):
 
         if result.lower().strip() == "bridge":
             try:
-                cmd = ["brctl", "addbr", brName]
+                cmd = ["ip", "link", "add", "name", brName, "type", "bridge"]

Review comment:
       I suggest you check if this needs to be done for xenserver; the xenserver scripts run only xenserver host (even though they are part of cloudstack-common; cloudstack copies these scripts to XenServer/XCP-ng hosts where they get executed, not on mgmt server). @shwstppr 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-647354974


   <b>Trillian test result (tid-1788)</b>
   Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
   Total time taken: 64484 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1788-kvm-ubuntu18.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 79 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 48.38 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 150.34 | test_deploy_vm_extra_config_data.py
   test_01_deploy_kubernetes_cluster | `Error` | 3612.57 | test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.06 | test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 3608.40 | test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 36.37 | test_kubernetes_clusters.py
   test_06_download_detached_volume | `Error` | 9.47 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 372.51 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 366.75 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668499678


   @rhtyd @DaanHoogland comments addressed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-650885753


   <b>Trillian test result (tid-1890)</b>
   Environment: xcpng76 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 49398 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1890-xcpng76.zip
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermittent failure detected: /marvin/tests/smoke/test_backup_recovery_dummy.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 68 look OK, 15 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAffinityGroup | `Error` | 51.15 | test_affinity_groups.py
   test_DeployVmAntiAffinityGroup | `Error` | 16.46 | test_affinity_groups.py
   ContextSuite context=TestDummyBackupAndRecovery>:setup | `Error` | 0.00 | test_backup_recovery_dummy.py
   test_07_deploy_vm_with_extraconfig_xenserver | `Error` | 51.01 | test_deploy_vm_extra_config_data.py
   test_00_deploy_vm_root_resize | `Error` | 63.47 | test_deploy_vm_root_resize.py
   test_01_nic | `Error` | 92.70 | test_nic.py
   test_01_add_primary_storage_disabled_host | `Error` | 253.78 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.09 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.15 | test_primary_storage.py
   ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
   ContextSuite context=TestTemplates>:setup | `Error` | 61.09 | test_templates.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 52.65 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 116.40 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 172.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 228.66 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 370.90 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 432.76 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 488.42 | test_usage.py
   test_01_deploy_vm_on_specific_host | `Error` | 43.99 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 5.21 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 7.26 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 6.24 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 7.26 | test_vm_deployment_planner.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_change_service_offering_for_vm_with_snapshots | `Error` | 54.25 | test_vm_snapshots.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 131.37 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 499.45 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 4.35 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Failure` | 67.64 | test_host_maintenance.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671412040


   @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668460823


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438703254



##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -343,7 +349,7 @@ def config(self):
             cfo.addEntry("NOZEROCONF", "yes")
             cfo.save()
 
-            if not bash("service network restart").isSuccess():
+            if not bash("systemctl restart NetworkManager.service").isSuccess():

Review comment:
       @rhtyd `systemctl restart network` doesn't works on CentOS 8,
   ```
   [root@srvr1 ~]# hostnamectl
      Static hostname: localhost.localdomain
   Transient hostname: srvr1.cloud.priv
            Icon name: computer-vm
              Chassis: vm
           Machine ID: 5319303eb7f24b7b9ff80b20b150cc0c
              Boot ID: 520c83f640bc4635880b23ba6f765497
       Virtualization: kvm
     Operating System: CentOS Linux 8 (Core)
          CPE OS Name: cpe:/o:centos:centos:8
               Kernel: Linux 4.18.0-147.8.1.el8_1.x86_64
         Architecture: x86-64
   [root@srvr1 ~]# systemctl restart network
   Failed to restart network.service: Unit network.service not found.
   [root@srvr1 ~]# systemctl restart NetworkManager
   [root@srvr1 ~]# exit
   ```
   
   This code to add bridge is not really used as we create bridge prior to installation as per docs. However, I've modified the above change to allow backward compatibility




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-724606437


   It's worth mentioning, that on AMD EPYC CPUs, we had to upgrade Ubuntu kernel to 5.8.1+ in order to resolve a Qemu bug with CPU registers and stuff....where the VM can't be started at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674429052


   @rhtyd a Trillian-Jenkins test job (centos8 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668450422


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662244413


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xcpng81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r468867041



##########
File path: agent/bindir/rolling-maintenance.in
##########
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/python3

Review comment:
       On line 79 and 83/84 - the error is thrown  "Unexpected error on systemd service: write() argument must be str, not bytes".
   
   This needs to be fixed, and also, the output given in the API and also inside the rolling-maintenance.log (on the KVM host) is prepended with letter **b**, and appended with    **\n**




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653804851


   <b>Trillian test result (tid-1971)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 49654 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1971-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 22.68 | test_scale_vm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649532591


   @andrijapanicsb unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng80, xcpng81`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-663819726


   <b>Trillian test result (tid-2187)</b>
   Environment: xcpng80 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 79543 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2187-xcpng80.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 4.18 | test_scale_vm.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 848.62 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 4238.26 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 987.03 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672322362


   <b>Trillian test result (tid-2356)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 50837 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2356-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1807.73 | test_kubernetes_supported_versions.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 379.47 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3831.93 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-661744386






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-688491625


   Btw I'm running a custom build of 4.14 on Ubuntu 20.04 on raspberrypi4 using commits from Wei/this PR @andrijapanicsb 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-661750807


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + kvm-centos8) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438703797



##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -193,6 +200,17 @@ def __init__(self, glbEnv):
                          nfsConfig(self),
                          cloudAgentConfig(self)]
 
+#it covers RHEL8

Review comment:
       @rhtyd was just following the norm in the file which has a comment for rest of the distro :). Will remove if needed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-634435612


   @shwstppr with https://github.com/apache/cloudstack/pull/4092 merged, move any sql changes to the specific 4.14->4.15 upgrade path.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649390379


   Packaging result: ✔centos7 ✔debian. JID-1455


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672706034


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653724336


   @blueorangutan test matrix


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662958294


   @blueorangutan test centos8 xcpng80


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671784255


   Packaging result: ✔centos7 ✔debian. JID-1703


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r446075292



##########
File path: packaging/systemd/cloudstack-management.service
##########
@@ -35,6 +35,7 @@ EnvironmentFile=/etc/default/cloudstack-management
 WorkingDirectory=/var/log/cloudstack/management
 PIDFile=/var/run/cloudstack-management.pid
 ExecStart=/usr/bin/java $JAVA_DEBUG $JAVA_OPTS -cp $CLASSPATH $BOOTSTRAP_CLASS
+SuccessExitStatus=143

Review comment:
       For reference https://serverfault.com/a/890085




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-691120396


   > not trying to be a smart one, but don't we only implement fixes on 4.14.x release? (i.e. no new features) - or am I confusing things here @weizhouapache ? Otherwise that sounds good (from a user perspective)
   
   @andrijapanicsb true. 4.14 accepts only bug fixes. so I will not create PR for it.
   However, it is good to provide packages for cloudstack users who want to run cloudstack 4.14.X on ubuntu 20.04.
   The packages are not official. it could be something like ubuntu/ppa: https://launchpad.net/ubuntu/+ppas
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649531884


   @blueorangutan test centos7 xcpng76


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649533755


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xcpng76) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674787296


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674336857


   <b>Trillian test result (tid-2452)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 52647 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2452-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 83 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1808.71 | test_kubernetes_supported_versions.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 501.15 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-674790960


   LGTM
   
   Any outstanding issues with tests, will have to be resolved for 4.15


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672713986


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-661750322


   @andrijapanicsb I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672891951


   Packaging result: ✔centos7 ✔debian. JID-1725


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655247303


   CentOS8 kvm doesn't like volume to be detached 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668478943


   Packaging result: ✔centos7 ✔debian. JID-1642


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672709114


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-691048865






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664216299


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xenserver-71) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644551759


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654693422


   Packaging result: ✔centos7 ✔debian. JID-1544


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649520945


   @blueorangutan test centos7 xcpng81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-650757098


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xcpng76) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652888094


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-641172838






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662958153


   @andrijapanicsb a Trillian-Jenkins test job (centos8 mgmt + xcpng81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-691047180






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649506309


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649873755


   <b>Trillian test result (tid-1847)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40028 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1847-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_snapshot_root_disk | `Failure` | 5.09 | test_snapshots.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-688263834


   @andrijapanicsb tested some actions and found some issues, see PR #4301 and #4303 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643081171


   Packaging result: ✔centos7 ✔debian. JID-1358


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r445518860



##########
File path: packaging/centos7/cloud.spec
##########
@@ -279,6 +280,11 @@ install -D server/target/conf/cloudstack-sudoers ${RPM_BUILD_ROOT}%{_sysconfdir}
 touch ${RPM_BUILD_ROOT}%{_localstatedir}/run/%{name}-management.pid
 #install -D server/target/conf/cloudstack-catalina.logrotate ${RPM_BUILD_ROOT}%{_sysconfdir}/logrotate.d/%{name}-catalina
 
+# Package mysql-connector-python
+wget -P ${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/setup/wheel https://files.pythonhosted.org/packages/ee/ff/48bde5c0f013094d729fe4b0316ba2a24774b3ff1c52d924a8a4cb04078a/six-1.15.0-py2.py3-none-any.whl
+wget -P ${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/setup/wheel https://files.pythonhosted.org/packages/28/05/9867ef8eafd12265267bee138fa2c46ebf34a276ea4cbe184cba4c606e8b/protobuf-3.12.2-cp36-cp36m-manylinux1_x86_64.whl
+wget -P ${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/setup/wheel https://files.pythonhosted.org/packages/d1/53/4cf90d2fe81b9cdb55dc180951bcec44ea8685665f1bdb1412501dc362dd/mysql_connector_python-8.0.20-cp36-cp36m-manylinux1_x86_64.whl
+

Review comment:
       @rhtyd do we need to delete these .whl files after install?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-648836422


   test's will fail, as there is an unresolved package dependency for centos7 which should (probably) not be there.
   CentOS7 should not require python3, only centos8.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649520945


   @blueorangutan test centos7 xcpng81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4068: [WIP] Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-626650456


   @davidjumani @shwstppr related PR for Ubuntu 20.04 with likely some overlapping parts - https://github.com/apache/cloudstack/pull/4069


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662959018


   @blueorangutan test centos7 xcpng81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653005161


   <b>Trillian test result (tid-1931)</b>
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 56280 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1931-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_simulator.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_login.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 62 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_role_account_acls_multiple_mgmt_servers | `Error` | 0.36 | test_dynamicroles.py
   test_query_async_job_result | `Error` | 83.88 | test_async_job.py
   test_revoke_certificate | `Error` | 0.00 | test_certauthority_root.py
   test_configure_ha_provider_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_default_driver | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_invalid_provider | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 60.59 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 160.38 | test_deploy_vm_extra_config_data.py
   test_01_deploy_kubernetes_cluster | `Error` | 772.62 | test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 1135.75 | test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 35.30 | test_kubernetes_clusters.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 5.49 | test_kubernetes_supported_versions.py
   login_test_saml_user | `Error` | 0.31 | test_login.py
   test_oobm_issue_power_cycle | `Error` | 3.33 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_off | `Error` | 3.33 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_on | `Error` | 3.31 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_reset | `Error` | 3.30 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_soft | `Error` | 2.29 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_status | `Error` | 2.21 | test_outofbandmanagement_nestedplugin.py
   test_oobm_background_powerstate_sync | `Failure` | 20.61 | test_outofbandmanagement.py
   test_oobm_background_powerstate_sync | `Error` | 20.61 | test_outofbandmanagement.py
   test_oobm_configure_default_driver | `Error` | 0.04 | test_outofbandmanagement.py
   test_oobm_configure_invalid_driver | `Error` | 0.04 | test_outofbandmanagement.py
   test_oobm_disable_feature_invalid | `Error` | 0.06 | test_outofbandmanagement.py
   test_oobm_disable_feature_valid | `Error` | 1.12 | test_outofbandmanagement.py
   test_oobm_enable_feature_invalid | `Error` | 0.07 | test_outofbandmanagement.py
   test_oobm_enable_feature_valid | `Error` | 1.10 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 9.85 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 9.85 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 3.30 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 3.30 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 2.30 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 2.30 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 3.29 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 3.30 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 2.28 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 2.28 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 2.25 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 2.25 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 4.31 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 4.31 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Error` | 1.12 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Error` | 1.12 | test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 1.18 | test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 1.18 | test_outofbandmanagement.py
   test_isolate_network_password_server | `Failure` | 17.43 | test_password_server.py
   test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py
   test_01_vpc_privategw_acl | `Error` | 39.50 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Error` | 163.68 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 160.66 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Error` | 282.83 | test_privategw_acl.py
   test_router_dhcphosts | `Failure` | 17.52 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 27.89 | test_router_dhcphosts.py
   test_01_snapshot_root_disk | `Error` | 8.31 | test_snapshots.py
   test_CreateTemplateWithDuplicateName | `Error` | 159.81 | test_templates.py
   test_01_register_template_direct_download_flag | `Error` | 0.12 | test_templates.py
   test_01_ISO_usage | `Error` | 1.08 | test_usage.py
   test_01_lb_usage | `Error` | 7.28 | test_usage.py
   test_01_nat_usage | `Error` | 12.37 | test_usage.py
   test_01_public_ip_usage | `Error` | 1.07 | test_usage.py
   test_01_snapshot_usage | `Error` | 106.54 | test_usage.py
   test_01_template_usage | `Error` | 103.15 | test_usage.py
   test_01_vm_usage | `Error` | 133.49 | test_usage.py
   test_01_volume_usage | `Error` | 128.25 | test_usage.py
   test_01_vpn_usage | `Error` | 12.55 | test_usage.py
   test_11_migrate_vm | `Error` | 53.97 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 103.97 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Error` | 9.38 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3886.29 | test_vpc_redundant.py
   test_disable_oobm_ha_state_ineligible | `Error` | 0.04 | test_hostha_kvm.py
   test_hostha_configure_default_driver | `Error` | 0.04 | test_hostha_kvm.py
   test_hostha_enable_ha_when_host_disabled | `Error` | 0.05 | test_hostha_kvm.py
   test_hostha_enable_ha_when_host_disconected | `Error` | 0.04 | test_hostha_kvm.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_kvm_host_degraded | `Error` | 0.04 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 0.03 | test_hostha_kvm.py
   test_remove_ha_provider_not_possible | `Error` | 0.04 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671785636


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-662244005


   @blueorangutan test centos8 xcpng81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4068: Adding Centos8 Support

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-649527921


   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + xcpng81) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org