You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/07/13 22:39:27 UTC

[GitHub] [cassandra] dcapwell commented on a diff in pull request #1724: CASSANDRA-17731 4.0 Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests

dcapwell commented on code in PR #1724:
URL: https://github.com/apache/cassandra/pull/1724#discussion_r920566911


##########
test/distributed/org/apache/cassandra/distributed/test/RepairErrorsTest.java:
##########
@@ -145,9 +145,7 @@ public void testRemoteStreamFailure() throws Exception
     @SuppressWarnings("Convert2MethodRef")
     private void assertNoActiveRepairSessions(IInvokableInstance instance)
     {
-        // Make sure we've cleaned up sessions and parent sessions:
-        Integer parents = instance.callOnInstance(() -> ActiveRepairService.instance.parentRepairSessionCount());
-        assertEquals(0, parents.intValue());

Review Comment:
   why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org