You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/28 16:05:13 UTC
[GitHub] [flink] leonardBang opened a new pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
leonardBang opened a new pull request #17377:
URL: https://github.com/apache/flink/pull/17377
## What is the purpose of the change
* This pull request move out the time zone page from streaming concepts section
## Brief change log
- move out the timezone page as it is not streaming specific
## Verifying this change
This change is a doc hotfix without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929376775
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e (Tue Sep 28 16:14:58 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592",
"triggerID" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"triggerType" : "PUSH"
}, {
"hash" : "806c45e5ba19bc365c30b8a05766b289539f0887",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24599",
"triggerID" : "806c45e5ba19bc365c30b8a05766b289539f0887",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592)
* 806c45e5ba19bc365c30b8a05766b289539f0887 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24599)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592",
"triggerID" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"triggerType" : "PUSH"
}, {
"hash" : "806c45e5ba19bc365c30b8a05766b289539f0887",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24599",
"triggerID" : "806c45e5ba19bc365c30b8a05766b289539f0887",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 806c45e5ba19bc365c30b8a05766b289539f0887 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24599)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #17377:
URL: https://github.com/apache/flink/pull/17377#discussion_r717994901
##########
File path: docs/content.zh/docs/dev/table/timezone.md
##########
@@ -1,6 +1,6 @@
---
title: "时区"
-weight: 4
+weight: 86
Review comment:
Can you make this 22 so it appears after the data types page in the sidebar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #17377:
URL: https://github.com/apache/flink/pull/17377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929376775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #17377:
URL: https://github.com/apache/flink/pull/17377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929697510
Appreciate if you can help merge @sjwiesman , I don't have merge authority yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592",
"triggerID" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #17377:
URL: https://github.com/apache/flink/pull/17377#discussion_r717994901
##########
File path: docs/content.zh/docs/dev/table/timezone.md
##########
@@ -1,6 +1,6 @@
---
title: "时区"
-weight: 4
+weight: 86
Review comment:
Can you make this 22 so it appears after the data types page in the sidebar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592",
"triggerID" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929697510
Appreciate if you can help merge @sjwiesman , I don't have merge authority yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592",
"triggerID" : "ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e",
"triggerType" : "PUSH"
}, {
"hash" : "806c45e5ba19bc365c30b8a05766b289539f0887",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "806c45e5ba19bc365c30b8a05766b289539f0887",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24592)
* 806c45e5ba19bc365c30b8a05766b289539f0887 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17377:
URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org