You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/01 23:08:23 UTC
Re: Review Request 42972: Fixed a typo (unintended inequality between
pointer value and 0) in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 10:08 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Fix commit message style
Summary (updated)
-----------------
Fixed a typo (unintended inequality between pointer value and 0) in stout.
Repository: mesos
Description (updated)
-------
Fixed a typo (unintended inequality between pointer value and 0) in stout.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 2a188459465a5203c56d788a74e69d403790c5bf
Diff: https://reviews.apache.org/r/42972/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 42972: Fixed a minor bug in stout's Flags package.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/#review117416
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 2, 2016, 1:53 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42972/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 1:53 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Unintended inequality comparison between pointer value and 0.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 2a188459465a5203c56d788a74e69d403790c5bf
>
> Diff: https://reviews.apache.org/r/42972/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42972: Fixed a minor bug in stout's Flags package.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 1:53 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Fix commit summary.
Summary (updated)
-----------------
Fixed a minor bug in stout's Flags package.
Repository: mesos
Description (updated)
-------
Unintended inequality comparison between pointer value and 0.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 2a188459465a5203c56d788a74e69d403790c5bf
Diff: https://reviews.apache.org/r/42972/diff/
Testing
-------
make check
Thanks,
Neil Conway