[GitHub] [druid] paul-rogers commented on a diff in pull request #13878: Bump CycloneDX module to address POM errors

["paul-rogers (via GitHub)" <gi...@apache.org>]

paul-rogers commented on code in PR #13878:
URL: https://github.com/apache/druid/pull/13878#discussion_r1123974232


##########
.github/workflows/standard-its.yml:
##########
@@ -106,9 +106,7 @@ jobs:
     runs-on: ubuntu-22.04
     env:
       MVN: mvn --no-snapshot-updates
-      # Added -Dcyclonedx.skip=true to avoid ISO-8859-1 [ERROR]s
-      # May be fixed in the future
-      MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true
+      MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true

Review Comment:
   Comments are out of order. Can also skip CycloneDX for the standard ITs since we do it for the build. It doesn't add much to repeat it for the ITs as well.



##########
it.sh:
##########
@@ -193,9 +193,7 @@ fi
 
 CMD=$1
 shift
-# Added -Dcyclonedx.skip=true to avoid ISO-8859-1 [ERROR]s
-# May be fixed in the future
-MAVEN_IGNORE="-P skip-static-checks,skip-tests -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true"
+MAVEN_IGNORE="-P skip-static-checks,skip-tests -Dmaven.javadoc.skip=true"

Review Comment:
   This one can remain since we don't need to repeat the checks for the ITs. No worries; I'll add it in a different PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org