You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/16 21:47:53 UTC
[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #17346: Fix
reshape interoperability test (#17155)
ChaiBapchya opened a new pull request #17346: Fix reshape interoperability test (#17155)
URL: https://github.com/apache/incubator-mxnet/pull/17346
* fix reshape interoperability test
* fix for scipy import
## Description ##
To fix the numpy.decorator issue in https://github.com/apache/incubator-mxnet/pull/17286
@haojin2 @frankfliu @reminisce
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] reminisce commented on a change in pull request
#17346: Fix reshape interoperability test (#17155)
Posted by GitBox <gi...@apache.org>.
reminisce commented on a change in pull request #17346: Fix reshape interoperability test (#17155)
URL: https://github.com/apache/incubator-mxnet/pull/17346#discussion_r367672217
##########
File path: ci/docker/install/docs_requirements
##########
@@ -26,11 +26,11 @@ h5py==2.8.0rc1
mock==2.0.0
nose==1.3.7
nose-timer==0.7.3
-numpy>1.16.0,<2.0.0
+numpy>1.16.0,<1.18.0
Review comment:
Why is there a restriction on the numpy version? I think it has been fixed in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya closed pull request #17346: Fix
reshape interoperability test (#17155)
Posted by GitBox <gi...@apache.org>.
ChaiBapchya closed pull request #17346: Fix reshape interoperability test (#17155)
URL: https://github.com/apache/incubator-mxnet/pull/17346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17346: Fix
reshape interoperability test (#17155)
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17346: Fix reshape interoperability test (#17155)
URL: https://github.com/apache/incubator-mxnet/pull/17346#issuecomment-577994430
Closing in favor of #17426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17346: Fix
reshape interoperability test (#17155)
Posted by GitBox <gi...@apache.org>.
ChaiBapchya edited a comment on issue #17346: Fix reshape interoperability test (#17155)
URL: https://github.com/apache/incubator-mxnet/pull/17346#issuecomment-577838667
Weird thing
https://github.com/ChaiBapchya/incubator-mxnet/blob/60dd6bd0dc7b902df50b3c8047d13f3c16647050/ci/docker_cache_requirements#L22
On the same branch python-dateutil==2.7.2 has been pinned... not sure why it doesn't pick that up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17346: Fix
reshape interoperability test (#17155)
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17346: Fix reshape interoperability test (#17155)
URL: https://github.com/apache/incubator-mxnet/pull/17346#issuecomment-577838667
Weird thing
https://github.com/ChaiBapchya/incubator-mxnet/blob/60dd6bd0dc7b902df50b3c8047d13f3c16647050/ci/docker_cache_requirements#L22
On the same branch python-dateutil==2.7.2 has been fixed... not sure why it doesn't pick that up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request
#17346: Fix reshape interoperability test (#17155)
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #17346: Fix reshape interoperability test (#17155)
URL: https://github.com/apache/incubator-mxnet/pull/17346#discussion_r367676509
##########
File path: ci/docker/install/docs_requirements
##########
@@ -26,11 +26,11 @@ h5py==2.8.0rc1
mock==2.0.0
nose==1.3.7
nose-timer==0.7.3
-numpy>1.16.0,<2.0.0
+numpy>1.16.0,<1.18.0
Review comment:
I was told it was this PR's fix that helped resolve the issue https://github.com/apache/incubator-mxnet/issues/17154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services