You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/14 21:30:24 UTC
[GitHub] [camel] jeremyross opened a new pull request #5086: CAMEL-16206: camel-sql: Preserve message body
jeremyross opened a new pull request #5086:
URL: https://github.com/apache/camel/pull/5086
...when CamelSqlRetrieveGeneratedKeys == true
Also refactored out some duplicate code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #5086: CAMEL-16206: camel-sql: Preserve message body
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #5086:
URL: https://github.com/apache/camel/pull/5086#discussion_r575958661
##########
File path: components/camel-sql/src/main/java/org/apache/camel/component/sql/SqlProducer.java
##########
@@ -249,15 +200,15 @@ public PreparedStatement createPreparedStatement(Connection con) throws SQLExcep
}
// data is set on exchange so return null
- return null;
+ return data;
Review comment:
The comment above is now wrong, so remove the comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jeremyross merged pull request #5086: CAMEL-16206: camel-sql: Preserve message body
Posted by GitBox <gi...@apache.org>.
jeremyross merged pull request #5086:
URL: https://github.com/apache/camel/pull/5086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org