You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/29 07:33:17 UTC
[GitHub] [rocketmq] xujianhai666 commented on a change in pull request
#1749: ResetOffsetByTimeCommand supports specified queue
xujianhai666 commented on a change in pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#discussion_r386008890
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/offset/ResetOffsetByTimeCommand.java
##########
@@ -49,10 +50,18 @@ public Options buildCommandlineOptions(Options options) {
opt.setRequired(true);
options.addOption(opt);
+ opt = new Option("b", "broker", true, "set broker address");
+ opt.setRequired(false);
+ options.addOption(opt);
+
opt = new Option("t", "topic", true, "set the topic");
opt.setRequired(true);
options.addOption(opt);
+ opt = new Option("i", "queue", true, "set the queue, eg: 0,1");
Review comment:
use parameter q instead of i, which is understandable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services