You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Alexander Lapin (Jira)" <ji...@apache.org> on 2023/05/12 13:09:00 UTC
[jira] [Updated] (IGNITE-19470) Variaty of NotNull message fields occured to have null values in some cases
[ https://issues.apache.org/jira/browse/IGNITE-19470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Lapin updated IGNITE-19470:
-------------------------------------
Description:
h3. Motivation
After implementing https://issues.apache.org/jira/browse/IGNITE-19437 occurred that following list of fields in messages are null despite the fact that probably they should be @NotNull, probably that means that we've forgot to add corresponding setters while building such methods.
* PlacementDriverMessage, ReplicaRequest:
{code:java}
groupId{code}
* SnapshotRequestMessage:
{code:java}
id{code}
* ReadWriteMultiRowReplicaRequest:
{code:java}
commitPartitionId{code}
* ReadWriteReplicaRequest:
{code:java}
transactionId{code}
* ReadWriteSingleRowReplicaRequest:
{code:java}
commitPartitionId{code}
h3. Definition of Done
* For each case null-ability verified and either comment is written explaining why it's valid to have null value or setter is added and @Nullable is removed.
* Tests not needed.
> Variaty of NotNull message fields occured to have null values in some cases
> ---------------------------------------------------------------------------
>
> Key: IGNITE-19470
> URL: https://issues.apache.org/jira/browse/IGNITE-19470
> Project: Ignite
> Issue Type: Bug
> Reporter: Alexander Lapin
> Priority: Major
> Labels: ignite-3
>
> h3. Motivation
> After implementing https://issues.apache.org/jira/browse/IGNITE-19437 occurred that following list of fields in messages are null despite the fact that probably they should be @NotNull, probably that means that we've forgot to add corresponding setters while building such methods.
> * PlacementDriverMessage, ReplicaRequest:
> {code:java}
> groupId{code}
> * SnapshotRequestMessage:
> {code:java}
> id{code}
> * ReadWriteMultiRowReplicaRequest:
> {code:java}
> commitPartitionId{code}
> * ReadWriteReplicaRequest:
> {code:java}
> transactionId{code}
> * ReadWriteSingleRowReplicaRequest:
> {code:java}
> commitPartitionId{code}
> h3. Definition of Done
> * For each case null-ability verified and either comment is written explaining why it's valid to have null value or setter is added and @Nullable is removed.
> * Tests not needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)