You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by su...@apache.org on 2017/04/20 03:55:40 UTC
hive git commit: HIVE-16471: Add metrics for "waiting compilation
time" (Chao Sun, reviewed by Xuefu Zhang)
Repository: hive
Updated Branches:
refs/heads/master b0a7c131d -> 28a2efd0c
HIVE-16471: Add metrics for "waiting compilation time" (Chao Sun, reviewed by Xuefu Zhang)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/28a2efd0
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/28a2efd0
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/28a2efd0
Branch: refs/heads/master
Commit: 28a2efd0c9fde800b9220bddad93c8afafb911bf
Parents: b0a7c13
Author: Chao Sun <su...@apache.org>
Authored: Wed Apr 19 20:54:46 2017 -0700
Committer: Chao Sun <su...@apache.org>
Committed: Wed Apr 19 20:54:46 2017 -0700
----------------------------------------------------------------------
common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java | 1 +
ql/src/java/org/apache/hadoop/hive/ql/Driver.java | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/28a2efd0/common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
----------------------------------------------------------------------
diff --git a/common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java b/common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
index 7f3c8b3..008b3b0 100644
--- a/common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
+++ b/common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
@@ -39,6 +39,7 @@ import java.util.Map;
public class PerfLogger {
public static final String ACQUIRE_READ_WRITE_LOCKS = "acquireReadWriteLocks";
public static final String COMPILE = "compile";
+ public static final String WAIT_COMPILE = "waitCompile";
public static final String PARSE = "parse";
public static final String ANALYZE = "semanticAnalyze";
public static final String OPTIMIZER = "optimizer";
http://git-wip-us.apache.org/repos/asf/hive/blob/28a2efd0/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/Driver.java b/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
index 03ea997..31cb4e1 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
@@ -1313,9 +1313,11 @@ public class Driver implements CommandProcessor {
metrics.incrementCounter(MetricsConstant.WAITING_COMPILE_OPS, 1);
}
+ PerfLogger perfLogger = SessionState.getPerfLogger();
+ perfLogger.PerfLogBegin(CLASS_NAME, PerfLogger.WAIT_COMPILE);
final ReentrantLock compileLock = tryAcquireCompileLock(isParallelEnabled,
command);
-
+ perfLogger.PerfLogEnd(CLASS_NAME, PerfLogger.WAIT_COMPILE);
if (metrics != null) {
metrics.decrementCounter(MetricsConstant.WAITING_COMPILE_OPS, 1);
}
@@ -1342,7 +1344,6 @@ public class Driver implements CommandProcessor {
//Save compile-time PerfLogging for WebUI.
//Execution-time Perf logs are done by either another thread's PerfLogger
//or a reset PerfLogger.
- PerfLogger perfLogger = SessionState.getPerfLogger();
queryDisplay.setPerfLogStarts(QueryDisplay.Phase.COMPILATION, perfLogger.getStartTimes());
queryDisplay.setPerfLogEnds(QueryDisplay.Phase.COMPILATION, perfLogger.getEndTimes());
return ret;