[GitHub] [airflow] zhongjiajie edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id

[GitBox <gi...@apache.org>]

zhongjiajie edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570040683
 
 
   > @zhongjiajie why do you want to remove @provide_session ? The way it works now, it will create a new session for each connection - each merge_conn will have a new session (which basically means new connection established with the database). With @provide_sesion, the session will be reused whereas with the new approach it will be create/commit/close for every single Connection entry.
   
   I think we don't need to create connect in function `create_default_connections`, because it will be create in function `merge_conn`, so I remove it. but when you comment in 
   
   > We should not remove @provide_session as it is there to make all the connections reuse session rather than recreate sessions.
   
   I get that point

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services