You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/20 20:02:36 UTC

[GitHub] [airflow] joshowen commented on a change in pull request #9452: JSON serialize logged extras

joshowen commented on a change in pull request #9452:
URL: https://github.com/apache/airflow/pull/9452#discussion_r443156183



##########
File path: airflow/www/decorators.py
##########
@@ -44,7 +45,7 @@ def wrapper(*args, **kwargs):
                 event=f.__name__,
                 task_instance=None,
                 owner=user,
-                extra=str(list(request.values.items())),
+                extra=json.dumps(request.values),

Review comment:
       The current setup doesn't produce valid json, because it is a list of tuples.  It would also be very helpful to be able to do queries in the database, since important context lives in the `extra`, eg whether or not a clear was confirmed, or a trigger had a `conf`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org