You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/10/21 22:58:32 UTC
[GitHub] [cassandra] jonmeredith commented on a change in pull request #770: CASSANDRA-13325 configure which TLS protocols should be accepted
jonmeredith commented on a change in pull request #770:
URL: https://github.com/apache/cassandra/pull/770#discussion_r509782527
##########
File path: src/java/org/apache/cassandra/config/EncryptionOptions.java
##########
@@ -204,6 +208,79 @@ public void setOptional(boolean optional) {
this.optional = optional;
}
+ /**
+ * Sets accepted TLS protocol for this channel. Note that this should only be called by
+ * the configuration parser or tests. It is public only for that purpose, mutating protocol state
+ * is probably a bad idea.
+ * @param protocol value to set
+ */
+ public void setProtocol(String protocol) {
+ this.protocol = protocol;
+ }
+
+ /**
+ * Sets accepted TLS protocols for this channel. Note that this should only be called by
+ * the configuration parser or tests. It is public only for that purpose, mutating protocl state
+ * is probably a bad idea.
+ * @param accepted_protocols value to set
+ */
+ public void setaccepted_protocols(List<String> accepted_protocols) {
Review comment:
It's for dealing with snakeyaml. After digging in a bit deeper for CASSANDRA-16144, I think it will be looking for a method named "get" + `String.capitalize("accepted_protocols")` so it wouldn't find this anyway. Method name may have been in desperation on an earlier attempt. I'll see if I can improve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org