[GitHub] [incubator-superset] kristw commented on issue #8648: Prettify the frontend code

[GitBox <gi...@apache.org>]

kristw commented on issue #8648: Prettify the frontend code
URL: https://github.com/apache/incubator-superset/pull/8648#issuecomment-558902707
 
 
   I personally prefer single quote. All `@superset-ui` repos (`superset-ui`, `superset-ui-plugins`, `superset-ui-plugins-deckgl`, `superset-ui-template`, ...) currently use single quote, which would be great to keep same consistency. It would also help Airbnb developers as Airbnb style guide prefers single quote and our internal repos all use that.
   
   All `@superset-ui` repos share same build configuration (via `beemo`) with the following `prettier` overrides. 
   https://github.com/apache-superset/build-config/blob/master/configs/prettier.js

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org