You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2022/04/08 17:29:38 UTC

[isis] branch master updated: ISIS-2297: just comments

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 0b5c9b377b ISIS-2297: just comments
0b5c9b377b is described below

commit 0b5c9b377b358afcf67a04eb91f2a5f590031e56
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri Apr 8 19:29:30 2022 +0200

    ISIS-2297: just comments
---
 .../java/org/apache/isis/core/metamodel/spec/ManagedObject.java     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java
index 8a92a5aa5f..03f5e8ea8b 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java
@@ -333,7 +333,7 @@ public interface ManagedObject {
         }
 
         @Override
-        public final  Optional<Bookmark> getBookmarkRefreshed() {
+        public final Optional<Bookmark> getBookmarkRefreshed() {
             // silently ignore invalidation, when the pojo is an entity
             if(!getSpecification().isEntity()) {
                 bookmarkLazy.clear();
@@ -350,7 +350,9 @@ public interface ManagedObject {
             bookmarkLazy.set(Optional.ofNullable(replacer.apply(old)));
         }
 
-        // guards against, non identifiable objects
+        // guards against non-identifiable objects;
+        // historically, we allowed non-identifiable to be handled by the objectManager,
+        // which as a fallback creates 'random' UUIDs
         private Optional<Bookmark> bookmark(final @Nullable ManagedObject adapter) {
 
             if(ManagedObjects.isNullOrUnspecifiedOrEmpty(adapter)