+1 on PRs!

[Maxime Beauchemin <ma...@gmail.com>]

Airflowers,

I would love if people could write simple `+1` comments on the PRs they
care about.

It's motivating for contributors to see that people want the features they
work on, and it can help committers prioritize which PRs to review and
release first.

It's also a great way to keep a pulse on the project, see what is coming
up, and to start getting involved. Of course more involved feedback
(reaction icons, comments, review) are also very welcomed.

See you on Github!

Max

Re: +1 on PRs!

[siddharth anand <sa...@apache.org>]

These are all good ideas and any would work. Our committer list is small
enough that no committer would merge without either +1'ing it
himself/herself or checking that another did.

Sure, there could be a corner cases where a contributor +1'd a PR before
being promoted to a committer and then another committer might confuse that
+1 for a "committer +1" and accidentally merge it, but I don't think we
need to worry about those special cases.

If you like a PR/JIRA, then don't worry. Make your voice heard and we
(committers) will do the right thing.

-s

On Thu, Oct 13, 2016 at 7:56 AM, Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:

> Good idea! Well even writing a comment that says "happy to see this
> feature" or something of that nature does the trick. We just have to be
> careful with +1, which apparently maps to the more common "LGTM" under the
> Apache umbrella.
>
> Personally I'd rather do as much as possible on Github, to reduce the
> notification channels and simplify our workflows.
>
> I remember a thread about moving out of Jira and into GH Issues. What was
> the final word on that?
>
> Max
>
> On Oct 13, 2016 7:17 AM, "Arthur Wiedmer" <ar...@gmail.com>
> wrote:
>
> > Another way to do this would be to use the reactions on Github.
> >
> > Use the 👍 to upvote an issue or PR you care about. And reserve the +1s
> for
> > Committer Code review.
> >
> > On top of that, it makes it easier to tally the votes.
> >
> > Best,
> > Arthur
> >
> > On Tue, Oct 11, 2016 at 2:31 PM, siddharth anand <sa...@apache.org>
> > wrote:
> >
> > > Thanks for clarifying that for the community Jakob. It's not always
> clear
> > > to a submitter whether they have received a +1 from a committer or not
> > and
> > > could lead to confusion as to whether they have received a +1 but are
> > just
> > > waiting for a merge.
> > >
> > > I think the Jira "vote" feature avoids this confusion and feel that is
> a
> > > better way forward. It has the added benefit of capturing votes for
> > > abandoned or closed-but-not-merged PRs.
> > >
> > > -s
> > >
> > > On Tue, Oct 11, 2016 at 1:19 PM, Jakob Homan <jg...@gmail.com>
> wrote:
> > >
> > > > Be sure to distinguish between +1 == I want this, and +1 == I approve
> > > > this change to be merged into the codebase.
> > > >
> > > > Non-committers are welcome and encouraged to review patches,
> including
> > > > providing +1s.  The patch can't be merged on the basis of that
> > > > non-committer +1 only (a committer's +1 is still required), but this
> > > > is good experience and contribution from the non-committer.
> > > >
> > > >
> > > > On 11 October 2016 at 12:16, Laura Lorenz <ll...@industrydive.com>
> > > > wrote:
> > > > > I started to do this and totally got myself stuck answering bug
> > reports
> > > > 😅🙃
> > > > >
> > > > > On Mon, Oct 10, 2016 at 11:33 PM, siddharth anand <
> sanand@apache.org
> > >
> > > > wrote:
> > > > >
> > > > >> Great idea, Max.
> > > > >>
> > > > >> There is also a vote feature on JIRAs. Sometimes PRs get
> abandoned,
> > > > whereas
> > > > >> the JIRA tends to stick around longer, sometimes even without an
> > > owner.
> > > > I'm
> > > > >> not sure which is the best way, but I completely agree with the
> > > > sentiment.
> > > > >>
> > > > >> -s
> > > > >>
> > > > >> On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin <
> > > > >> maximebeauchemin@gmail.com> wrote:
> > > > >>
> > > > >> > Airflowers,
> > > > >> >
> > > > >> > I would love if people could write simple `+1` comments on the
> PRs
> > > > they
> > > > >> > care about.
> > > > >> >
> > > > >> > It's motivating for contributors to see that people want the
> > > features
> > > > >> they
> > > > >> > work on, and it can help committers prioritize which PRs to
> review
> > > and
> > > > >> > release first.
> > > > >> >
> > > > >> > It's also a great way to keep a pulse on the project, see what
> is
> > > > coming
> > > > >> > up, and to start getting involved. Of course more involved
> > feedback
> > > > >> > (reaction icons, comments, review) are also very welcomed.
> > > > >> >
> > > > >> > See you on Github!
> > > > >> >
> > > > >> > Max
> > > > >> >
> > > > >>
> > > >
> > >
> >
>

Re: +1 on PRs!

[Maxime Beauchemin <ma...@gmail.com>]

Good idea! Well even writing a comment that says "happy to see this
feature" or something of that nature does the trick. We just have to be
careful with +1, which apparently maps to the more common "LGTM" under the
Apache umbrella.

Personally I'd rather do as much as possible on Github, to reduce the
notification channels and simplify our workflows.

I remember a thread about moving out of Jira and into GH Issues. What was
the final word on that?

Max

On Oct 13, 2016 7:17 AM, "Arthur Wiedmer" <ar...@gmail.com> wrote:

> Another way to do this would be to use the reactions on Github.
>
> Use the 👍 to upvote an issue or PR you care about. And reserve the +1s for
> Committer Code review.
>
> On top of that, it makes it easier to tally the votes.
>
> Best,
> Arthur
>
> On Tue, Oct 11, 2016 at 2:31 PM, siddharth anand <sa...@apache.org>
> wrote:
>
> > Thanks for clarifying that for the community Jakob. It's not always clear
> > to a submitter whether they have received a +1 from a committer or not
> and
> > could lead to confusion as to whether they have received a +1 but are
> just
> > waiting for a merge.
> >
> > I think the Jira "vote" feature avoids this confusion and feel that is a
> > better way forward. It has the added benefit of capturing votes for
> > abandoned or closed-but-not-merged PRs.
> >
> > -s
> >
> > On Tue, Oct 11, 2016 at 1:19 PM, Jakob Homan <jg...@gmail.com> wrote:
> >
> > > Be sure to distinguish between +1 == I want this, and +1 == I approve
> > > this change to be merged into the codebase.
> > >
> > > Non-committers are welcome and encouraged to review patches, including
> > > providing +1s.  The patch can't be merged on the basis of that
> > > non-committer +1 only (a committer's +1 is still required), but this
> > > is good experience and contribution from the non-committer.
> > >
> > >
> > > On 11 October 2016 at 12:16, Laura Lorenz <ll...@industrydive.com>
> > > wrote:
> > > > I started to do this and totally got myself stuck answering bug
> reports
> > > 😅🙃
> > > >
> > > > On Mon, Oct 10, 2016 at 11:33 PM, siddharth anand <sanand@apache.org
> >
> > > wrote:
> > > >
> > > >> Great idea, Max.
> > > >>
> > > >> There is also a vote feature on JIRAs. Sometimes PRs get abandoned,
> > > whereas
> > > >> the JIRA tends to stick around longer, sometimes even without an
> > owner.
> > > I'm
> > > >> not sure which is the best way, but I completely agree with the
> > > sentiment.
> > > >>
> > > >> -s
> > > >>
> > > >> On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin <
> > > >> maximebeauchemin@gmail.com> wrote:
> > > >>
> > > >> > Airflowers,
> > > >> >
> > > >> > I would love if people could write simple `+1` comments on the PRs
> > > they
> > > >> > care about.
> > > >> >
> > > >> > It's motivating for contributors to see that people want the
> > features
> > > >> they
> > > >> > work on, and it can help committers prioritize which PRs to review
> > and
> > > >> > release first.
> > > >> >
> > > >> > It's also a great way to keep a pulse on the project, see what is
> > > coming
> > > >> > up, and to start getting involved. Of course more involved
> feedback
> > > >> > (reaction icons, comments, review) are also very welcomed.
> > > >> >
> > > >> > See you on Github!
> > > >> >
> > > >> > Max
> > > >> >
> > > >>
> > >
> >
>

Re: +1 on PRs!

[Arthur Wiedmer <ar...@gmail.com>]

Another way to do this would be to use the reactions on Github.

Use the 👍 to upvote an issue or PR you care about. And reserve the +1s for
Committer Code review.

On top of that, it makes it easier to tally the votes.

Best,
Arthur

On Tue, Oct 11, 2016 at 2:31 PM, siddharth anand <sa...@apache.org> wrote:

> Thanks for clarifying that for the community Jakob. It's not always clear
> to a submitter whether they have received a +1 from a committer or not and
> could lead to confusion as to whether they have received a +1 but are just
> waiting for a merge.
>
> I think the Jira "vote" feature avoids this confusion and feel that is a
> better way forward. It has the added benefit of capturing votes for
> abandoned or closed-but-not-merged PRs.
>
> -s
>
> On Tue, Oct 11, 2016 at 1:19 PM, Jakob Homan <jg...@gmail.com> wrote:
>
> > Be sure to distinguish between +1 == I want this, and +1 == I approve
> > this change to be merged into the codebase.
> >
> > Non-committers are welcome and encouraged to review patches, including
> > providing +1s.  The patch can't be merged on the basis of that
> > non-committer +1 only (a committer's +1 is still required), but this
> > is good experience and contribution from the non-committer.
> >
> >
> > On 11 October 2016 at 12:16, Laura Lorenz <ll...@industrydive.com>
> > wrote:
> > > I started to do this and totally got myself stuck answering bug reports
> > 😅🙃
> > >
> > > On Mon, Oct 10, 2016 at 11:33 PM, siddharth anand <sa...@apache.org>
> > wrote:
> > >
> > >> Great idea, Max.
> > >>
> > >> There is also a vote feature on JIRAs. Sometimes PRs get abandoned,
> > whereas
> > >> the JIRA tends to stick around longer, sometimes even without an
> owner.
> > I'm
> > >> not sure which is the best way, but I completely agree with the
> > sentiment.
> > >>
> > >> -s
> > >>
> > >> On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin <
> > >> maximebeauchemin@gmail.com> wrote:
> > >>
> > >> > Airflowers,
> > >> >
> > >> > I would love if people could write simple `+1` comments on the PRs
> > they
> > >> > care about.
> > >> >
> > >> > It's motivating for contributors to see that people want the
> features
> > >> they
> > >> > work on, and it can help committers prioritize which PRs to review
> and
> > >> > release first.
> > >> >
> > >> > It's also a great way to keep a pulse on the project, see what is
> > coming
> > >> > up, and to start getting involved. Of course more involved feedback
> > >> > (reaction icons, comments, review) are also very welcomed.
> > >> >
> > >> > See you on Github!
> > >> >
> > >> > Max
> > >> >
> > >>
> >
>

Re: +1 on PRs!

[siddharth anand <sa...@apache.org>]

Thanks for clarifying that for the community Jakob. It's not always clear
to a submitter whether they have received a +1 from a committer or not and
could lead to confusion as to whether they have received a +1 but are just
waiting for a merge.

I think the Jira "vote" feature avoids this confusion and feel that is a
better way forward. It has the added benefit of capturing votes for
abandoned or closed-but-not-merged PRs.

-s

On Tue, Oct 11, 2016 at 1:19 PM, Jakob Homan <jg...@gmail.com> wrote:

> Be sure to distinguish between +1 == I want this, and +1 == I approve
> this change to be merged into the codebase.
>
> Non-committers are welcome and encouraged to review patches, including
> providing +1s.  The patch can't be merged on the basis of that
> non-committer +1 only (a committer's +1 is still required), but this
> is good experience and contribution from the non-committer.
>
>
> On 11 October 2016 at 12:16, Laura Lorenz <ll...@industrydive.com>
> wrote:
> > I started to do this and totally got myself stuck answering bug reports
> 😅🙃
> >
> > On Mon, Oct 10, 2016 at 11:33 PM, siddharth anand <sa...@apache.org>
> wrote:
> >
> >> Great idea, Max.
> >>
> >> There is also a vote feature on JIRAs. Sometimes PRs get abandoned,
> whereas
> >> the JIRA tends to stick around longer, sometimes even without an owner.
> I'm
> >> not sure which is the best way, but I completely agree with the
> sentiment.
> >>
> >> -s
> >>
> >> On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin <
> >> maximebeauchemin@gmail.com> wrote:
> >>
> >> > Airflowers,
> >> >
> >> > I would love if people could write simple `+1` comments on the PRs
> they
> >> > care about.
> >> >
> >> > It's motivating for contributors to see that people want the features
> >> they
> >> > work on, and it can help committers prioritize which PRs to review and
> >> > release first.
> >> >
> >> > It's also a great way to keep a pulse on the project, see what is
> coming
> >> > up, and to start getting involved. Of course more involved feedback
> >> > (reaction icons, comments, review) are also very welcomed.
> >> >
> >> > See you on Github!
> >> >
> >> > Max
> >> >
> >>
>

Re: +1 on PRs!

[Jakob Homan <jg...@gmail.com>]

Be sure to distinguish between +1 == I want this, and +1 == I approve
this change to be merged into the codebase.

Non-committers are welcome and encouraged to review patches, including
providing +1s.  The patch can't be merged on the basis of that
non-committer +1 only (a committer's +1 is still required), but this
is good experience and contribution from the non-committer.


On 11 October 2016 at 12:16, Laura Lorenz <ll...@industrydive.com> wrote:
> I started to do this and totally got myself stuck answering bug reports 😅🙃
>
> On Mon, Oct 10, 2016 at 11:33 PM, siddharth anand <sa...@apache.org> wrote:
>
>> Great idea, Max.
>>
>> There is also a vote feature on JIRAs. Sometimes PRs get abandoned, whereas
>> the JIRA tends to stick around longer, sometimes even without an owner. I'm
>> not sure which is the best way, but I completely agree with the sentiment.
>>
>> -s
>>
>> On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin <
>> maximebeauchemin@gmail.com> wrote:
>>
>> > Airflowers,
>> >
>> > I would love if people could write simple `+1` comments on the PRs they
>> > care about.
>> >
>> > It's motivating for contributors to see that people want the features
>> they
>> > work on, and it can help committers prioritize which PRs to review and
>> > release first.
>> >
>> > It's also a great way to keep a pulse on the project, see what is coming
>> > up, and to start getting involved. Of course more involved feedback
>> > (reaction icons, comments, review) are also very welcomed.
>> >
>> > See you on Github!
>> >
>> > Max
>> >
>>

Re: +1 on PRs!

[Laura Lorenz <ll...@industrydive.com>]

I started to do this and totally got myself stuck answering bug reports 😅🙃

On Mon, Oct 10, 2016 at 11:33 PM, siddharth anand <sa...@apache.org> wrote:

> Great idea, Max.
>
> There is also a vote feature on JIRAs. Sometimes PRs get abandoned, whereas
> the JIRA tends to stick around longer, sometimes even without an owner. I'm
> not sure which is the best way, but I completely agree with the sentiment.
>
> -s
>
> On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin <
> maximebeauchemin@gmail.com> wrote:
>
> > Airflowers,
> >
> > I would love if people could write simple `+1` comments on the PRs they
> > care about.
> >
> > It's motivating for contributors to see that people want the features
> they
> > work on, and it can help committers prioritize which PRs to review and
> > release first.
> >
> > It's also a great way to keep a pulse on the project, see what is coming
> > up, and to start getting involved. Of course more involved feedback
> > (reaction icons, comments, review) are also very welcomed.
> >
> > See you on Github!
> >
> > Max
> >
>

Re: +1 on PRs!

[siddharth anand <sa...@apache.org>]

Great idea, Max.

There is also a vote feature on JIRAs. Sometimes PRs get abandoned, whereas
the JIRA tends to stick around longer, sometimes even without an owner. I'm
not sure which is the best way, but I completely agree with the sentiment.

-s

On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:

> Airflowers,
>
> I would love if people could write simple `+1` comments on the PRs they
> care about.
>
> It's motivating for contributors to see that people want the features they
> work on, and it can help committers prioritize which PRs to review and
> release first.
>
> It's also a great way to keep a pulse on the project, see what is coming
> up, and to start getting involved. Of course more involved feedback
> (reaction icons, comments, review) are also very welcomed.
>
> See you on Github!
>
> Max
>