Re: [PR] GUACAMOLE-288: Add support for multi-monitor connections on RDP. [guacamole-client]

["ciroiriarte (via GitHub)" <gi...@apache.org>]

ciroiriarte commented on PR #1061:
URL: https://github.com/apache/guacamole-client/pull/1061#issuecomment-5026414348

   @corentin-soriano — following up on your reply about testing this: I've been running
   this branch as the base for multi-monitor support in the SPICE protocol client
   (GUACAMOLE-261), which surfaced six issues in the shared multi-monitor code. All are
   protocol-agnostic, so rather than carry them in my fork I've opened them against your
   branch: corentin-soriano/guacamole-client#3.
   
   Two of the six are items already on your WIP list here:
   
   - **Use a dedicated BroadcastChannel for each connection.** The fixed `guac_monitors`
     channel name is shared by every connection open in a browser, so with two
     connections active a secondary window's input reaches the other connection's guacd
     stream. Implemented with a per-connection id in both the channel name and a tag on
     each message.
   - **Reorder monitors vertically if needed.** Positions are assigned by window-opening
     order, and that index is what's sent to guacd — so a vertical stack has no
     meaningful ordering. Now ordered by reported geometry.
   
   The other four are an absolute left offset in `getOffsetX()` (it currently sums widths,
   which assumes the equal-width row you described above and breaks once windows have
   different dimensions), a display crop on monitor size change, debouncing the resize
   storm, and validating the `multimon-layout` payload before use.
   
   Each commit is standalone apart from one stated dependency, so take or drop them
   individually. 24/24 specs pass and the frontend builds; the details, including what
   isn't covered by tests, are in the PR description.
   
   One thing worth flagging separately: the branch is a fair way behind current main and
   no longer shares a dependency tree with it (main has moved to
   `angular-templatecache-webpack5-plugin`), so a rebase is probably due before review
   picks up again. Happy to redo these six on top of a rebased branch if that helps.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org