You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/10/03 11:19:07 UTC
[GitHub] [rocketmq-exporter] sunxi92 opened a new pull request #75: delete duplicate logic in the method of collectBrokerStatsTopic in the MetricsCollectTask.java
sunxi92 opened a new pull request #75:
URL: https://github.com/apache/rocketmq-exporter/pull/75
#74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-exporter] maixiaohai commented on a change in pull request #75: delete duplicate logic in the method of collectBrokerStatsTopic in the MetricsCollectTask.java
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on a change in pull request #75:
URL: https://github.com/apache/rocketmq-exporter/pull/75#discussion_r727035566
##########
File path: src/main/java/org/apache/rocketmq/exporter/task/MetricsCollectTask.java
##########
@@ -430,26 +430,6 @@ public void collectBrokerStatsTopic() {
} catch (RemotingTimeoutException | InterruptedException | RemotingSendRequestException | RemotingConnectException ex1) {
log.error(String.format("TOPIC_PUT_NUMS-error, topic=%s, master broker=%s", topic, masterAddr), ex1);
}
- try {
- //how many bytes has sent for the topic
- bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.TOPIC_PUT_SIZE, topic);
Review comment:
metrics is diffrent？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org