You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "solomax (via GitHub)" <gi...@apache.org> on 2026/10/13 03:29:02 UTC
[PR] Fixes issue #1658: quickstart is tested during build [wicket]
solomax opened a new pull request, #1663:
URL: https://github.com/apache/wicket/pull/1663
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue #1658: quickstart is tested during build [wicket]
Posted by "dashorst (via GitHub)" <gi...@apache.org>.
dashorst commented on code in PR #1663:
URL: https://github.com/apache/wicket/pull/1663#discussion_r4258222103
##########
archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java:
##########
@@ -17,34 +17,30 @@
package ${package};
import java.lang.management.ManagementFactory;
-import java.time.Duration;
import javax.management.MBeanServer;
import org.apache.wicket.protocol.ws.javax.WicketServerEndpointConfig;
+import org.eclipse.jetty.ee11.servlet.ServletContextHandler;
+import org.eclipse.jetty.ee11.webapp.WebAppContext;
+import org.eclipse.jetty.ee11.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer;
import org.eclipse.jetty.jmx.MBeanContainer;
import org.eclipse.jetty.server.HttpConfiguration;
import org.eclipse.jetty.server.HttpConnectionFactory;
import org.eclipse.jetty.server.SecureRequestCustomizer;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
import org.eclipse.jetty.server.SslConnectionFactory;
-import org.eclipse.jetty.session.DefaultSessionCache;
-import org.eclipse.jetty.session.FileSessionDataStore;
import org.eclipse.jetty.util.resource.Resource;
import org.eclipse.jetty.util.resource.ResourceFactory;
import org.eclipse.jetty.util.ssl.SslContextFactory;
-import org.eclipse.jetty.ee11.servlet.ServletContextHandler;
-import org.eclipse.jetty.ee11.webapp.WebAppContext;
-import org.eclipse.jetty.ee11.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer;
/**
* Separate startup class for people that want to run the examples directly. Use parameter
* -Dcom.sun.management.jmxremote to startup JMX (and e.g. connect with jconsole).
*/
public class Start
{
- private static final int TIMEOUT = (int) Duration.ofHours(1).toMillis();
Review Comment:
Agreed. The agent thought this was a drive by change not related to the ticket 🙈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue #1658: quickstart is tested during build [wicket]
Posted by "solomax (via GitHub)" <gi...@apache.org>.
solomax commented on code in PR #1663:
URL: https://github.com/apache/wicket/pull/1663#discussion_r4258519317
##########
archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java:
##########
@@ -17,34 +17,30 @@
package ${package};
import java.lang.management.ManagementFactory;
-import java.time.Duration;
import javax.management.MBeanServer;
import org.apache.wicket.protocol.ws.javax.WicketServerEndpointConfig;
+import org.eclipse.jetty.ee11.servlet.ServletContextHandler;
+import org.eclipse.jetty.ee11.webapp.WebAppContext;
+import org.eclipse.jetty.ee11.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer;
import org.eclipse.jetty.jmx.MBeanContainer;
import org.eclipse.jetty.server.HttpConfiguration;
import org.eclipse.jetty.server.HttpConnectionFactory;
import org.eclipse.jetty.server.SecureRequestCustomizer;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
import org.eclipse.jetty.server.SslConnectionFactory;
-import org.eclipse.jetty.session.DefaultSessionCache;
-import org.eclipse.jetty.session.FileSessionDataStore;
import org.eclipse.jetty.util.resource.Resource;
import org.eclipse.jetty.util.resource.ResourceFactory;
import org.eclipse.jetty.util.ssl.SslContextFactory;
-import org.eclipse.jetty.ee11.servlet.ServletContextHandler;
-import org.eclipse.jetty.ee11.webapp.WebAppContext;
-import org.eclipse.jetty.ee11.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer;
/**
* Separate startup class for people that want to run the examples directly. Use parameter
* -Dcom.sun.management.jmxremote to startup JMX (and e.g. connect with jconsole).
*/
public class Start
{
- private static final int TIMEOUT = (int) Duration.ofHours(1).toMillis();
Review Comment:
I guess, you now need to approve this pr ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue #1658: quickstart is tested during build [wicket]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1663:
URL: https://github.com/apache/wicket/pull/1663#issuecomment-6137662844
## [Codecov](https://app.codecov.io/gh/apache/wicket/pull/1663?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 61.96%. Comparing base ([`40f37ca`](https://app.codecov.io/gh/apache/wicket/commit/40f37caca5723b85828eb4e31cfeeadf33dc3837?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff34dc0`](https://app.codecov.io/gh/apache/wicket/commit/ff34dc089b690492a7178b9c1c576cb49f1f3bc0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1663 +/- ##
============================================
- Coverage 61.96% 61.96% -0.01%
+ Complexity 11287 11285 -2
============================================
Files 1250 1250
Lines 48437 48437
Branches 6796 6796
============================================
- Hits 30015 30014 -1
Misses 15729 15729
- Partials 2693 2694 +1
```
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue #1658: quickstart is tested during build [wicket]
Posted by "solomax (via GitHub)" <gi...@apache.org>.
solomax merged PR #1663:
URL: https://github.com/apache/wicket/pull/1663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue #1658: quickstart is tested during build [wicket]
Posted by "solomax (via GitHub)" <gi...@apache.org>.
solomax commented on PR #1663:
URL: https://github.com/apache/wicket/pull/1663#issuecomment-6137730373
```
[INFO] Processing Archetype IT project: sample-it-test
[INFO] ----------------------------------------------------------------------------
[INFO] Using following parameters for creating project from Archetype: wicket-archetype-quickstart:11.0.0-SNAPSHOT
[INFO] ----------------------------------------------------------------------------
[INFO] Parameter: groupId, Value: org.apache.wicket.example
[INFO] Parameter: artifactId, Value: my-test-app
[INFO] Parameter: version, Value: 1.0.0-SNAPSHOT
[INFO] Parameter: package, Value: org.apache.wicket.example
[INFO] Parameter: packageInPathFormat, Value: org/apache/wicket/example
[INFO] Parameter: package, Value: org.apache.wicket.example
[INFO] Parameter: groupId, Value: org.apache.wicket.example
[INFO] Parameter: artifactId, Value: my-test-app
[INFO] Parameter: version, Value: 1.0.0-SNAPSHOT
[INFO] Project created from Archetype in dir: /home/runner/work/wicket/wicket/archetypes/quickstart/target/test-classes/projects/sample-it-test/project/my-test-app
[INFO] Invoking post-archetype-generation goals: clean verify
[INFO] [INFO] Error stacktraces are turned on.
[INFO] [INFO] Scanning for projects...
[INFO] [WARNING] The requested profile "js-test" could not be activated because it does not exist.
[INFO] [WARNING] The requested profile "coverage" could not be activated because it does not exist.
[INFO] [INFO]
[INFO] [INFO] ---------------< org.apache.wicket.example:my-test-app >----------------
[INFO] [INFO] Building quickstart 1.0.0-SNAPSHOT
[INFO] [INFO] from pom.xml
[INFO] [INFO] --------------------------------[ war ]---------------------------------
[INFO] [INFO]
[INFO] [INFO] --- clean:3.2.0:clean (default-clean) @ my-test-app ---
[INFO] [INFO]
[INFO] [INFO] --- resources:3.4.0:resources (default-resources) @ my-test-app ---
[INFO] [INFO] Copying 0 resource from src/main/resources to target/classes
[INFO] [INFO] Copying 1 resource from src/main/java to target/classes
[INFO] [INFO]
[INFO] [INFO] --- compiler:3.16.0:compile (default-compile) @ my-test-app ---
[INFO] [INFO] Recompiling the module because of changed source code.
[INFO] [INFO] Compiling 2 source files with javac [debug deprecation target 21] to target/classes
[INFO] [INFO]
[INFO] [INFO] --- resources:3.4.0:testResources (default-testResources) @ my-test-app ---
[INFO] [INFO] Copying 1 resource from src/test/resources to target/test-classes
[INFO] [INFO] Copying 0 resource from src/test/java to target/test-classes
[INFO] [INFO]
[INFO] [INFO] --- compiler:3.16.0:testCompile (default-testCompile) @ my-test-app ---
[INFO] [INFO] Recompiling the module because of changed dependency.
[INFO] [INFO] Compiling 2 source files with javac [debug deprecation target 21] to target/test-classes
[INFO] [INFO]
[INFO] [INFO] --- surefire:3.5.4:test (default-test) @ my-test-app ---
[INFO] [INFO] Surefire report directory: /home/runner/work/wicket/wicket/archetypes/quickstart/target/test-classes/projects/sample-it-test/project/my-test-app/target/surefire-reports
[INFO] [INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO] [INFO]
[INFO] [INFO] -------------------------------------------------------
[INFO] [INFO] T E S T S
[INFO] [INFO] -------------------------------------------------------
[INFO] [INFO] Running org.apache.wicket.example.TestHomePage
[INFO] [main] INFO org.apache.wicket.Application - [WicketTesterApplication-a15ee879-a19c-41fc-a84d-c8d8bf1d090c] init: Wicket core library initializer
[INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 s -- in org.apache.wicket.example.TestHomePage
[INFO] [INFO]
[INFO] [INFO] Results:
[INFO] [INFO]
[INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] [INFO]
[INFO] [INFO]
[INFO] [INFO] --- war:3.5.1:war (default-war) @ my-test-app ---
[INFO] [INFO] Packaging webapp
[INFO] [INFO] Assembling webapp [my-test-app] in [/home/runner/work/wicket/wicket/archetypes/quickstart/target/test-classes/projects/sample-it-test/project/my-test-app/target/my-test-app-1.0.0-SNAPSHOT]
[INFO] [INFO] Processing war project
[INFO] [INFO] Copying webapp resources [/home/runner/work/wicket/wicket/archetypes/quickstart/target/test-classes/projects/sample-it-test/project/my-test-app/src/main/webapp]
[INFO] [INFO] Building war: /home/runner/work/wicket/wicket/archetypes/quickstart/target/test-classes/projects/sample-it-test/project/my-test-app/target/my-test-app-1.0.0-SNAPSHOT.war
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD SUCCESS
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time: 11.519 s
[INFO] [INFO] Finished at: 2026-10-13T03:36:15Z
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [WARNING] The requested profile "js-test" could not be activated because it does not exist.
[INFO] [WARNING] The requested profile "coverage" could not be activated because it does not exist.
[INFO] Post-archetype-generation invoker exit code: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue #1658: quickstart is tested during build [wicket]
Posted by "solomax (via GitHub)" <gi...@apache.org>.
solomax commented on code in PR #1663:
URL: https://github.com/apache/wicket/pull/1663#discussion_r4257214916
##########
archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java:
##########
@@ -17,34 +17,30 @@
package ${package};
import java.lang.management.ManagementFactory;
-import java.time.Duration;
import javax.management.MBeanServer;
import org.apache.wicket.protocol.ws.javax.WicketServerEndpointConfig;
+import org.eclipse.jetty.ee11.servlet.ServletContextHandler;
+import org.eclipse.jetty.ee11.webapp.WebAppContext;
+import org.eclipse.jetty.ee11.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer;
import org.eclipse.jetty.jmx.MBeanContainer;
import org.eclipse.jetty.server.HttpConfiguration;
import org.eclipse.jetty.server.HttpConnectionFactory;
import org.eclipse.jetty.server.SecureRequestCustomizer;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
import org.eclipse.jetty.server.SslConnectionFactory;
-import org.eclipse.jetty.session.DefaultSessionCache;
-import org.eclipse.jetty.session.FileSessionDataStore;
import org.eclipse.jetty.util.resource.Resource;
import org.eclipse.jetty.util.resource.ResourceFactory;
import org.eclipse.jetty.util.ssl.SslContextFactory;
-import org.eclipse.jetty.ee11.servlet.ServletContextHandler;
-import org.eclipse.jetty.ee11.webapp.WebAppContext;
-import org.eclipse.jetty.ee11.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer;
/**
* Separate startup class for people that want to run the examples directly. Use parameter
* -Dcom.sun.management.jmxremote to startup JMX (and e.g. connect with jconsole).
*/
public class Start
{
- private static final int TIMEOUT = (int) Duration.ofHours(1).toMillis();
Review Comment:
IMO this way it is more readable :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org