You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by yew1eb <gi...@git.apache.org> on 2017/08/10 16:03:12 UTC

[GitHub] flink pull request #4519: [FLINK-7415][Cassandra Connector] Add comments for...

GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/4519

    [FLINK-7415][Cassandra Connector] Add comments for `BatchExample.java`

    ## What is the purpose of the change
    Help beginners follow it with less confusion. 
    
    ## Brief change log
    - Add comments for cassandra batch-test class `BatchExample.java`
    
    ## Verifying this change
    
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink FLINK-7415

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4519
    
----
commit 62fbc338f5049bebd5b770f66938b9394677dbe9
Author: yew1eb <ye...@gmail.com>
Date:   2017-08-10T15:28:00Z

    add comments for BatchExample.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4519: [FLINK-7415][Cassandra Connector] Add comments for cassan...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4519
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4519: [FLINK-7415][Cassandra Connector] Add comments for...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4519


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4519: [FLINK-7415][Cassandra Connector] Add comments for `Batch...

Posted by yew1eb <gi...@git.apache.org>.

Github user yew1eb commented on the issue:

    https://github.com/apache/flink/pull/4519
  
    I ran the test class with an exception, I found the cause finally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4519: [FLINK-7415][Cassandra Connector] Add comments for cassan...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4519
  
    +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---