You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Scott Hraban (JIRA)" <ji...@apache.org> on 2010/06/08 22:23:12 UTC
[jira] Created: (WICKET-2908) BaseWicketTester should check for
visibility in hierarchy when building param map
BaseWicketTester should check for visibility in hierarchy when building param map
---------------------------------------------------------------------------------
Key: WICKET-2908
URL: https://issues.apache.org/jira/browse/WICKET-2908
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.8
Reporter: Scott Hraban
Priority: Minor
Fix For: 1.4.10, 1.5-M1
In BaseWicketTester::submitAjaxFormSubmitBehavior, the code checks formComponent.isVisible() to determine if the component values should be added to the params map.
However, it does not check isVisibleInHierarchy, as it does for isEnabledInHierarchy.
Thus even if the parent of a component is not visible, if the component itself is not explicitly invisible, it gets added to the params map.
This conflicts with Form::findSubmittingButton(), which uses isVisibleInHierarchy(), so when testing, if a button's parent is not visible, but it itself is not explicitly not visible, then the button is sent in the request, which may cause findSubmittingButton to throw an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2908) BaseWicketTester should check for
visibility in hierarchy when building param map
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888629#action_12888629 ]
Hudson commented on WICKET-2908:
--------------------------------
Integrated in Apache Wicket 1.4.x #37 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.4.x/37/])
> BaseWicketTester should check for visibility in hierarchy when building param map
> ---------------------------------------------------------------------------------
>
> Key: WICKET-2908
> URL: https://issues.apache.org/jira/browse/WICKET-2908
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.8
> Reporter: Scott Hraban
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.10
>
>
> In BaseWicketTester::submitAjaxFormSubmitBehavior, the code checks formComponent.isVisible() to determine if the component values should be added to the params map.
> However, it does not check isVisibleInHierarchy, as it does for isEnabledInHierarchy.
> Thus even if the parent of a component is not visible, if the component itself is not explicitly invisible, it gets added to the params map.
> This conflicts with Form::findSubmittingButton(), which uses isVisibleInHierarchy(), so when testing, if a button's parent is not visible, but it itself is not explicitly not visible, then the button is sent in the request, which may cause findSubmittingButton to throw an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2908) BaseWicketTester should check for
visibility in hierarchy when building param map
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2908.
----------------------------------------
Assignee: Juergen Donnerstag
Fix Version/s: (was: 1.5-M1)
Resolution: Fixed
fixed in 1.4.
The 1.5 code looks completely different
> BaseWicketTester should check for visibility in hierarchy when building param map
> ---------------------------------------------------------------------------------
>
> Key: WICKET-2908
> URL: https://issues.apache.org/jira/browse/WICKET-2908
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.8
> Reporter: Scott Hraban
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.10
>
>
> In BaseWicketTester::submitAjaxFormSubmitBehavior, the code checks formComponent.isVisible() to determine if the component values should be added to the params map.
> However, it does not check isVisibleInHierarchy, as it does for isEnabledInHierarchy.
> Thus even if the parent of a component is not visible, if the component itself is not explicitly invisible, it gets added to the params map.
> This conflicts with Form::findSubmittingButton(), which uses isVisibleInHierarchy(), so when testing, if a button's parent is not visible, but it itself is not explicitly not visible, then the button is sent in the request, which may cause findSubmittingButton to throw an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.