[GitHub] [rocketmq] chenzlalvin commented on a diff in pull request #6786: [ISSUE #6785] Isolate the remoteChannel by group

["chenzlalvin (via GitHub)" <gi...@apache.org>]

chenzlalvin commented on code in PR #6786:
URL: https://github.com/apache/rocketmq/pull/6786#discussion_r1201348073


##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/HeartbeatSyncer.java:
##########
@@ -49,7 +49,7 @@ public class HeartbeatSyncer extends AbstractSystemMessageSyncer {
 
     protected ThreadPoolExecutor threadPoolExecutor;
     protected ConsumerManager consumerManager;
-    protected final Map<String /* channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>();
+    protected final Map<String /* group @ channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>();

Review Comment:
   Will the "@" symbol conflict with the Group character?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org